Merge pull request #214 from appunite/fix/change_type_of_id

[LD-164] Change type of id to Long.
appunite · Mar 11, 2024 · 0ec85eb · 0ec85eb
2 parents 00543b7 + c7cd809
commit 0ec85eb
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/app/src/main/java/com/appunite/loudius/network/model/PullRequest.kt b/app/src/main/java/com/appunite/loudius/network/model/PullRequest.kt
@@ -24,7 +24,7 @@ import kotlinx.serialization.Serializable
 
 @Serializable
 data class PullRequest(
-    val id: Int,
+    val id: Long,
     val draft: Boolean,
     val number: Int,
     @SerialName("repository_url")

diff --git a/app/src/main/java/com/appunite/loudius/ui/pullrequests/PullRequestsViewModel.kt b/app/src/main/java/com/appunite/loudius/ui/pullrequests/PullRequestsViewModel.kt
@@ -28,7 +28,7 @@ import com.appunite.loudius.network.model.PullRequest
 import kotlinx.coroutines.launch
 
 sealed class PulLRequestsAction {
-    data class ItemClick(val id: Int) : PulLRequestsAction()
+    data class ItemClick(val id: Long) : PulLRequestsAction()
     object OnNavigateToReviewers : PulLRequestsAction()
     object RetryClick : PulLRequestsAction()
 }
@@ -102,7 +102,7 @@ class PullRequestsViewModel(
         is PulLRequestsAction.RetryClick -> fetchData()
     }
 
-    private fun navigateToReviewers(itemClickedId: Int) {
+    private fun navigateToReviewers(itemClickedId: Long) {
         val successData = state.data as? Data.Success ?: return
         val index = successData.pullRequests.indexOfFirst { it.id == itemClickedId }
         val itemClickedData = successData.pullRequests[index]

diff --git a/app/src/test/java/com/appunite/loudius/util/Defaults.kt b/app/src/test/java/com/appunite/loudius/util/Defaults.kt
@@ -30,10 +30,10 @@ object Defaults {
     val date2: Instant = Instant.parse("2022-01-29T11:00:00Z")
     val date3: Instant = Instant.parse("2022-01-29T12:00:00Z")
 
-    fun pullRequest(id: Int = 1) = PullRequest(
+    fun pullRequest(id: Long = 1) = PullRequest(
         id = id,
         draft = false,
-        number = id,
+        number = id.toInt(),
         repositoryUrl = "https://api.github.com/repos/exampleOwner/exampleRepo",
         title = "example title",
         Instant.parse("2023-03-07T08:21:45Z").plus(id.toLong().hours)