Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Angular 14 #235

Merged
merged 14 commits into from
Jul 12, 2022
Merged

Upgrade to Angular 14 #235

merged 14 commits into from
Jul 12, 2022

Conversation

steffinchen
Copy link
Contributor

@steffinchen steffinchen commented Jun 22, 2022

Summary

Update Angular to version 14.

  • Using typed forms
  • Added title strategy to provide better page titles
  • Targets ES2020

Closes #225

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking,
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

ng update @angular/cdk @angular/cli @angular/core @ngrx/store @angular-eslint/schematics@next
@steffinchen steffinchen added enhancement New feature or request dependency Depedency update labels Jun 22, 2022
@steffinchen steffinchen requested a review from a team as a code owner June 22, 2022 09:31
@steffinchen steffinchen marked this pull request as draft June 22, 2022 10:54
@steffinchen steffinchen temporarily deployed to preview June 30, 2022 14:25 Inactive
@steffinchen steffinchen temporarily deployed to preview June 30, 2022 14:26 Inactive
@github-actions
Copy link

🚀 Preview deployment active

App URL https://portal-pr-235-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision 2c21a55
Helm release appuio-control-api-preview/portal-pr-235
Cluster https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

@steffinchen steffinchen marked this pull request as ready for review June 30, 2022 14:28
@steffinchen steffinchen requested a review from a team June 30, 2022 14:28
@mircowidmer
Copy link
Contributor

@steffinchen I just realized, that the README.md has an incorrect reference to running e2e tests. Can you replace npm run e2e with npm run e2e-dev in the README.md file? Other than that, this MR looks super good to me, thanks!

@mircowidmer
Copy link
Contributor

@steffinchen I stumbled upon https://www.youtube.com/watch?v=gCKjsd4gaxI&list=WL&index=1 and suggest, that we use these new checks as well in this project. Do you agree?

@corvus-ch
Copy link
Contributor

@steffinchen I stumbled upon https://www.youtube.com/watch?v=gCKjsd4gaxI&list=WL&index=1 and suggest, that we use these new checks as well in this project. Do you agree?

I agree on making use of Angular Extended Diagnostics. Enabling such tools, usually required some none trivial clean up/refactoring. This is scope creep for this PR. So, please do so in a PR of its own.

@steffinchen steffinchen temporarily deployed to preview July 12, 2022 07:32 Inactive
@steffinchen steffinchen temporarily deployed to preview July 12, 2022 07:33 Inactive
@github-actions
Copy link

🚀 Preview deployment active

App URL https://portal-pr-235-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision 4593c4d
Helm release appuio-control-api-preview/portal-pr-235
Cluster https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

@steffinchen steffinchen merged commit 753c7d3 into master Jul 12, 2022
@steffinchen steffinchen deleted the 225-upgrade-angular-14 branch July 12, 2022 07:36
@steffinchen steffinchen temporarily deployed to preview July 12, 2022 07:36 Inactive
@github-actions
Copy link

✔️ Preview deployment uninstalled

Helm release appuio-control-api-preview/portal-pr-235
Cluster https://api.cloudscale-lpg-2.appuio.cloud:6443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Depedency update enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 14 update
3 participants