Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to programmatically dismiss the FeedbackViewController #28

Closed
nullptr2this opened this issue Jan 2, 2013 · 3 comments
Closed
Assignees
Milestone

Comments

@nullptr2this
Copy link

Unless I'm crazy and I just don't see it, there is no public API for dismissing the FeedbackViewController as of version 0.4.7.

I can present the view controller:

[[ATConnect sharedConnection] presentFeedbackControllerFromViewController:someViewController];

But I do not see a way to dismiss it. We have a scenario where an incoming push notification triggers a deep link into our application and I want to make sure that when this deep linking occurs that we ask the user if they would like abandon entering feedback and if so dismiss the feedback view controller appropriately.

I thought that the absence of a call to dismiss the feedback view controller in the api indicated that it was modal and could be dismissed using either dimissModalViewControllerAnimated: or dismissViewControllerAnimated:completion: but these do not appear to work. I see now from looking at the code in GitHub that views are being added into the root window (mostly to support screen capture I think) and that currently the only dismissal is by user interaction with the cancel button.

@ghost ghost assigned wooster Jan 3, 2013
@wooster
Copy link
Contributor

wooster commented Jan 3, 2013

Yeah, you're right.

@wooster
Copy link
Contributor

wooster commented Jan 14, 2013

I've scheduled this for the next release, 0.4.8.

@wooster
Copy link
Contributor

wooster commented Feb 2, 2013

Thanks, this should be fixed now in top of tree (or tag v0.4.8).

@wooster wooster closed this as completed Feb 2, 2013
pkamb added a commit that referenced this issue Sep 3, 2015
IOSOSX-69 - Mark messages as read when rendered in Message Center UI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants