feat: exclude ai queries from function calling

[znamenskii-ilia]

Description

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Anvil"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13457393528
Commit: 3216f72
Cypress dashboard.
Tags: @tag.Anvil
Spec:

---

Fri, 21 Feb 2025 13:30:05 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features
  • Enhanced the options available during configuration by refining the filtering logic for actions. This update streamlines the selection process, ensuring users see a more focused and relevant list in configuration controls.

[coderabbitai]

Walkthrough

The changes update the filtering logic within the selectQueryEntityOptions function by introducing an exclusion for actions where pluginType is "AI" and pluginName is "Appsmith AI". Additionally, the error suppression comment in the selectSystemFunctionEntityOptions function has been updated from @ts-ignore to @ts-expect-error. No changes were made to exported or public entity declarations.

Changes

File	Change Summary
app/client/src/.../FunctionCallingConfigControl/components/selectors.ts	In selectQueryEntityOptions, added a filter to exclude actions with pluginType: "AI" and pluginName: "Appsmith AI" along with a TS error suppression comment. In selectSystemFunctionEntityOptions, updated the comment from @ts-ignore to @ts-expect-error to clarify type-related concerns.

Possibly related PRs

• fix: fix enum #39321: Similar modifications to TypeScript error-handling comments in the selectSystemFunctionEntityOptions function link this PR at a code level.
• fix: fix enum #39320: Involves changes in the action filtering logic in the same function, indicating a direct code-level relationship.

Suggested labels

Bug, ok-to-test

Suggested reviewers

• KelvinOm
• ApekshaBhosale

In the realm of code where filters dance,
A line of logic takes its chance.
Excluding AI with careful flair,
TS comments now clearer, fair.
A small change but bold in art,
In our code, a brand new start!
🎉 Happy coding, from the heart!

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

app/client/src/components/formControls/FunctionCallingConfigControl/components/selectors.ts (1)

43-69: Consider extracting magic strings and improving type safety.

The filtering logic could be improved for maintainability and type safety:

1. Extract "AI" and "Appsmith AI" as constants
2. Consider adding proper type guards instead of using @ts-expect-error

+ const AI_PLUGIN_TYPE = "AI";
+ const APPSMITH_AI_PLUGIN_NAME = "Appsmith AI";
+
+ interface ActionConfig {
+   pluginType: string;
+   pluginName: string;
+   id: string;
+   name: string;
+   pluginId: string;
+ }
+
+ const isNonAIAction = (action: { config: ActionConfig }) =>
+   action.config.pluginType !== AI_PLUGIN_TYPE &&
+   action.config.pluginName !== APPSMITH_AI_PLUGIN_NAME;

  return getActions(state)
    // TODO: Remove filtering once AIChat is a separate entity
-   .filter(
-     (action) =>
-       action.config.pluginType !== "AI" &&
-       // @ts-expect-error No way to narrow down proper type
-       action.config.pluginName !== "Appsmith AI",
-   )
+   .filter(isNonAIAction)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2fce726 and 3216f72.

📒 Files selected for processing (1)

• app/client/src/components/formControls/FunctionCallingConfigControl/components/selectors.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: perform-test / rts-build / build
• GitHub Check: perform-test / server-build / server-unit-tests
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
• GitHub Check: client-prettier / prettier-check
• GitHub Check: client-lint / client-lint
• GitHub Check: client-build / client-build

🔇 Additional comments (1)

app/client/src/components/formControls/FunctionCallingConfigControl/components/selectors.ts (1)

118-119: LGTM! Good use of @ts-expect-error.

The change from @ts-ignore to @ts-expect-error is more appropriate here as it explicitly indicates an expected type error and will fail if the error no longer exists.