Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated the ci config files with the hubspot token #39384

Merged
merged 8 commits into from
Feb 21, 2025

Conversation

laveena-en
Copy link
Contributor

@laveena-en laveena-en commented Feb 20, 2025

/ok-to-test tags="@tag.Snowflake"## Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13448661796
Commit: d4e4d31
Cypress dashboard.
Tags: @tag.Snowflake
Spec:


Fri, 21 Feb 2025 02:33:22 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Chores
    • Enhanced our automated testing configuration by including secure integration credentials in the test workflows.

@laveena-en laveena-en requested a review from sharat87 as a code owner February 20, 2025 16:45
Copy link
Contributor

coderabbitai bot commented Feb 20, 2025

Walkthrough

This pull request updates four GitHub Actions workflow files to add a new environment variable, CYPRESS_HUBSPOT_TOKEN. The variable is set to ${{ secrets.HUBSPOT_TOKEN }} in the "Run the cypress test" step across each workflow. There are no deletions or modifications of existing steps; the change is solely additive to provide the necessary token value during Cypress test executions.

Changes

Files Change Summary
.github/workflows/ci-test-custom-script.yml, .github/workflows/ci-test-hosted.yml,
.github/workflows/ci-test-limited-with-count.yml, .github/workflows/ci-test-limited.yml
Added environment variable CYPRESS_HUBSPOT_TOKEN set to ${{ secrets.HUBSPOT_TOKEN }} in the "Run the cypress test" step.

Possibly related PRs

Suggested labels

skip-changelog, CI, ok-to-test

Suggested reviewers

  • sharat87
  • ApekshaBhosale
  • yatinappsmith

Poem

In the world of CI, a token takes flight,
CYPRESS_HUBSPOT_TOKEN joins the crew so bright.
Secrets unlocked with a line so neat,
Cypress tests now find their beat.
A small change that makes the code shine,
A festive tweak in our workflow line!
🚀✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b07bb97 and d4e4d31.

📒 Files selected for processing (4)
  • .github/workflows/ci-test-custom-script.yml (1 hunks)
  • .github/workflows/ci-test-hosted.yml (1 hunks)
  • .github/workflows/ci-test-limited-with-count.yml (1 hunks)
  • .github/workflows/ci-test-limited.yml (1 hunks)
🔇 Additional comments (4)
.github/workflows/ci-test-hosted.yml (1)

297-297: Addition of HubSpot Token Environment Variable

The new CYPRESS_HUBSPOT_TOKEN is added using the project’s established secret mechanism. This change is consistent with the other workflow files and ensures uniform access across test environments.

.github/workflows/ci-test-limited.yml (1)

250-250: Consistent Inclusion of HubSpot Token in Limited Tests Workflow

The environment variable CYPRESS_HUBSPOT_TOKEN is now defined and set to ${{ secrets.HUBSPOT_TOKEN }}. This addition aligns perfectly with the changes in other CI workflows, ensuring that the HubSpot token is available during Cypress test runs.

.github/workflows/ci-test-custom-script.yml (1)

372-372: Addition of HubSpot Token in Custom Script Workflow

The new CYPRESS_HUBSPOT_TOKEN is properly added in the environment settings for the Cypress test run. This update maintains consistency with the other workflow files and helps enable HubSpot token based automation during tests.

.github/workflows/ci-test-limited-with-count.yml (1)

428-428: HubSpot Token Environment Variable in Limited-With-Count Workflow

The CYPRESS_HUBSPOT_TOKEN is introduced successfully by mapping it to ${{ secrets.HUBSPOT_TOKEN }}. This inclusion is in line with recent updates in the other workflows, ensuring consistent availability of the HubSpot token across the CI pipelines.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@laveena-en laveena-en added the ok-to-test Required label for CI label Feb 21, 2025
@sagar-qa007 sagar-qa007 changed the title [chore]: updated the ci config files with the hubspot token chore: updated the ci config files with the hubspot token Feb 21, 2025
@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Feb 21, 2025
@laveena-en laveena-en removed the request for review from sharat87 February 21, 2025 05:04
@laveena-en laveena-en merged commit 2b43c05 into release Feb 21, 2025
51 checks passed
@laveena-en laveena-en deleted the updateConfig branch February 21, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants