fix: cypress test for multipart/form-data

[NilanshBansal]

Description

This PR fixes the cypress test for API multipart/form-data when the FilePicker is selected as Base64

We have updated the cypress test to use {{FilePicker1.files[0].data}} instead of {{FilePicker1.files[0]}}, this is because for base64 type file picker we have to use .data property to make the file upload work successfully.
Earlier, while the cypress test was passing with {{FilePicker1.files[0]}} but the uploaded image was corrupted (please check the screen recording below).

Invalid.usage.of.base64.mov

Fixes #39354

Automation

/ok-to-test tags="@tag.Datasource"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13408509228
Commit: 7b2360f
Cypress dashboard.
Tags: @tag.Datasource
Spec:

---

Wed, 19 Feb 2025 09:28:34 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Tests
  • Updated file upload tests to properly validate file data extraction.
  • Added a test scenario for adding new pages to enhance page management verification.
  • Revised page selection during tests for more accurate validation outcomes.

[coderabbitai]

Walkthrough

This pull request updates the Cypress API test for multipart form data handling. The test now retrieves the data property from the first file of the FilePicker widget instead of the whole file object, aligning the test with the updated file data structure for multipart submissions. Additionally, a new page management function has been introduced, and the entity selection has been updated. No other functional or control flow changes have been made.

Changes

File	Change Summary
app/client/cypress/e2e/Regression/.../API_MultiPart_Spec.ts	Added import for PageList, modified file upload test to access data property, introduced new page addition, and updated entity selection from Page1 to Page2.

Possibly related PRs

• test: adding test for page functionality #38538: Related to modifications in the API test suite for multipart form data handling and page management functionality.
• chore: fixes mergeviaremote_spec flakiness #38635: Directly related to the addition of PageList.AddNewPage(), focusing on page management within the test suites.
• fix: file upload fixed when using Base64 type in FilePicker and multipart/form-data in REST API #39332: Enhances the processing of multipart form data and base64 content in the backend, relevant to file upload functionality.

Suggested labels

Test

Suggested reviewers

• ApekshaBhosale
• NandanAnantharamu
• sagar-qa007

Poem

A tweak so small, yet neat and clear,
The file's data now appears with cheer!
In tests it flows with precise art,
Empowering uploads right from the start.
Code dances on—a joyful part!

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bdb3b22 and 7b2360f.

📒 Files selected for processing (1)

• app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_MultiPart_Spec.ts (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_MultiPart_Spec.ts

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: perform-test / client-build / client-build
• GitHub Check: perform-test / rts-build / build
• GitHub Check: perform-test / server-build / server-unit-tests
• GitHub Check: client-lint / client-lint
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-build / client-build
• GitHub Check: client-prettier / prettier-check

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[NilanshBansal]

/build-deploy-preview skip-tests=true

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13407909149.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 39356.
recreate: .

[github-actions]

Deploy-Preview-URL: https://ce-39356.dp.appsmith.com