Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Scheduling the heavy database ops on bounded elastic thread pool for Ms-sql #39176

Merged
merged 2 commits into from
Feb 11, 2025
Merged

fix: Scheduling the heavy database ops on bounded elastic thread pool for Ms-sql #39176

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da66b85
fix: Scheduling the heavy database ops on bounded elastic thread pool…
trishaanand Feb 11, 2025
3e758fb
Incorporated review comment
trishaanand Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions app/server/appsmith-plugins/mssqlPlugin/src/main/java/com/external/plugins/MssqlPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,15 +363,14 @@ private Set<String> populateHintMessages(List<String> columnNames) {
@Override
public Mono<HikariDataSource> datasourceCreate(DatasourceConfiguration datasourceConfiguration) {
log.debug(Thread.currentThread().getName() + ": datasourceCreate() called for MSSQL plugin.");
return connectionPoolConfig
.getMaxConnectionPoolSize()
.flatMap(maxPoolSize -> {
return Mono.defer(
() -> connectionPoolConfig.getMaxConnectionPoolSize().flatMap(maxPoolSize -> {
return Mono.fromCallable(() -> {
log.debug(Thread.currentThread().getName() + ": Connecting to SQL Server db");
return createConnectionPool(datasourceConfiguration, maxPoolSize);
});
})
.subscribeOn(scheduler);
log.debug(Thread.currentThread().getName() + ": Connecting to SQL Server db");
return createConnectionPool(datasourceConfiguration, maxPoolSize);
})
.subscribeOn(scheduler);
}));
}

@Override
Expand Down