chore: fix select mode

[jsartisan]

/ok-to-test tags="@tag.Sanity"

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13177801620
Commit: 08be940
Cypress dashboard.
Tags: @tag.Sanity
Spec:

---

Thu, 06 Feb 2025 12:10:29 UTC

Summary by CodeRabbit

• Bug Fixes
  • Updated the multi-selection dropdown behavior so that when multiple items are selected, they are displayed more clearly and managed more intuitively.
  • This change enhances the user experience by ensuring that dropdown selections are presented in a way that better aligns with user expectations.

[coderabbitai]

Walkthrough

The pull request modifies the multi-select behavior in the design system's select component. Specifically, it changes the mode property of the RCSelect component from "tags" to "multiple" when isMultiSelect is true. This adjustment affects how multiple selections are displayed and handled without altering any public API declarations.

Changes

File	Summary
app/client/.../Select/Select.tsx	Updated the RCSelect mode from "tags" to "multiple" for multi-select implementation.

Suggested reviewers

• KelvinOm
• riodeuno

Poem

In the code where selections gleam,
A tiny change now starts to beam.
"Tags" gives way to "multiple" style,
Making multi-select walk the extra mile.
Happy coding with a gentle smile!
🚀✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8ebe577 and 08be940.

📒 Files selected for processing (1)

• app/client/packages/design-system/ads/src/Select/Select.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (10)

• GitHub Check: perform-test / rts-build / build
• GitHub Check: perform-test / client-build / client-build
• GitHub Check: perform-test / server-build / server-unit-tests
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-lint / client-lint
• GitHub Check: client-prettier / prettier-check
• GitHub Check: client-build / client-build
• GitHub Check: storybook-tests
• GitHub Check: chromatic-deployment
• GitHub Check: chromatic-deployment

🔇 Additional comments (3)

app/client/packages/design-system/ads/src/Select/Select.tsx (3)

111-111: LGTM! The mode change improves select behavior.

Changing from "tags" to "multiple" mode ensures users can only select from predefined options, which is the expected behavior for most enterprise select components.

---

17-23: Track and address the TODO items.

The component has several pending improvements that should be tracked:

• Fix component warnings
• Handle long option text overflow
• Fix click handling when dropdown is open

Would you like me to create separate issues to track these improvements?

---

1-5: Verify rc-select version compatibility.

Let's ensure we're using a compatible version of rc-select that supports the "multiple" mode.

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Check package.json for rc-select version
fd --type f package.json | xargs cat | jq '.dependencies["rc-select"] // .devDependencies["rc-select"]'

Length of output: 190

---

RC-Select Version Verified – Compatible with "multiple" Mode

We checked the package.json files and confirmed that the ads package uses a compatible rc-select version (e.g. "^14.4.3") that supports multiple mode.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.