fix: Release blocker: focus ring issue in code mirror #39022

albinAppsmith · 2025-02-05T05:25:33Z

Description

Fixed focus ring overlapping issue for code mirror is addressed in this PR.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13153839322
Commit: f9140c9
Cypress dashboard.
Tags: @tag.All
Spec:

Wed, 05 Feb 2025 10:57:23 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

Style
- Standardized the focus outline styling in the editor component to improve visual consistency when the editor is focused.

coderabbitai · 2025-02-05T05:25:41Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

app/client/cypress/snapshots/Regression/ClientSide/VisualTests/JSEditorIndent_spec.js/formattedJSONBodyAfterSave.snap.png is excluded by !**/*.png

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request updates the focus outline styling in the CodeEditor component by changing the outline-offset value from var(--ads-v2-offset-outline) to -1px in multiple selectors. The change affects both the .CodeMirror-focused and &:focus-visible selectors for the .CodeMirror.cm-s-duotone-light class, while keeping the existing border logic in the EditorWrapper constant. No public API or exported entities have been altered.

Changes

File(s)	Change Summary
app/client/src/components/editorComponents/CodeEditor/styledComponents.ts	Updated `outline-offset` to `-1px` in `.CodeMirror-focused` and `&:focus-visible` selectors; retained the existing border logic in `EditorWrapper`.

Assessment against linked issues

Objective	Addressed	Explanation
Fix focus ring rendering issues (#39002)	✅

Possibly related PRs

Revert "feat: Added focus ring for focus visible (#37700)" #38650: Involves similar focus style adjustments for focus outlines in different components.
feat: Added focus ring for focus visible #37700: Addresses modifications to the outline-offset in focus-related classes that share similarities with this update.

Suggested labels

High, Production, QA

Suggested reviewers

hetunandu
ankitakinger

Poem

In the realm of code so fine,
A tiny tweak makes focus shine.
Outlines shift just one pixel left,
Ensuring views are right and deft.
Cheers to changes clear and neat,
Where style and function smoothly meet!
🎉 Happy coding!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

app/client/src/components/editorComponents/CodeEditor/styledComponents.ts (1)

108-117: Remove commented code block.

The commented code block is no longer needed since the focus ring styling is now handled by the active implementation.

-      /* ${(props) =>
-        props.isFocused &&
-        `outline: ${
-          props?.removeHoverAndFocusStyle
-            ? "none"
-            : "var(--ads-v2-border-width-outline) solid var(--ads-v2-color-outline)"
-        };
-        outline-offset: -1px;
-        clip-path: unset !important;
-        `} */

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1de2408 and ff8329c.

📒 Files selected for processing (1)

app/client/src/components/editorComponents/CodeEditor/styledComponents.ts (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (7)

GitHub Check: perform-test / rts-build / build
GitHub Check: perform-test / server-build / server-unit-tests
GitHub Check: client-lint / client-lint
GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
GitHub Check: client-build / client-build
GitHub Check: client-unit-tests / client-unit-tests
GitHub Check: client-prettier / prettier-check

🔇 Additional comments (2)

app/client/src/components/editorComponents/CodeEditor/styledComponents.ts (2)

93-93: LGTM! Fixed focus ring overlapping.

The change from var(--ads-v2-offset-outline) to -1px resolves the focus ring issue.

409-409: LGTM! Consistent focus ring styling.

The outline-offset change maintains consistency with other focus states.

albinAppsmith · 2025-02-05T05:29:57Z

/build-deploy-preview skip-test=true

github-actions · 2025-02-05T05:30:17Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13150896878.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 39022.
recreate: .

github-actions · 2025-02-05T05:42:39Z

Deploy-Preview-URL: https://ce-39022.dp.appsmith.com

albinAppsmith · 2025-02-05T05:56:26Z

/build-deploy-preview skip-test=true

github-actions · 2025-02-05T05:56:46Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13151173745.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 39022.
recreate: .

github-actions · 2025-02-05T06:09:27Z

Deploy-Preview-URL: https://ce-39022.dp.appsmith.com

…e-blocker/focus-ring

## Description Fixed focus ring overlapping issue for code mirror is addressed in this PR. Fixes #39002 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13153839322> > Commit: f9140c9 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13153839322&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 05 Feb 2025 10:57:23 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **Style** - Standardized the focus outline styling in the editor component to improve visual consistency when the editor is focused.  (cherry picked from commit 108c797)

) ## Description Fixed focus ring overlapping issue for code mirror is addressed in this PR. Fixes appsmithorg#39002 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13153839322> > Commit: f9140c9 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13153839322&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 05 Feb 2025 10:57:23 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **Style** - Standardized the focus outline styling in the editor component to improve visual consistency when the editor is focused.

fix: Release blocker: focus ring issue in code mirror

ff8329c

albinAppsmith added the ok-to-test Required label for CI label Feb 5, 2025

albinAppsmith requested a review from KelvinOm February 5, 2025 05:26

coderabbitai bot reviewed Feb 5, 2025

View reviewed changes

fix: focus ring for js editor

0cd9387

KelvinOm previously approved these changes Feb 5, 2025

View reviewed changes

albinAppsmith added 2 commits February 5, 2025 14:27

Merge branch 'release' of github.com:appsmithorg/appsmith into releas…

ad1abb4

…e-blocker/focus-ring

fix: snapshot update

f9140c9

albinAppsmith dismissed KelvinOm’s stale review via f9140c9 February 5, 2025 09:07

albinAppsmith requested review from ApekshaBhosale and sagar-qa007 as code owners February 5, 2025 09:07

KelvinOm approved these changes Feb 5, 2025

View reviewed changes

albinAppsmith merged commit 108c797 into release Feb 5, 2025
83 checks passed

albinAppsmith deleted the release-blocker/focus-ring branch February 5, 2025 11:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Release blocker: focus ring issue in code mirror #39022

fix: Release blocker: focus ring issue in code mirror #39022

albinAppsmith commented Feb 5, 2025 •

edited by github-actions bot

Loading

coderabbitai bot commented Feb 5, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

coderabbitai bot left a comment

albinAppsmith commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

albinAppsmith commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

fix: Release blocker: focus ring issue in code mirror #39022

fix: Release blocker: focus ring issue in code mirror #39022

Conversation

albinAppsmith commented Feb 5, 2025 • edited by github-actions bot Loading

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

coderabbitai bot commented Feb 5, 2025 • edited Loading

Review skipped

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

albinAppsmith commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

albinAppsmith commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

albinAppsmith commented Feb 5, 2025 •

edited by github-actions bot

Loading

coderabbitai bot commented Feb 5, 2025 •

edited

Loading