Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ads slider export #39007

Merged
merged 2 commits into from
Feb 4, 2025
Merged

fix: ads slider export #39007

merged 2 commits into from
Feb 4, 2025

Conversation

KelvinOm
Copy link
Collaborator

@KelvinOm KelvinOm commented Feb 4, 2025

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features

    • Introduced a new slider component to the design system, expanding the range of interactive UI elements available.
  • Chores

    • Enhanced the Storybook configuration to streamline dependency management, contributing to a smoother development workflow.

@KelvinOm KelvinOm requested a review from jsartisan February 4, 2025 09:01
@KelvinOm KelvinOm requested a review from a team as a code owner February 4, 2025 09:01
Copy link
Contributor

coderabbitai bot commented Feb 4, 2025

Walkthrough

The pull request introduces two separate modifications. A new export statement has been added to include the Slider component in the design system module. Additionally, a change in the Storybook Vite configuration adds an optimizeDeps option to exclude the @storybook/components package from dependency optimization. These changes update module exports and build configuration without modifying existing runtime control flows.

Changes

File(s) Change Summary
.../design-system/ads/src/index.ts Added new export: export * from "./Slider"; to expose the Slider component.
.../storybook/vite.config.js Updated Vite config by adding optimizeDeps: { exclude: ["@storybook/components"] } to the configuration.

Suggested labels

Bug, ok-to-test

Suggested reviewers

  • ayushpahwa
  • ApekshaBhosale
  • sagar-qa007
  • albinAppsmith

Poem

In our repo a spark takes flight,
Exports extend in brilliant light,
A Slider now joins the fray,
Config tweaks clear the way,
Code shimmers in pure delight!
🚀✨

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d9ea6dd and 5ce027e.

📒 Files selected for processing (2)
  • app/client/packages/design-system/ads/src/index.ts (1 hunks)
  • app/client/packages/storybook/vite.config.js (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-lint / client-lint
  • GitHub Check: client-build / client-build
  • GitHub Check: client-prettier / prettier-check
  • GitHub Check: chromatic-deployment
  • GitHub Check: chromatic-deployment
  • GitHub Check: storybook-tests
🔇 Additional comments (2)
app/client/packages/storybook/vite.config.js (1)

32-34: Verify the necessity of excluding @storybook/components.

While excluding packages from optimization is a valid approach, please confirm if this exclusion is specifically required for the Slider component integration.

app/client/packages/design-system/ads/src/index.ts (1)

31-31: LGTM! Verify Slider component implementation.

The export follows the established pattern and maintains alphabetical ordering.

✅ Verification successful

Slider component verified.
The file app/client/packages/design-system/ads/src/Slider/Slider.tsx exists, confirming the export is valid and aligns with the established pattern.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify the Slider component exists and is implemented
fd -t f "Slider.(ts|tsx)" "app/client/packages/design-system/ads/src"

Length of output: 129

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Bug Something isn't working label Feb 4, 2025
@@ -29,4 +29,7 @@ export default defineConfig({
],
},
},
optimizeDeps: {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storybrook wasn't build sometimes because of this error.

Снимок экрана 2025-02-04 в 11 32 59

@KelvinOm KelvinOm merged commit 3c7f357 into release Feb 4, 2025
25 checks passed
@KelvinOm KelvinOm deleted the fix/ads-slider-export branch February 4, 2025 09:54
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Feb 7, 2025
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a new slider component to the design system, expanding the
range of interactive UI elements available.

- **Chores**
- Enhanced the Storybook configuration to streamline dependency
management, contributing to a smoother development workflow.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants