chore: added buckets for 2s, 5s, 10s and 20s to be measured on grafana

[ApekshaBhosale]

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13048938488
Commit: d03b480
Cypress dashboard.
Tags: @tag.All
Spec:

---

Thu, 30 Jan 2025 10:24:53 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Chores
  • Enhanced HTTP server request metrics configuration with more granular size thresholds for improved performance monitoring.

[coderabbitai]

Walkthrough

The pull request modifies the HTTP server request metrics configuration in the application.properties file. The change expands the existing service-level objective (SLO) thresholds for HTTP server requests by adding more granular measurement points. This update allows for more detailed performance monitoring by introducing additional request size measurement intervals.

Changes

File	Change Summary
app/server/appsmith-server/src/main/resources/application.properties	Updated management.metrics.distribution.slo.http.server.requests metric thresholds from 100,200,500,1000,30000 to 100,200,500,1000,2000,5000,10000,20000,30000

Possibly related PRs

• chore: added slo buckets for histogram #37797: Modification of the same management.metrics.distribution.slo.http.server.requests property in the application.properties file

Suggested Labels

skip-changelog

Suggested Reviewers

• nidhi-nair

Poem

Metrics dance, thresholds grow wide
Numbers expand, performance takes stride
From hundreds to thousands, we measure with care
Monitoring magic beyond compare! 📊✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 213db55 and d03b480.

📒 Files selected for processing (1)

• app/server/appsmith-server/src/main/resources/application.properties (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: perform-test / rts-build / build
• GitHub Check: perform-test / client-build / client-build
• GitHub Check: perform-test / server-build / server-unit-tests
• GitHub Check: server-unit-tests / server-unit-tests
• GitHub Check: server-spotless / spotless-check

🔇 Additional comments (1)

app/server/appsmith-server/src/main/resources/application.properties (1)

98-98: LGTM! Verify Grafana dashboard updates.

The bucket configuration is well-structured with proper millisecond intervals. The additional granularity will help in better latency monitoring.

Please ensure the Grafana dashboards are updated to utilize these new buckets. Run this script to check for any existing dashboard configurations that might need updates:

✅ Verification successful

No Grafana dashboard updates needed ✓

The new SLO buckets will be automatically discovered by Prometheus and available in Grafana when metrics collection is enabled. The changes are backward compatible with existing monitoring setup.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for Grafana dashboard configurations that might need updates
# Look for dashboard JSON files and histogram/heatmap configurations

fd -e json -e jsonnet . | xargs rg -l 'http_server_requests_seconds_bucket'

Length of output: 75

---

Script:

#!/bin/bash
# Search for monitoring-related files and configurations
echo "=== Searching for monitoring setup files ==="
fd -e md -e txt . | xargs rg -l -i "grafana|prometheus|metrics|monitoring" || true

echo -e "\n=== Searching for metric configurations ==="
rg -l -i "management\.metrics|micrometer|prometheus" || true

echo -e "\n=== Searching for alternative metric names ==="
rg -l "server\.requests|http.*requests.*bucket" || true

Length of output: 9144

---

Script:

#!/bin/bash
echo "=== Checking Helm metrics configuration ==="
cat deploy/helm/templates/service-metrics.yaml || true

echo -e "\n=== Checking Helm values for monitoring configuration ==="
cat deploy/helm/values.yaml | rg -A 5 -B 5 "metrics|monitoring|prometheus" || true

Length of output: 1810

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.