chore: Fix mockdb query #38861

sagar-qa007 · 2025-01-28T07:54:26Z

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13009862238
Commit: c73af45
Cypress dashboard.
Tags: @tag.IDE
Spec:

Tue, 28 Jan 2025 12:27:20 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

Tests
- Updated query in the collapsible bottom bar test to order results by email instead of username.
- Enhanced the cleanup process reliability by updating datasource retrieval method in the test case.

coderabbitai · 2025-01-28T07:54:35Z

Walkthrough

The pull request modifies the EntityBottomBar_spec.ts Cypress test file by changing the SQL query in the 5. Query bottom bar should be collapsable test case from ordering by username to ordering by email. Additionally, the cleanup process at the end of the test case has been updated to utilize a Cypress alias for retrieving the datasource name, improving the reliability of the cleanup operation. The overall structure and logic of the test cases remain unchanged.

Changes

File	Change Summary
`app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/EntityBottomBar_spec.ts`	- Modified SQL query in test case to order by `email` instead of `username`. - Updated cleanup process to use `cy.get("@dsName")` for retrieving datasource name.

Suggested labels

skip-changelog, ok-to-test, Test

Suggested reviewers

ApekshaBhosale
yatinappsmith

Possibly related PRs

test: fixed failing EntityBottomBar spec #38006: This PR modifies the same test case in the EntityBottomBar_spec.ts file, specifically updating the SQL query string in the "5. Query bottom bar should be collapsable" test case, which is directly related to the changes made in the main PR.

Poem

🧪 A test spec's subtle dance,
A query shifts, a new romance,
Emails now in order's grace,
Cleanup whispers, finds its place,
Cypress flows with testing cheer,
Code refined, the goal is clear! 🔍

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between be32ad5 and c73af45.

📒 Files selected for processing (1)

app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/EntityBottomBar_spec.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/EntityBottomBar_spec.ts

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: client-unit-tests / client-unit-tests
GitHub Check: client-build / client-build
GitHub Check: client-lint / client-lint
GitHub Check: client-prettier / prettier-check

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sagar-qa007 · 2025-01-28T07:55:08Z

/ci-test-limit-count run_count=1 update_snapshot=false specs_to_run=cypress/e2e/Regression/ClientSide/OtherUIFeatures/EntityBottomBar_spec.ts

github-actions · 2025-01-28T07:55:37Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/13005920052.
Cypress dashboard
PR: #38861 .

github-actions · 2025-01-28T08:15:48Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13005920052.
Cypress dashboard url: Click here!
All Cypress tests have passed 🎉🎉🎉

***** Repeat Run Summary ***** Total Tests with repeat: 5 Total Passed: 4 Total Failed: 1 Total Skipped: 0 *****************************

sagar-qa007 · 2025-01-28T11:08:59Z

/ci-test-limit-count run_count=10 update_snapshot=false specs_to_run=cypress/e2e/Regression/ClientSide/OtherUIFeatures/EntityBottomBar_spec.ts runId=13005920052

github-actions · 2025-01-28T11:09:33Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/13009126446.
Cypress dashboard
PR: #38861 .

github-actions · 2025-01-28T11:31:32Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13009126446.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:
To know the list of identified flaky tests - Refer here

***** Repeat Run Summary ***** Total Tests with repeat: 50 Total Passed: 50 Total Failed: 0 Total Skipped: 0 *****************************

## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13009862238> > Commit: c73af45 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13009862238&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` > Spec: > <hr>Tue, 28 Jan 2025 12:27:20 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **Tests** - Updated query in the collapsible bottom bar test to order results by email instead of username. - Enhanced the cleanup process reliability by updating datasource retrieval method in the test case.

Checking failure

be32ad5

sagar-qa007 requested a review from ApekshaBhosale as a code owner January 28, 2025 07:54

Query update

c73af45

sagar-qa007 changed the title ~~DNM: Checking failure~~ chore: Fix mockdb query Jan 28, 2025

github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jan 28, 2025

sagar-qa007 added the ok-to-test Required label for CI label Jan 28, 2025

sagar-qa007 requested a review from yatinappsmith January 28, 2025 13:45

yatinappsmith approved these changes Jan 28, 2025

View reviewed changes

yatinappsmith merged commit b62c875 into release Jan 28, 2025
54 checks passed

yatinappsmith deleted the fix/EntityBottomBarSpec branch January 28, 2025 14:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Fix mockdb query #38861

chore: Fix mockdb query #38861

sagar-qa007 commented Jan 28, 2025 •

edited by github-actions bot

Loading

coderabbitai bot commented Jan 28, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

sagar-qa007 commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

sagar-qa007 commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

chore: Fix mockdb query #38861

chore: Fix mockdb query #38861

Conversation

sagar-qa007 commented Jan 28, 2025 • edited by github-actions bot Loading

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

coderabbitai bot commented Jan 28, 2025 • edited Loading

Walkthrough

Changes

Suggested labels

Suggested reviewers

Possibly related PRs

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

sagar-qa007 commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

sagar-qa007 commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

sagar-qa007 commented Jan 28, 2025 •

edited by github-actions bot

Loading

coderabbitai bot commented Jan 28, 2025 •

edited

Loading