Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: git mod - minor fixes #38634

Merged
merged 5 commits into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export default function TabMergeView({

let status = MergeStatusState.NONE;

if (isFetchStatusLoading) {
if (isFetchStatusLoading || isFetchBranchesLoading) {
status = MergeStatusState.FETCHING;
message = createMessage(FETCH_GIT_STATUS);
} else if (!isStatusClean) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ describe("QuickActionsView Component", () => {
isDiscardLoading: false,
isFetchStatusLoading: false,
isConnected: false,
isInitialized: true,
isProtectedMode: false,
isPullFailing: false,
isPullLoading: false,
Expand All @@ -48,6 +49,24 @@ describe("QuickActionsView Component", () => {
jest.clearAllMocks();
});

it("should not render QuickActionsView when isInitialized is false", () => {
const props = {
...defaultProps,
isInitialized: false,
};

render(
<ThemeProvider theme={theme}>
<QuickActionsView {...props} />
</ThemeProvider>,
);

expect(screen.queryByTestId("connect-button")).not.toBeInTheDocument();
expect(
screen.queryByTestId("t--git-quick-actions-commit"),
).not.toBeInTheDocument();
});

it("should render ConnectButton when isConnected is false", () => {
render(
<ThemeProvider theme={theme}>
Expand Down
14 changes: 12 additions & 2 deletions app/client/src/git/components/QuickActions/QuickActionsView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React, { useCallback } from "react";
import styled from "styled-components";

import {
AUTOCOMMIT_IN_PROGRESS_MESSAGE,
COMMIT_CHANGES,
createMessage,
GIT_SETTINGS,
Expand All @@ -13,7 +14,7 @@ import { GitOpsTab } from "../../constants/enums";
import { GitSettingsTab } from "../../constants/enums";
import ConnectButton from "./ConnectButton";
import QuickActionButton from "./QuickActionButton";
import AutocommitStatusbar from "../Statusbar";
import Statusbar from "../Statusbar";
import getPullBtnStatus from "./helpers/getPullButtonStatus";
import noop from "lodash/noop";
import BranchButton from "./BranchButton";
Expand All @@ -33,6 +34,7 @@ interface QuickActionsViewProps {
isConnectPermitted: boolean;
isDiscardLoading: boolean;
isFetchStatusLoading: boolean;
isInitialized: boolean;
isConnected: boolean;
isProtectedMode: boolean;
isPullFailing: boolean;
Expand Down Expand Up @@ -61,6 +63,7 @@ function QuickActionsView({
isConnectPermitted = false,
isDiscardLoading = false,
isFetchStatusLoading = false,
isInitialized = false,
isProtectedMode = false,
isPullFailing = false,
isPullLoading = false,
Expand Down Expand Up @@ -131,6 +134,10 @@ function QuickActionsView({
toggleConnectModal(true);
}, [toggleConnectModal]);

if (!isInitialized) {
return null;
}

return isConnected ? (
<Container>
<BranchButton
Expand All @@ -145,7 +152,10 @@ function QuickActionsView({

{isAutocommitEnabled && isAutocommitPolling ? (
<div data-testid="t--git-autocommit-loader">
<AutocommitStatusbar completed={!isAutocommitPolling} />
<Statusbar
completed={!isAutocommitPolling}
message={createMessage(AUTOCOMMIT_IN_PROGRESS_MESSAGE)}
/>
</div>
) : (
<>
Expand Down
3 changes: 3 additions & 0 deletions app/client/src/git/components/QuickActions/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import useOps from "git/hooks/useOps";
import useBranches from "git/hooks/useBranches";
import useConnected from "git/hooks/useConnected";
import useProtectedMode from "git/hooks/useProtectedMode";
import useInit from "git/hooks/useInit";

function QuickActions() {
const isConnected = useConnected();
Expand All @@ -29,6 +30,7 @@ function QuickActions() {
const { toggleSettingsModal } = useSettings();
const { toggleConnectModal } = useConnect();
const { currentBranch, isBranchPopupOpen, toggleBranchPopup } = useBranches();
const { isInitialized } = useInit();

const isPullFailing = !!pullError;
const isStatusClean = status?.isClean ?? true;
Expand All @@ -46,6 +48,7 @@ function QuickActions() {
isConnected={isConnected}
isDiscardLoading={isDiscardLoading}
isFetchStatusLoading={isFetchStatusLoading}
isInitialized={isInitialized}
isProtectedMode={isProtectedMode}
isPullFailing={isPullFailing}
isPullLoading={isPullLoading}
Expand Down
16 changes: 16 additions & 0 deletions app/client/src/git/hooks/useInit.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import {
selectInitialized,
selectInitializing,
} from "git/store/selectors/gitArtifactSelectors";
import useArtifactSelector from "./useArtifactSelector";

export default function useInit() {
const initializing = useArtifactSelector(selectInitializing);

const initialized = useArtifactSelector(selectInitialized);

return {
isInitializing: initializing ?? false,
isInitialized: initialized ?? false,
};
}
2 changes: 2 additions & 0 deletions app/client/src/git/sagas/initGitSaga.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,6 @@ export default function* initGitForEditorSaga(
);
}
}

yield put(gitArtifactActions.initGitForEditorSuccess({ artifactDef }));
}
10 changes: 10 additions & 0 deletions app/client/src/git/store/actions/initGitActions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,15 @@ export interface InitGitForEditorPayload {

export const initGitForEditorAction =
createArtifactAction<InitGitForEditorPayload>((state) => {
state.ui.initializing = true;
state.ui.initialized = false;

return state;
});

export const initGitForEditorSuccessAction = createArtifactAction((state) => {
state.ui.initializing = false;
state.ui.initialized = true;

return state;
});
6 changes: 5 additions & 1 deletion app/client/src/git/store/gitArtifactSlice.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,10 @@ import {
updateProtectedBranchesInitAction,
updateProtectedBranchesSuccessAction,
} from "./actions/updateProtectedBranchesActions";
import { initGitForEditorAction } from "./actions/initGitActions";
import {
initGitForEditorAction,
initGitForEditorSuccessAction,
} from "./actions/initGitActions";
import {
fetchAutocommitProgressErrorAction,
fetchAutocommitProgressInitAction,
Expand Down Expand Up @@ -142,6 +145,7 @@ export const gitArtifactSlice = createSlice({
reducers: {
// init
initGitForEditor: initGitForEditorAction,
initGitForEditorSuccess: initGitForEditorSuccessAction,
mount: mountAction,
unmount: unmountAction,
fetchMetadataInit: fetchMetadataInitAction,
Expand Down
2 changes: 2 additions & 0 deletions app/client/src/git/store/helpers/initialState.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import type {
} from "../types";

const gitArtifactInitialUIState: GitArtifactUIReduxState = {
initializing: false,
initialized: false,
connectModalOpen: false,
connectSuccessModalOpen: false,
disconnectBaseArtifactId: null,
Expand Down
11 changes: 11 additions & 0 deletions app/client/src/git/store/selectors/gitArtifactSelectors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,17 @@ export const selectGitArtifact = (
];
};

// init
export const selectInitializing = (
state: GitRootState,
artifactDef: GitArtifactDef,
) => selectGitArtifact(state, artifactDef)?.ui?.initializing ?? false;

export const selectInitialized = (
state: GitRootState,
artifactDef: GitArtifactDef,
) => selectGitArtifact(state, artifactDef)?.ui?.initialized ?? false;

// metadata
export const selectMetadataState = (
state: GitRootState,
Expand Down
2 changes: 2 additions & 0 deletions app/client/src/git/store/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ export interface GitArtifactAPIResponsesReduxState

export interface GitArtifactUIReduxState
extends GitArtifactUIReduxStateExtended {
initializing: boolean;
initialized: boolean;
connectModalOpen: boolean;
connectSuccessModalOpen: boolean;
disconnectBaseArtifactId: string | null;
Expand Down
Loading