-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use zone as form #38550
chore: Use zone as form #38550
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export type DerivedPropertiesMap = Record<string, string>; |
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -27,6 +27,16 @@ export const propertyPaneContent = [ | |||||||||||||||||||||||||||||||||||||||||
{ | ||||||||||||||||||||||||||||||||||||||||||
sectionName: "General", | ||||||||||||||||||||||||||||||||||||||||||
children: [ | ||||||||||||||||||||||||||||||||||||||||||
{ | ||||||||||||||||||||||||||||||||||||||||||
propertyName: "useAsForm", | ||||||||||||||||||||||||||||||||||||||||||
label: "Use as a form", | ||||||||||||||||||||||||||||||||||||||||||
helpText: "Controls the visibility of the widget", | ||||||||||||||||||||||||||||||||||||||||||
controlType: "SWITCH", | ||||||||||||||||||||||||||||||||||||||||||
isJSConvertible: true, | ||||||||||||||||||||||||||||||||||||||||||
isBindProperty: true, | ||||||||||||||||||||||||||||||||||||||||||
isTriggerProperty: false, | ||||||||||||||||||||||||||||||||||||||||||
validation: { type: ValidationTypes.BOOLEAN }, | ||||||||||||||||||||||||||||||||||||||||||
}, | ||||||||||||||||||||||||||||||||||||||||||
Comment on lines
+30
to
+39
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix incorrect helpText for useAsForm property. The helpText "Controls the visibility of the widget" is incorrect for the - helpText: "Controls the visibility of the widget",
+ helpText: "Enables form functionality for this zone widget", 📝 Committable suggestion
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||
{ | ||||||||||||||||||||||||||||||||||||||||||
helpText: "Controls the visibility of the widget", | ||||||||||||||||||||||||||||||||||||||||||
propertyName: "isVisible", | ||||||||||||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Remove redundant type declaration.
The
WidgetDerivedPropertyType
is declared asany
with a TODO comment. SinceDerivedPropertiesMap
is now properly typed asRecord<string, string>
, this type declaration appears to be redundant.Also applies to: 54-54