Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Added a new test case for 33601 #38234

Merged
merged 3 commits into from
Dec 19, 2024
Merged

test: Added a new test case for 33601 #38234

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f65437
Added a new test case
sagar-qa007 Dec 18, 2024
573e943
Minor update
sagar-qa007 Dec 18, 2024
ddb795c
fix for case flakyniess
sagar-qa007 Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions app/client/cypress/e2e/Regression/ClientSide/ActionExecution/Bug33601_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
import {
agHelper,
appSettings,
deployMode,
homePage,
locators,
} from "../../../../support/Objects/ObjectsCore";
import EditorNavigation, {
EntityType,
PageLeftPane,
} from "../../../../support/Pages/EditorNavigation";

describe(
"Bug:33601: resetWidget function causes the next async method to be undefined",
{ tags: ["@tag.JS"] },
() => {
it("1. Bug 33601", () => {
homePage.NavigateToHome();
homePage.ImportApp("resetWidgetBug33601.json");
EditorNavigation.SelectEntityByName("List1", EntityType.Widget);
PageLeftPane.expandCollapseItem("List1");
PageLeftPane.expandCollapseItem("Container1");
EditorNavigation.SelectEntityByName("Input1", EntityType.Widget);

agHelper.EnterInputText("Label", "Widget Input2");
EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
cy.get(locators._widgetInputSelector("inputwidgetv2"))
.first()
.invoke("attr", "value")
.should("contain", "Widget Input2");
agHelper
.GetAttribute(locators._imgWidgetInsideList, "src")
.then((labelValue) => {
expect(labelValue).not.to.contain("data:image/png;base64");
});

agHelper.ClickButton("Submit");
cy.get(locators._widgetInputSelector("inputwidgetv2"))
.first()
.invoke("attr", "value")
.should("be.empty");
agHelper
.GetAttribute(locators._imgWidgetInsideList, "src")
.then((labelValue) => {
expect(labelValue).to.contain("data:image/png;base64");
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Improve test reliability and maintainability

Several improvements needed to align with Cypress best practices:

  1. Extract repeated selectors into constants
  2. Use data-cy attributes instead of widget selectors
  3. Consider using cy.should() for assertions instead of then()
+const INPUT_SELECTOR = '[data-cy="input-widget-first"]';
+const IMG_SELECTOR = '[data-cy="list-img-widget"]';

-cy.get(locators._widgetInputSelector("inputwidgetv2"))
+cy.get(INPUT_SELECTOR)
   .first()
   .invoke("attr", "value")
   .should("contain", "Widget Input2");

-agHelper.GetAttribute(locators._imgWidgetInsideList, "src")
+cy.get(IMG_SELECTOR)
   .should("have.attr", "src")
   .and("not.contain", "data:image/png;base64");

Committable suggestion skipped: line range outside the PR's diff.


deployMode.DeployApp();
agHelper.AssertElementVisibility(appSettings.locators._header);
agHelper.EnterInputText("Label", "Widget Input2");
cy.get(locators._widgetInputSelector("inputwidgetv2"))
.first()
.invoke("attr", "value")
.should("contain", "Widget Input2");
agHelper
.GetAttribute(locators._imgWidgetInsideList, "src")
.then((labelValue) => {
expect(labelValue).not.to.contain("data:image/png;base64");
});
agHelper.ClickButton("Submit");
cy.get(locators._widgetInputSelector("inputwidgetv2"))
.first()
.invoke("attr", "value")
.should("be.empty");
agHelper
.GetAttribute(locators._imgWidgetInsideList, "src")
.then((labelValue) => {
expect(labelValue).to.contain("data:image/png;base64");
});
});
},
);
Loading
Loading