chore: remove the if condition as not supported in workflow file

[AnaghHegde]

Description

Remove the if condition in workflow as it is not supported

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12249995808
Commit: b8e6ff5
Cypress dashboard.
Tags: @tag.Sanity
Spec:

---

Tue, 10 Dec 2024 06:02:10 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features
  • Introduced manual triggering for CI tests with input options for pull request numbers and previous workflow run IDs.
• Improvements
  • Enhanced environment setup and caching mechanisms for Docker images.
  • Refined Cypress test setup for better dependency management and logging.
• Bug Fixes
  • Improved job conditions for running tests based on repository name and event types.

[coderabbitai]

Walkthrough

The pull request modifies the GitHub Actions workflow for Appsmith's CI to enable manual triggering and enhance the handling of service containers and caching mechanisms. Key updates include the addition of inputs for previous workflow run IDs, refined job conditions based on repository name and event types, and improved Docker image handling. The Cypress test setup has also been optimized, with better logging and artifact management for CI failures.

Changes

File

Change Summary

.github/workflows/ci-test-limited.yml

- Added manual triggering with workflow_dispatch and inputs for PR numbers and previous run IDs. - Updated job conditions for repository name and event types. - Enhanced service container configurations for Redis, Postgres, and MongoDB with conditional execution based on branch names. - Improved Docker image handling and caching mechanisms, including cache key generation and restoration logic. - Refined Cypress test setup with explicit cache restoration and dependency installation steps. - Expanded logging and artifact upload steps for comprehensive failure tracking.

Possibly related PRs

• chore: add postgres db during the startup conditionally #37605: Adds a PostgreSQL service conditionally in the CI workflow, relevant to service configuration updates.
• Fix: Fix for GHSL-2024-277 #36836: Modifies the CI workflow for better commit message handling and introduces a run_count parameter.
• chore: Adding new command for running test case #35419: Introduces a new command for running test cases, relating to the enhancements in the CI workflow.
• CI: Fixed the payload for TBD action #35121: Fixes the payload for a CI action, connected to updates in the CI workflow configuration.
• chore: Ability to run PR automations every time PR updates #35476: Enhances the workflow for running PR automations, relevant to updates on CI workflow conditions and triggers.
• CI : fix build cache #37712: Addresses build cache issues, connecting to improvements in caching mechanisms within the CI workflow.

Suggested labels

skip-changelog

Suggested reviewers

• sharat87
• yatinappsmith
• abhvsn

🎉 In the CI realm, changes unfold,
Manual triggers now, a sight to behold!
With Docker and services, all set to play,
Caching and logging, guiding the way.
Cypress tests refined, failures logged bright,
In the world of code, everything feels right! 🚀

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between fd9efb8 and b8e6ff5.

📒 Files selected for processing (1)

• .github/workflows/ci-test-limited.yml (0 hunks)

💤 Files with no reviewable changes (1)

• .github/workflows/ci-test-limited.yml

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[abhvsn]

@AnaghHegde I think you can conditionally start Postgres or Mongo within steps like we are doing in server-build.yml

appsmith/.github/workflows/server-build.yml

Line 169 in 49bed91

- name: Conditionally start PostgreSQL

@sagar-qa007 do we really need these services as fat container runs all the dependencies on it's own while running CI 🤔

[abhvsn]

Force merging to unblock for now.