-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: picking settingsConfig from ApiEditorContext instead of props #37758
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
060b4f5
fix: picking settingsConfig from ApiEditorContext instead of props
AmanAgarwal041 fa10866
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/37…
AmanAgarwal041 e09f273
fix: settingsConfig logging to debug
AmanAgarwal041 76f4cf1
fix: settingsConfig logging to debug
AmanAgarwal041 91523c7
fix: settingsConfig logging to debug
AmanAgarwal041 12a2736
fix: settingsConfig logging to debug
AmanAgarwal041 ea7f73b
fix: settingsConfig logging to debug
AmanAgarwal041 0b396fc
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/37…
AmanAgarwal041 c76282a
fix: settingsConfig logging to debug
AmanAgarwal041 f92b5a1
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/37…
AmanAgarwal041 233ffbe
fix: settingsConfig logging to debug
AmanAgarwal041 7df2dac
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/37…
AmanAgarwal041 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider improving type safety and logging implementation.
The current implementation has several areas for improvement:
@ts-expect-error
is not ideal for handling Cypress typesConsider these improvements: