Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: executing skipped tests on CE #36681

Closed
wants to merge 1 commit into from
Closed

test: executing skipped tests on CE #36681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../cypress/e2e/Regression/ClientSide/ActionExecution/ActionSelectorCreateShouldBind_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ describe(
"Creations via action selector should bind to the property",
{ tags: ["@tag.JS", "@tag.PropertyPane"] },
() => {
it.skip("binds newly created query / api to the button onClick", () => {
it("binds newly created query / api to the button onClick", () => {
entityExplorer.DragDropWidgetNVerify(draggableWidgets.BUTTON);
propPane.SelectPlatformFunction("onClick", "Execute a query");
// For some reason, showing the modal will hang up the cypress test while it works well in general
Expand Down
2 changes: 1 addition & 1 deletion app/client/cypress/e2e/Regression/ClientSide/Autocomplete/JS_AC2_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ describe("Autocomplete tests", { tags: ["@tag.JS"] }, () => {
});
});

it.skip("3. Bug #15429 Random keystrokes trigger autocomplete to show up", () => {
it("3. Bug #15429 Random keystrokes trigger autocomplete to show up", () => {
// create js object & assert no hints just show up
jsEditor.CreateJSObject(
`export default
Expand Down
8 changes: 4 additions & 4 deletions app/client/cypress/e2e/Regression/ClientSide/Binding/DatePicker_Text_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ describe(
_.agHelper.AddDsl("uiBindDsl");
});
// Skipping tests due to issue - https://www.notion.so/appsmith/f353d8c6bd664f79ad858a42010cdfc8?v=f04cde23f6424aeb9d5a6e389cd172bd&p=0717892d43684c40bae4e2c87b8308cb&pm=s
it.skip("1. DatePicker-Text, Validate selectedDate functionality", function () {
it("1. DatePicker-Text, Validate selectedDate functionality", function () {
/**
* Bind DatePicker1 to Text for "selectedDate"
*/
Expand Down Expand Up @@ -51,7 +51,7 @@ describe(
cy.get(commonlocators.backToEditor).click();
});

it.skip("2. DatePicker1-text: Change the date in DatePicker1 and Validate the same in text widget", function () {
it("2. DatePicker1-text: Change the date in DatePicker1 and Validate the same in text widget", function () {
cy.openPropertyPane("textwidget");

/**
Expand Down Expand Up @@ -89,7 +89,7 @@ describe(
});
});

it.skip("3. Validate the Date is not changed in DatePicker2", function () {
it("3. Validate the Date is not changed in DatePicker2", function () {
cy.log("dateDp2:" + dateDp2);
cy.get(formWidgetsPage.datepickerWidget + commonlocators.inputField)
.eq(1)
Expand Down Expand Up @@ -124,7 +124,7 @@ describe(
_.deployMode.NavigateBacktoEditor();
});

it.skip("5. Checks if on deselection of date triggers the onDateSelected action or not.", function () {
it("5. Checks if on deselection of date triggers the onDateSelected action or not.", function () {
/**
* bind datepicker to show a message "Hello" on date selected
*/
Expand Down
48 changes: 24 additions & 24 deletions app/client/cypress/e2e/Regression/ClientSide/Binding/SelectWidget_Spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,34 +46,34 @@ describe(
});
});

// //Till bug fixed
// it.skip("2. Validation of default displayed in Select widget based on row selected + Bug 12531", function () {
// table.SelectTableRow(1);
// agHelper.ReadSelectedDropDownValue().then(($selectedValue) => {
// expect($selectedValue).to.eq("#2");
// });
//Till bug fixed
it("2. Validation of default displayed in Select widget based on row selected + Bug 12531", function () {
table.SelectTableRow(1);
agHelper.ReadSelectedDropDownValue().then(($selectedValue) => {
expect($selectedValue).to.eq("#2");
});

// table.SelectTableRow(0);
// agHelper.ReadSelectedDropDownValue().then(($selectedValue) => {
// expect($selectedValue).to.eq("#1");
// });
table.SelectTableRow(0);
agHelper.ReadSelectedDropDownValue().then(($selectedValue) => {
expect($selectedValue).to.eq("#1");
});

// table.SelectTableRow(2);
// agHelper.ReadSelectedDropDownValue().then(($selectedValue) => {
// expect($selectedValue).to.eq("Select option");
// });
table.SelectTableRow(2);
agHelper.ReadSelectedDropDownValue().then(($selectedValue) => {
expect($selectedValue).to.eq("Select option");
});

// //Change select value now - failing here!
// agHelper.SelectDropDown("#1");
// agHelper.ReadSelectedDropDownValue().then(($selectedValue) => {
// expect($selectedValue).to.eq("#1");
// });
//Change select value now - failing here!
agHelper.SelectDropDown("#1");
agHelper.ReadSelectedDropDownValue().then(($selectedValue) => {
expect($selectedValue).to.eq("#1");
});

// table.SelectTableRow(2, 0, false); //Deselecting here!
// agHelper.ReadSelectedDropDownValue().then(($selectedValue) => {
// expect($selectedValue).to.eq("Select option");
// });
// });
table.SelectTableRow(2, 0, false); //Deselecting here!
agHelper.ReadSelectedDropDownValue().then(($selectedValue) => {
expect($selectedValue).to.eq("Select option");
});
});
Comment on lines +49 to +76
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Class, let's review this test case together!

Excellent work on re-enabling this important test case! It's like bringing a sleeping student back to life in our classroom. However, there are a few areas where we can make our test even better. Let's go through them:

  1. Use constants for expected values:
    Instead of using plain strings in our expect statements, let's create constants. This will make our test more maintainable and easier to read.
const SELECT_OPTION = "Select option";
const OPTION_1 = "#1";
const OPTION_2 = "#2";

// Then use these constants in your expect statements
expect($selectedValue).to.eq(SELECT_OPTION);
  1. Add more descriptive comments:
    Let's add some comments to explain what each step is doing. This will help future students (I mean, developers) understand our test better.
// Select row 1 and verify the dropdown value
table.SelectTableRow(1);
agHelper.ReadSelectedDropDownValue().then(($selectedValue) => {
  expect($selectedValue).to.eq(OPTION_2);
});
  1. Consider refactoring repetitive code:
    We're using the same pattern of selecting a row and checking the dropdown value multiple times. We could create a helper function to make our test more DRY (Don't Repeat Yourself).
function selectRowAndVerifyDropdown(rowIndex: number, expectedValue: string) {
  table.SelectTableRow(rowIndex);
  agHelper.ReadSelectedDropDownValue().then(($selectedValue) => {
    expect($selectedValue).to.eq(expectedValue);
  });
}

// Then use it like this:
selectRowAndVerifyDropdown(1, OPTION_2);
selectRowAndVerifyDropdown(0, OPTION_1);
selectRowAndVerifyDropdown(2, SELECT_OPTION);

These changes will make our test case cleaner, more readable, and easier to maintain. Remember, clean code is happy code!

Would you like me to provide a fully refactored version of this test case?


it("3. Verify Selecting the already selected row deselects it", () => {
table.SelectTableRow(0); //select here
Expand Down
2 changes: 1 addition & 1 deletion app/client/cypress/e2e/Regression/ClientSide/BugTests/DatasourceSchema_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ describe(
});

//This test is failing because of this bug #36348
it.skip("2. Verify if schema was fetched once #36348", () => {
it("2. Verify if schema was fetched once #36348", () => {
agHelper.RefreshPage();
EditorNavigation.SelectEntityByName(
dataSourceName,
Expand Down
4 changes: 2 additions & 2 deletions app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/GitSyncedApps_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ describe("Git sync apps", { tags: ["@tag.Git"] }, function () {
});

//Skipping these since these are causing chrome crash in CI, passes in electron.
it.skip("10. After merge back to master, verify page is deleted on master", () => {
it("10. After merge back to master, verify page is deleted on master", () => {
// verify Child_Page is not on master
cy.switchGitBranch(mainBranch);
assertHelper.AssertDocumentReady();
Expand All @@ -425,7 +425,7 @@ describe("Git sync apps", { tags: ["@tag.Git"] }, function () {
PageLeftPane.assertAbsence("Child_Page Copy");
});

it.skip("11. Import app from git and verify page order should not change", () => {
it("11. Import app from git and verify page order should not change", () => {
cy.get(homePageLocators.homeIcon).click();
agHelper.GetNClick(homePageLocators.createNew, 0);
cy.get(homePageLocators.workspaceImportAppOption).click({ force: true });
Expand Down
2 changes: 1 addition & 1 deletion app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ describe("Git sync:", { tags: ["@tag.Git", "@tag.Sanity"] }, function () {
});

//Rename - hence skipping for Gitea
it.skip("5. test sync and prune branches", () => {
it("5. test sync and prune branches", () => {
// uncomment once prune branch flow is complete
let tempBranch = "featureA";
const tempBranchRenamed = "newFeatureA";
Expand Down
2 changes: 1 addition & 1 deletion app/client/cypress/e2e/Regression/ClientSide/Widgets/Datepicker/DatePicker2_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ describe(

// ADS changes to date input property causes this test to fail
// skipping it temporarily.
it.skip("DatePicker-Date Name validation", function () {
it("DatePicker-Date Name validation", function () {
// changing the date to today
cy.get(formWidgetsPage.defaultDate).click();
cy.SetDateToToday();
Expand Down
4 changes: 2 additions & 2 deletions ...lient/cypress/e2e/Regression/ClientSide/Widgets/Datepicker/DatePicker_With_Switch_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ describe(
cy.closePropertyPane();
});
// Skipping tests due to issue - https://www.notion.so/appsmith/f353d8c6bd664f79ad858a42010cdfc8?v=f04cde23f6424aeb9d5a6e389cd172bd&p=0717892d43684c40bae4e2c87b8308cb&pm=s
it.skip("Date Widget with Reset widget being switch widget", function () {
it("Date Widget with Reset widget being switch widget", function () {
EditorNavigation.SelectEntityByName("DatePicker1", EntityType.Widget);

cy.get(formWidgetsPage.defaultDate).click();
Expand All @@ -51,7 +51,7 @@ describe(
cy.get(widgetsPage.switchWidgetInactive).should("be.visible");
});

it.skip("DatePicker-Date change and validate switch widget status", function () {
it("DatePicker-Date change and validate switch widget status", function () {
cy.get(widgetsPage.datepickerInput).click({ force: true });
cy.SetDateToToday();
cy.get(widgetsPage.switchWidgetActive).should("be.visible");
Expand Down
2 changes: 1 addition & 1 deletion app/client/cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect5_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ describe(
});

//Skipping due to open bug #16870
it.skip("8. Bug # 16870 - Verify validation error in default selected values", () => {
it("8. Bug # 16870 - Verify validation error in default selected values", () => {
EditorNavigation.SelectEntityByName("NewMultiSelect", EntityType.Widget);

propPane.MoveToTab("Content");
Expand Down
2 changes: 1 addition & 1 deletion app/client/cypress/e2e/Regression/ClientSide/Widgets/Tab/Tabs_2_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ describe(
});

// to work on redesign of the test, commenting for now
it.skip("7. Verify colors, borders and shadows", () => {
it("7. Verify colors, borders and shadows", () => {
// Verify font color picker opens up
propPane.MoveToTab("Style");
agHelper.GetNClick(propPane._propertyControlColorPicker("accentcolor"));
Expand Down
79 changes: 40 additions & 39 deletions app/client/cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL1_Spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
homePage,
locators,
table,
propPane,
} from "../../../../support/Objects/ObjectsCore";
import EditorNavigation, {
AppSidebar,
Expand Down Expand Up @@ -221,46 +222,46 @@ describe(
});

//Open Bug 14063 - hence skipping
// it.skip("6. Verify Update/Delete row/Delete field data from Deploy page - on Productlines - existing record + Bug 14063", () => {
// EditorNavigation.SelectEntityByName("update_form", EntityType.Widget);
// propPane.ChangeJsonFormFieldType(
// "Text Description",
// "Multiline Text Input",
// );
// propPane.NavigateBackToPropertyPane();
// propPane.ChangeJsonFormFieldType(
// "Html Description",
// "Multiline Text Input",
// );
// propPane.NavigateBackToPropertyPane();
// deployMode.DeployApp();
// table.SelectTableRow(0, 0, false); //to make JSON form hidden
// agHelper.AssertElementAbsence(locators._jsonFormWidget);
// table.SelectTableRow(3);
// agHelper.AssertElementVisibility(locators._jsonFormWidget);

// dataSources.AssertJSONFormHeader(3, 0, "productLine");

// deployMode.EnterJSONTextAreaValue(
// "Html Description",
// "The largest cruise ship is twice the length of the Washington Monument. Some cruise ships have virtual balconies.",
// );
// agHelper.ClickButton("Update"); //Update does not work, Bug 14063
// agHelper.AssertElementAbsence(locators._toastMsg); //Validating fix for Bug 14063
// assertHelper.AssertNetworkStatus("@postExecute", 200);
// table.AssertSelectedRow(3);

// //validating update happened fine!
// table.ReadTableRowColumnData(3, 2, "v1", 200).then(($cellData) => {
// expect($cellData).to.eq(
// "The largest cruise ship is twice the length of the Washington Monument. Some cruise ships have virtual balconies.",
// );
// });
// });
it("6. Verify Update/Delete row/Delete field data from Deploy page - on Productlines - existing record + Bug 14063", () => {
EditorNavigation.SelectEntityByName("update_form", EntityType.Widget);
propPane.ChangeJsonFormFieldType(
"Text Description",
"Multiline Text Input",
);
propPane.NavigateBackToPropertyPane();
propPane.ChangeJsonFormFieldType(
"Html Description",
"Multiline Text Input",
);
Comment on lines +227 to +235
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Replace plain strings with locator variables for better maintainability

To adhere to best practices, please use locator variables instead of plain strings when specifying field names and button labels. This applies to methods like ChangeJsonFormFieldType, EnterJSONTextAreaValue, and ClickButton. Using locator variables enhances readability and makes the code more robust to changes.

For example, you might define locator variables such as this.locators.textDescriptionField and this.locators.updateButton and use them in your methods:

- propPane.ChangeJsonFormFieldType(
-   "Text Description",
-   "Multiline Text Input",
- );
+ propPane.ChangeJsonFormFieldType(
+   this.locators.textDescriptionField,
+   "Multiline Text Input",
+ );

...

- agHelper.ClickButton("Update");
+ agHelper.ClickButton(this.locators.updateButton);

Also applies to: 245-249

propPane.NavigateBackToPropertyPane();
deployMode.DeployApp();
Comment on lines +225 to +237
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider using locator variables instead of plain strings for selectors

In your test steps where you change the JSON form field types, you're using plain strings like "Text Description" and "Multiline Text Input". While this works, it's best practice to use locator variables or data-* attributes for selectors. This enhances maintainability and reduces the risk of errors if the field names change.

To improve your code, you might define constants for these field names:

const FIELD_TEXT_DESCRIPTION = "Text Description";
const FIELD_MULTILINE_TEXT_INPUT = "Multiline Text Input";

propPane.ChangeJsonFormFieldType(FIELD_TEXT_DESCRIPTION, FIELD_MULTILINE_TEXT_INPUT);

table.SelectTableRow(0, 0, false); //to make JSON form hidden
agHelper.AssertElementAbsence(locators._jsonFormWidget);
table.SelectTableRow(3);
agHelper.AssertElementVisibility(locators._jsonFormWidget);

dataSources.AssertJSONFormHeader(3, 0, "productLine");

deployMode.EnterJSONTextAreaValue(
"Html Description",
"The largest cruise ship is twice the length of the Washington Monument. Some cruise ships have virtual balconies.",
);
agHelper.ClickButton("Update"); //Update does not work, Bug 14063
Comment on lines +245 to +249
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Use locator variables instead of plain strings when interacting with UI elements

In lines where you interact with UI elements, such as deployMode.EnterJSONTextAreaValue("Html Description", "...") and agHelper.ClickButton("Update");, you're using plain strings as selectors. It's advisable to use locator variables or data-* attributes for better reliability and readability.

Consider defining locator variables for these elements:

const FIELD_HTML_DESCRIPTION = "Html Description";
const BUTTON_UPDATE = locators._updateButton; // Assuming this locator exists

deployMode.EnterJSONTextAreaValue(FIELD_HTML_DESCRIPTION, "Your text here");
agHelper.ClickButton(BUTTON_UPDATE);

agHelper.AssertElementAbsence(locators._toastMsg); //Validating fix for Bug 14063
assertHelper.AssertNetworkStatus("@postExecute", 200);
table.AssertSelectedRow(3);

// it.skip("7. Verify Add/Update/Delete from Deploy page - on Productlines - new record + Bug 14063", () => {
// //To script aft bug fix!
// });
//validating update happened fine!
table.ReadTableRowColumnData(3, 2, "v1", 200).then(($cellData) => {
expect($cellData).to.eq(
"The largest cruise ship is twice the length of the Washington Monument. Some cruise ships have virtual balconies.",
);
});
Comment on lines +255 to +259
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Avoid hardcoding strings in assertions

It's advisable to store expected values in variables when performing assertions with long strings. This improves clarity and makes future modifications easier.

Here's how you can refactor the assertion:

- expect($cellData).to.eq(
-   "The largest cruise ship is twice the length of the Washington Monument. Some cruise ships have virtual balconies.",
- );
+ const expectedDescription = "The largest cruise ship is twice the length of the Washington Monument. Some cruise ships have virtual balconies.";
+ expect($cellData).to.eq(expectedDescription);
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
table.ReadTableRowColumnData(3, 2, "v1", 200).then(($cellData) => {
expect($cellData).to.eq(
"The largest cruise ship is twice the length of the Washington Monument. Some cruise ships have virtual balconies.",
);
});
table.ReadTableRowColumnData(3, 2, "v1", 200).then(($cellData) => {
const expectedDescription = "The largest cruise ship is twice the length of the Washington Monument. Some cruise ships have virtual balconies.";
expect($cellData).to.eq(expectedDescription);
});

});

it("7. Verify Add/Update/Delete from Deploy page - on Productlines - new record + Bug 14063", () => {
//To script aft bug fix!
});

it("8. Validate Deletion of the Newly Created Page - Productlines", () => {
deployMode.NavigateBacktoEditor();
Expand Down
2 changes: 1 addition & 1 deletion app/client/cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL2_Spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ describe(
});

// https://github.com/appsmithorg/appsmith/issues/29870 Once this issue is fixed then this test case should be enabled and fixed for the table v2
it.skip("7. Verify Refresh table from Deploy page - on Stores & verify all updates persists : Skipped till #29870 gets fixed", () => {
it("7. Verify Refresh table from Deploy page - on Stores & verify all updates persists : Skipped till #29870 gets fixed", () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Please keep the test skipped until issue #29870 is resolved.

Activating the test while the related issue is still open may lead to false negatives and unreliable test results. Once the issue is closed, you can consider enabling the test to ensure it functions as expected.

🔗 Analysis chain

Class, let's examine this change carefully.

The test case that was previously skipped has now been activated. This is a positive step towards improving our test coverage. However, we need to ensure that the issue mentioned in the comment (#29870) has indeed been resolved.

To verify if the issue has been resolved, let's run the following script:

If the issue is closed, we can proceed with confidence. If it's still open, we should consider whether it's appropriate to run this test or if we need to make any adjustments.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if issue #29870 has been closed

gh issue view 29870 --json state -q .state

Length of output: 49

agHelper.GetNClick(dataSources._refreshIcon);

//Store Address deletion remains
Expand Down
2 changes: 1 addition & 1 deletion app/client/cypress/e2e/Sanity/Datasources/MsSQL_Basic_Spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ describe(
});

// TODO: This fails with `Invalid Object <tablename>` error. Looks like there needs to be a delay in query exectuion. Will debug and fix this in a different PR - Sangeeth
it.skip("3.One click binding - should check that queries are created and bound to table widget properly", () => {
it("3.One click binding - should check that queries are created and bound to table widget properly", () => {
entityExplorer.DragDropWidgetNVerify(draggableWidgets.TABLE, 450, 200);

oneClickBinding.ChooseAndAssertForm(dsName, dsName, "Simpsons", {
Expand Down
16 changes: 14 additions & 2 deletions app/client/cypress/limited-tests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,18 @@
# To run only limited tests - give the spec names in below format:
cypress/e2e/Regression/ClientSide/Templates/Fork_Template_spec.js

cypress/e2e/Sanity/Datasources/MsSQL_Basic_Spec.ts
cypress/e2e/Regression/ClientSide/Autocomplete/JS_AC2_spec.ts
cypress/e2e/Regression/ClientSide/Binding/DatePicker_Text_spec.js
cypress/e2e/Regression/ClientSide/Binding/SelectWidget_Spec.ts
cypress/e2e/Regression/ClientSide/BugTests/DatasourceSchema_spec.ts
cypress/e2e/Regression/ClientSide/Git/GitSync/GitSyncedApps_spec.js
cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Datepicker/DatePicker_With_Switch_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Datepicker/DatePicker2_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect5_spec.ts
cypress/e2e/Regression/ClientSide/Widgets/Tab/Tabs_2_spec.ts
cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL1_Spec.ts
cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL2_Spec.ts
cypress/e2e/Regression/ClientSide/ActionExecution/ActionSelectorCreateShouldBind_spec.ts
Comment on lines +2 to +15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification



Attention Team: Missing Fork_Template_spec.js Test


It looks like the Fork_Template_spec.js test was removed from our limited test suite, and I couldn't find a direct replacement. This might mean we're missing crucial coverage for the template forking functionality.


Action Items:


    

  • Verify Coverage: Check if other tests, such as those in BuildingBlock.test.tsx or TemplateCard.test.tsx, adequately cover the template forking scenarios previously handled by Fork_Template_spec.js.
    • 

  • Add Missing Tests: If coverage is lacking, reinstate the Fork_Template_spec.js test or create new tests to ensure comprehensive coverage of template forking features.
    • 




🔗 Analysis chain

Class, let's review the changes in our test suite!


Good morning, students! Today, we're going to examine the modifications made to our limited-tests.txt file. Let's break it down:


    

  1. 

    Test Coverage Expansion:
    
We've significantly increased our test coverage! We've gone from a single test to a whopping 14 tests. This is like going from a pop quiz to a full exam. It's more comprehensive and will give us a better understanding of our application's health.
    

    2. 

  2. 

    Removal of 'Fork_Template_spec.js':
    
Now, pay attention here. We've removed the 'Fork_Template_spec.js' test. Can anyone tell me why this might be important? That's right! We need to ensure that template forking functionality is still being tested elsewhere. Let's make a note to double-check this.
    

    3. 

  3. 

    File Format Consistency:
    
I'm pleased to see that everyone has maintained proper formatting. Each test specification is on its own line, just like how each answer should be on its own line in your exam papers. Well done!
    

    4. 

  4. 

    Purpose Reminder:
    
Remember, class, this file is crucial for our CI process. It's like our study guide for the big test. We use it to run a limited set of tests quickly. Always keep this purpose in mind when modifying this file.
    

    5. 



Homework assignment: Let's verify if the 'Fork_Template_spec.js' test is covered elsewhere. Run this command:


Any volunteers to share their findings tomorrow?






Great effort, everyone! It seems our previous search didn't find the cypress/e2e directory. Let's broaden our search to ensure we locate any test files related to template forking. Please run the following command:






Alright class, our previous search didn’t find the cypress/e2e directory. Let’s broaden our search to ensure we locate any test files related to template forking across the entire repository. Please run the following command:





🏁 Scripts executed

The following scripts were executed for the analysis:


Script:


#!/bin/bash
# Search for any test files related to template forking
rg -t js -t ts "Fork.*Template" "cypress/e2e"



Length of output: 97




Script:


# Search for any test files related to template forking across the entire repository
rg -t js -t ts "Fork.*Template"



Length of output: 8175




Script:


# Search for any test files related to template forking across the entire repository
rg -t js -t ts "Fork.*Template"



Length of output: 8175




    

  
  



    


        

      
  

    
  
    
    

  

  




        

      
    








    


  









  


    


  		



    

    

    

  
    # For running all specs - uncomment below:






    

    

    

  
    #cypress/e2e/**/**/*






    

    

    

  
    







  

    
          
            
          
          Expand Down
    
    
  



                
              


          


    

  



  



    

  
    
      Loading