Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing unused dependencies and explicitly installing used ones #36573

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix: removing unused dependencies and explicitly installing used ones #36573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions app/client/knip.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"$schema": "https://unpkg.com/knip@5/schema.json",
"entry": ["src/index.tsx"],
"project": ["src/**/*.{tsx,ts,js}"],
"ignore": [
Expand All @@ -13,12 +14,40 @@
"src/plugins/Linting/**",
"src/ee/plugins/Linting/**",
"src/ce/plugins/Linting/**",
"src/ce/sagas/EnvironmentSagas.ts",
"src/ce/utils/analyticsHelpers.ts",
"src/ce/utils/autocomplete/helpers.ts",
"src/ce/utils/workflowHelpers.ts",
"src/workers/Evaluation/**",
"src/widgets/ExternalWidget/component/script.js",
"src/widgets/ListWidgetV2/widget/derived.js",
"src/workers/Tern/tern.worker.ts",
"src/widgets/CustomWidget/component/appsmithConsole.js",
"src/serviceWorker.ts",
"src/ee/utils/serviceWorkerUtils.ts"
],
"ignoreDependencies": [
"craco-alias",
"craco-babel-loader",
"babel-plugin-lodash",
"@types/google.maps",
"@types/web",
"postcss-url",
"@types/dom-view-transitions",
"@types/jest",
"@sentry/webpack-plugin",
"compression-webpack-plugin",
"webpack-retry-chunk-load-plugin",
"lint-staged",
"ts-jest-mock-import-meta",
"cypress-log-to-output",
"cypress-repeat-pro",
"cypress-multi-reporters",
"@aws-sdk/client-s3",
"@aws-sdk/lib-storage",
"@octokit/rest",
"@faker-js/faker",
"pg",
"factory.ts"
]
}
63 changes: 16 additions & 47 deletions app/client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
"@appsmith/ads-old": "workspace:^",
"@appsmith/utils": "workspace:^",
"@appsmith/wds": "workspace:^",
"@appsmith/wds-headless": "workspace:^",
"@appsmith/wds-theming": "workspace:^",
"@aws-sdk/client-s3": "^3.622.0",
"@aws-sdk/lib-storage": "^3.622.0",
Expand All @@ -61,19 +62,18 @@
"@blueprintjs/icons": "3.22.0",
"@blueprintjs/popover2": "^0.5.0",
"@blueprintjs/select": "^3.10.0",
"@design-system/storybook": "workspace:^",
"@design-system/widgets-old": "workspace:^",
"@floating-ui/dom": "^1.6.4",
"@fusioncharts/powercharts": "^3.16.0",
"@floating-ui/react": "^0.26.24",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Students, pay attention to this significant change in our dependencies.

We've replaced @fusioncharts/powercharts with @floating-ui/react. This is a substantial change that requires our careful consideration. @floating-ui/react is not a charting library, but a positioning library for UI elements.

This change raises some questions:

  1. Have we removed all usages of @fusioncharts/powercharts from our codebase?
  2. What alternative are we using for charting now?
  3. How are we planning to use @floating-ui/react in our project?

For your homework, I want you to review the codebase and identify any remaining references to @fusioncharts/powercharts. Also, please provide a brief explanation of how we plan to use @floating-ui/react in our project.

"@github/g-emoji-element": "^1.1.5",
"@googlemaps/markerclusterer": "^2.0.14",
"@googlemaps/react-wrapper": "^1.1.35",
"@loadable/component": "^5.15.3",
"@manaflair/redux-batch": "^1.0.0",
"@mantine/hooks": "^5.10.1",
"@newrelic/browser-agent": "^1.255.0",
"@opentelemetry/auto-instrumentations-web": "0.40.0",
"@opentelemetry/api": "^1.9.0",
"@opentelemetry/context-zone": "1.25.1",
"@opentelemetry/core": "^1.26.0",
"@opentelemetry/exporter-metrics-otlp-http": "0.52.1",
"@opentelemetry/exporter-trace-otlp-proto": "0.52.1",
"@opentelemetry/instrumentation": "0.52.1",
Expand All @@ -82,7 +82,10 @@
"@opentelemetry/sdk-trace-base": "1.25.1",
"@opentelemetry/sdk-trace-web": "1.25.1",
"@opentelemetry/semantic-conventions": "1.25.1",
"@react-spring/web": "^9.7.4",
"@react-types/shared": "^3.23.0",
"@redux-saga/core": "1.1.3",
"@redux-saga/types": "1.2.1",
"@sentry/react": "^6.2.4",
"@shared/ast": "workspace:^",
"@shared/dsl": "workspace:^",
Expand All @@ -95,15 +98,16 @@
"@types/web": "^0.0.99",
"@uppy/core": "^1.16.0",
"@uppy/dashboard": "^1.16.0",
"@uppy/file-input": "^1.4.22",
"@uppy/google-drive": "^1.5.22",
"@uppy/image-editor": "^0.2.4",
"@uppy/onedrive": "^1.1.22",
"@uppy/react": "^1.11.2",
"@uppy/url": "^1.5.16",
"@uppy/utils": "^6.0.2",
"@uppy/webcam": "^1.8.4",
"@welldone-software/why-did-you-render": "^4.2.5",
"algoliasearch": "^4.2.0",
"acorn": "8.10.0",
"acorn-walk": "8.2.0",
"appsmith-icons": "workspace:^",
"assert-never": "^1.2.1",
"astring": "^1.7.5",
Expand All @@ -113,14 +117,15 @@
"clsx": "^1.2.1",
"codemirror": "^5.65.13",
"codemirror-graphql": "^1.2.14",
"colorjs.io": "^0.5.2",
"copy-to-clipboard": "^3.3.1",
"core-js": "^3.9.1",
"craco-alias": "^2.1.1",
"craco-babel-loader": "^1.0.4",
"cssnano": "^6.0.1",
"cypress-log-to-output": "^1.1.2",
"cypress-repeat-pro": "^1.0.1",
"d3-geo": "^3.1.0",
"date-fns": "2.30.0",
"dayjs": "^1.10.6",
"deep-diff": "^1.0.2",
"downloadjs": "^1.4.7",
Expand All @@ -133,18 +138,13 @@
"fusioncharts": "^3.18.0",
"graphql": "^16.8.1",
"history": "^4.10.1",
"http-proxy": "^1.18.1",
"immer": "^9.0.6",
"instantsearch.css": "^7.4.2",
"interweave": "^12.7.2",
"interweave-autolink": "^4.4.2",
"jest-preview": "^0.3.1",
"js-beautify": "^1.14.0",
"js-regex-pl": "^1.0.1",
"js-sha256": "^0.9.0",
"jshint": "^2.13.4",
"klona": "^2.0.5",
"konva": "8.0.1",
"libphonenumber-js": "^1.9.44",
"linkedom": "^0.14.20",
"localforage": "^1.7.3",
Expand All @@ -153,47 +153,37 @@
"loglevel": "^1.7.1",
"lottie-web": "^5.7.4",
"mammoth": "^1.5.1",
"marked": "^4.0.18",
"memoize-one": "^6.0.0",
"micro-memoize": "^4.0.10",
"microdiff": "^1.4.0",
"moment": "2.29.4",
"moment-timezone": "^0.5.35",
"nanoid": "^2.0.4",
"node-forge": "^1.3.0",
"normalizr": "^3.3.0",
"object-hash": "^3.0.0",
"path-to-regexp": "^6.3.0",
"popper.js": "^1.15.0",
"prismjs": "^1.27.0",
"proxy-memoize": "^1.2.0",
"punycode": "^2.1.1",
"rc-pagination": "^3.1.3",
"rc-select": "^14.1.9",
"rc-tree-select": "^5.4.0",
"re-reselect": "^3.4.0",
"react": "^17.0.2",
"react-append-to-body": "^2.0.26",
"react-beautiful-dnd": "^12.2.0",
"react-custom-scrollbars": "^4.2.1",
"react-device-detect": "^2.2.2",
"react-dnd": "^9.3.4",
"react-dnd-html5-backend": "^9.3.4",
"react-dnd-touch-backend": "^9.4.0",
"react-documents": "^1.0.4",
"react-dom": "^17.0.2",
"react-full-screen": "^1.1.0",
"react-google-recaptcha": "^2.1.0",
"react-helmet": "^5.2.1",
"react-hook-form": "^7.28.0",
"react-instantsearch-dom": "^6.4.0",
"react-json-view": "^1.21.3",
"react-konva": "17.0.2-6",
"react-masonry-css": "^1.0.16",
"react-media-recorder": "^1.6.1",
"react-modal": "^3.15.1",
"react-page-visibility": "^7.0.0",
"react-paginating": "^1.4.0",
"react-player": "^2.3.1",
"react-qr-barcode-scanner": "^1.0.6",
"react-rating": "^2.0.5",
Expand All @@ -202,9 +192,7 @@
"react-router": "^5.1.2",
"react-router-dom": "^5.1.2",
"react-scripts": "^5.0.1",
"react-select": "^3.0.8",
"react-spring": "^9.4.0",
"react-syntax-highlighter": "^15.5.0",
"react-table": "^7.0.0",
"react-table-sticky": "^1.1.3",
"react-tabs": "^3.0.0",
Expand All @@ -219,6 +207,7 @@
"redux-saga": "^1.1.3",
"remixicon-react": "^1.0.0",
"reselect": "^4.0.0",
"resize-observer-polyfill": "^1.5.1",
"sass": "^1.70.0",
"scroll-into-view-if-needed": "^2.2.26",
"shallowequal": "^1.1.0",
Expand All @@ -231,15 +220,15 @@
"tailwindcss": "^3.3.3",
"tern": "^0.21.0",
"tinycolor2": "^1.4.2",
"to-json-schema": "^0.2.5",
"tinymce": "^7.3.0",
"toposort": "^2.0.2",
"tslib": "^2.3.1",
"typescript": "^5.5.4",
"unescape-js": "^1.1.4",
"url-search-params-polyfill": "^8.0.0",
"uuid": "^9.0.0",
"validate-color": "^2.2.4",
"webfontloader": "^1.6.28",
"web-vitals": "3.5.2",
"webpack-retry-chunk-load-plugin": "^3.1.1",
"yjs": "^13.5.12",
"zipcelx": "^1.6.2"
Expand All @@ -252,14 +241,11 @@
],
"devDependencies": {
"@appsmith/eslint-plugin": "workspace:^",
"@babel/helper-create-regexp-features-plugin": "^7.18.6",
"@babel/helper-string-parser": "^7.19.4",
"@craco/craco": "^7.0.0",
"@cypress/grep": "^4.0.1",
"@faker-js/faker": "^7.4.0",
"@octokit/rest": "^20.0.1",
"@peculiar/webcrypto": "^1.4.3",
"@redux-saga/testing-utils": "^1.1.5",
"@sentry/webpack-plugin": "^1.18.9",
"@simonsmith/cypress-image-snapshot": "^9.1.0",
"@testing-library/jest-dom": "5.16.1",
Expand All @@ -268,49 +254,39 @@
"@testing-library/user-event": "13.5.0",
"@types/codemirror": "^0.0.96",
"@types/deep-diff": "^1.0.0",
"@types/dom-mediacapture-record": "^1.0.11",
"@types/dom-view-transitions": "^1.0.5",
"@types/downloadjs": "^1.4.2",
"@types/jest": "^27.4.1",
"@types/js-beautify": "^1.13.2",
"@types/jshint": "^2.12.0",
"@types/lodash": "^4.14.120",
"@types/marked": "^4.0.3",
"@types/moment-timezone": "^0.5.10",
"@types/nanoid": "^2.0.0",
"@types/node": "^10.12.18",
"@types/node-fetch": "^2.6.11",
"@types/node-forge": "^0.10.0",
"@types/object-hash": "^2.2.1",
"@types/pg": "^8.10.2",
"@types/prismjs": "^1.16.1",
"@types/react": "^17.0.2",
"@types/react-beautiful-dnd": "^11.0.4",
"@types/react-custom-scrollbars": "^4.0.7",
"@types/react-dom": "^17.0.2",
"@types/react-google-recaptcha": "^2.1.1",
"@types/react-helmet": "^5.0.14",
"@types/react-instantsearch-dom": "^6.3.0",
"@types/react-instantsearch-core": "^6.26.10",
"@types/react-modal": "^3.13.1",
"@types/react-redux": "^7.0.1",
"@types/react-router-dom": "^5.1.2",
"@types/react-select": "^3.0.5",
"@types/react-syntax-highlighter": "^13.5.2",
"@types/react-table": "^7.0.13",
"@types/react-tabs": "^2.3.1",
"@types/react-test-renderer": "^17.0.1",
"@types/react-window": "^1.8.2",
"@types/redux-form": "^8.1.9",
"@types/redux-mock-store": "^1.0.2",
"@types/resize-observer-browser": "^0.1.5",
"@types/showdown": "^1.9.4",
"@types/styled-components": "^5.1.26",
"@types/tern": "0.22.0",
"@types/tinycolor2": "^1.4.2",
"@types/to-json-schema": "^0.2.1",
"@types/toposort": "^2.0.3",
"@types/uuid": "^9.0.5",
"@types/webfontloader": "1.6.33",
"@types/zipcelx": "^1.5.0",
"@typescript-eslint/eslint-plugin": "^6.7.4",
"@typescript-eslint/parser": "^6.7.4",
Expand All @@ -337,7 +313,6 @@
"eslint-config-prettier": "^9.0.0",
"eslint-import-resolver-babel-module": "^5.3.2",
"eslint-plugin-cypress": "^2.15.1",
"eslint-plugin-import": "^2.28.1",
"eslint-plugin-jest": "^27.4.2",
"eslint-plugin-prettier": "^5.0.0",
"eslint-plugin-react": "^7.33.2",
Expand All @@ -346,7 +321,6 @@
"eslint-plugin-sort-destructure-keys": "^1.5.0",
"eslint-plugin-storybook": "^0.6.15",
"eslint-plugin-testing-library": "^6.2.0",
"esm": "^3.2.25",
"factory.ts": "^0.5.1",
"husky": "^8.0.0",
"jest": "^27.4.1",
Expand All @@ -366,22 +340,17 @@
"postcss-modules-values": "^4.0.0",
"postcss-nesting": "^12.0.1",
"postcss-url": "^10.1.3",
"postinstall-postinstall": "^2.1.0",
"prettier": "^3.0.3",
"prop-types": "^15.8.1",
"raw-loader": "^4.0.2",
"react-is": "^16.12.0",
"react-test-renderer": "^16.11.0",
"redux-devtools": "^3.5.0",
"redux-devtools-extension": "^2.13.8",
"redux-mock-store": "^1.5.4",
"redux-saga-test-plan": "^4.0.6",
"ts-jest": "29.1.0",
"ts-jest-mock-import-meta": "^0.12.0",
"ts-loader": "^9.4.1",
"ts-node": "^10.9.1",
"webpack-merge": "^5.8.0",
"workbox-webpack-plugin": "^6.5.3",
"xlsx": "https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz"
},
"resolutions": {
Expand Down
2 changes: 0 additions & 2 deletions app/client/packages/ast/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
"build": "rollup -c"
},
"dependencies": {
"@babel/runtime": "^7.21.0",
"@rollup/plugin-commonjs": "^22.0.0",
"@types/escodegen": "^0.0.7",
"@types/lodash": "^4.14.120",
Expand All @@ -32,7 +31,6 @@
"unescape-js": "^1.1.4"
},
"devDependencies": {
"@babel/preset-typescript": "^7.17.12",
"@types/jest": "29.0.3",
"@typescript-eslint/eslint-plugin": "^5.25.0",
"@typescript-eslint/parser": "^5.25.0",
Expand Down
13 changes: 2 additions & 11 deletions app/client/packages/design-system/ads-old/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,12 @@
],
"license": "Apache-2.0",
"devDependencies": {
"@types/loadable__component": "^5.13.4",
"@types/react-form": "^4.0.2",
"@types/wait-on": "^5.2.0",
"concurrently": "^7.3.0",
"identity-obj-proxy": "3.0.0",
"react-toastify": "^5.5.0",
"wait-on": "^5.3.0"
"identity-obj-proxy": "3.0.0"
},
"browserslist": [
">0.2%",
"not dead",
"not ie <= 11",
"not op_mini all"
],
"dependencies": {
"emoji-mart": "3.0.1"
}
]
}
Loading
Loading