Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preventing objects from collapsing in the debugger when resizing #36477

Conversation

saiprabhu-dandanayak
Copy link
Contributor

@saiprabhu-dandanayak saiprabhu-dandanayak commented Sep 23, 2024

Description

i have raised this pr in-order to prevent objects from collapsing in the debugger when resizing.

This pull request includes a small change to the LogItem component in the Debugger directory. The change optimizes the component by wrapping it with React.memo to prevent unnecessary re-renders.

Fixes #21423

Summary by CodeRabbit

  • New Features
    • Enhanced performance of the LogItem component by optimizing its rendering with memoization.

This change ensures that the component only re-renders when its props change, leading to a smoother user experience.

Copy link
Contributor

coderabbitai bot commented Sep 23, 2024

Walkthrough

The changes involve modifying the export statement of the LogItem component in the LogItem.tsx file. The component is now exported using React.memo, which enhances performance by memoizing the component's output based on its props. This adjustment ensures that the component only re-renders when its props change, optimizing rendering behavior.

Changes

File Change Summary
app/client/src/components/editorComponents/Debugger/LogItem.tsx Exported LogItem component wrapped in React.memo for optimization.

Suggested labels

skip-changelog, ok-to-test, Test

Suggested reviewers

  • ApekshaBhosale
  • sagar-qa007

Poem

In the code where LogItem lies,
Wrapped in memo, it surely flies.
Props unchanged, it stays so neat,
A performance boost, a lovely treat!
With each render, it shines anew,
Efficiency’s friend, we bid adieu! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@saiprabhu-dandanayak
Copy link
Contributor Author

@appsmithorg/query-js-pod , can you pls assign a reviewer for this PR.
Thanks in advance.

Copy link

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Sep 30, 2024
Copy link

github-actions bot commented Oct 8, 2024

This PR has been closed because of inactivity.

@github-actions github-actions bot closed this Oct 8, 2024
@alex-golovanov alex-golovanov reopened this Oct 9, 2024
@alex-golovanov alex-golovanov changed the title fix:Preventing objects from collapsing in the debugger when resizing fix: preventing objects from collapsing in the debugger when resizing Oct 9, 2024
@alex-golovanov alex-golovanov self-assigned this Oct 9, 2024
@alex-golovanov
Copy link
Contributor

/build-deploy-preview skip-tests=true

Copy link

github-actions bot commented Oct 9, 2024

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11256977949.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 36477.
recreate: .

Copy link

github-actions bot commented Oct 9, 2024

Deploy-Preview-URL: https://ce-36477.dp.appsmith.com

@alex-golovanov alex-golovanov self-requested a review October 9, 2024 15:35
@alex-golovanov alex-golovanov removed their assignment Oct 9, 2024
@alex-golovanov
Copy link
Contributor

@saiprabhu-dandanayak the fix is working, thank you. Just need to run some tests in a separate PR.

@saiprabhu-dandanayak
Copy link
Contributor Author

Sure , please let me know if any changes needs to be done.

@alex-golovanov
Copy link
Contributor

Shadow PR tests are passing.

@hetunandu hetunandu merged commit 9a63c91 into appsmithorg:release Oct 10, 2024
20 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Dec 9, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: resizing debugger causes log item to collapse
3 participants