Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing cta for git import modal #36364

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix: fixing cta for git import modal #36364

merged 2 commits into from
Sep 20, 2024

Conversation

brayn003
Copy link
Contributor

@brayn003 brayn003 commented Sep 17, 2024

Description

Fixes CTA for git import modal to "Import App"

Fixes #32388

Automation

/ok-to-test tags="@tag.Git"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10958198926
Commit: 3a4468f
Cypress dashboard.
Tags: @tag.Git
Spec:


Fri, 20 Sep 2024 11:44:10 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features

    • Introduced a new call-to-action message for importing an app, enhancing user guidance.
    • Improved the Git connection process by providing context-sensitive messages based on the import state.
  • Bug Fixes

    • Adjusted the text displayed during the Git connection steps to reflect the import status dynamically.

@brayn003 brayn003 requested a review from a team as a code owner September 17, 2024 09:15
@brayn003 brayn003 self-assigned this Sep 17, 2024
Copy link
Contributor

coderabbitai bot commented Sep 17, 2024

Walkthrough

The pull request introduces a new constant, IMPORT_APP_CTA, to the messages.ts file, which provides a clear call-to-action for importing an app. Additionally, it modifies the GitConnectionV2 component by relocating the nextStepText object inside the component to allow dynamic text adjustment based on the isImport prop. This ensures that the appropriate message is displayed during the Git connection process.

Changes

File Change Summary
app/client/src/ce/constants/messages.ts Added a new constant IMPORT_APP_CTA for the import app call-to-action message.
app/client/src/pages/Editor/gitSync/Tabs/GitConnectionV2/index.tsx Moved nextStepText inside GitConnectionV2 to allow dynamic text based on isImport prop.

Assessment against linked issues

Objective Addressed Explanation
Text on CTA in modal during import via git should be Import App (#32388)

Possibly related PRs

  • fix: IDE Header Height usage #36297: This PR modifies the EditorName/components.ts file, focusing solely on CSS adjustments without any connection to the constants or dynamic text changes.

Suggested labels

Bug, IDE Product, Needs Triaging, ok-to-test

Poem

In the world of code, a change so bright,
A button to click, guiding with light.
"Import App" it says, clear as can be,
Enhancing the flow, as smooth as the sea.
With Git connections now feeling just right,
A user-friendly journey, oh what a delight! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@brayn003 brayn003 added the ok-to-test Required label for CI label Sep 17, 2024
@github-actions github-actions bot added Bug Something isn't working Git Platform Issues related to the git & the app platform Git Product Issues related to version control product Low An issue that is neither critical nor breaks a user flow Low effort Takes 1-2 days Production labels Sep 17, 2024
@brayn003 brayn003 merged commit e798ec6 into release Sep 20, 2024
42 checks passed
@brayn003 brayn003 deleted the fix/git-import-cta branch September 20, 2024 15:55
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this pull request Sep 26, 2024
## Description
Fixes CTA for git import modal to "Import App"

Fixes appsmithorg#32388

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10958198926>
> Commit: 3a4468f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10958198926&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Fri, 20 Sep 2024 11:44:10 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a new call-to-action message for importing an app,
enhancing user guidance.
- Improved the Git connection process by providing context-sensitive
messages based on the import state.

- **Bug Fixes**
- Adjusted the text displayed during the Git connection steps to reflect
the import status dynamically.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Git Platform Issues related to the git & the app platform Git Product Issues related to version control product Low effort Takes 1-2 days Low An issue that is neither critical nor breaks a user flow ok-to-test Required label for CI Production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text on CTA in modal during import via git should be &#x60;Import App&#x60;
2 participants