feat: Action redesign: Updating Mongo plugin form config #35883
Conversation
WalkthroughThe recent changes encompass modifications to the styling of a dynamic input text control and significant enhancements to the MongoDB plugin's editor configuration. The input control's JSX structure was updated to include a new CSS class, while the CSS styles were adjusted for greater flexibility. The MongoDB plugin's JSON configuration underwent a major restructuring, introducing new control types, expanded command options, and dynamic visibility logic for enhanced user interaction. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Editor
participant MongoDBPlugin
User->>Editor: Select command type
Editor->>MongoDBPlugin: Fetch input options based on command
MongoDBPlugin-->>Editor: Return relevant input fields
Editor-->>User: Display dynamic input fields
User->>Editor: Submit query
Editor->>MongoDBPlugin: Execute query
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add Documentation and Community
|
github-actions
bot
added
IDE Navigation
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10561252900. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- app/client/src/components/formControls/DynamicInputTextControl.tsx (1 hunks)
- app/client/src/pages/Editor/ActionForm/Zone/styles.module.css (1 hunks)
- app/server/appsmith-plugins/mongoPlugin/src/main/resources/editor/root.json (1 hunks)
Files skipped from review due to trivial changes (2)
- app/client/src/components/formControls/DynamicInputTextControl.tsx
- app/client/src/pages/Editor/ActionForm/Zone/styles.module.css
Additional comments not posted (19)
app/server/appsmith-plugins/mongoPlugin/src/main/resources/editor/root.json (19)
4-4: Excellent! Updated control type to SECTION_V2The change from
SECTIONtoSECTION_V2indicates an enhancement. Ensure that the new version is backward compatible.Please verify if there are any dependencies or other configurations that need to be updated to support
SECTION_V2.
8-8: Great! Introduced DOUBLE_COLUMN_ZONEThe introduction of
DOUBLE_COLUMN_ZONEallows for a more flexible UI layout. This is a good improvement for user experience.The code changes are approved.
12-50: Well done! Expanded command optionsThe expanded command options provide more functionality to the users. This is a significant enhancement.
The code changes are approved.
53-71: Nice! Dynamic collection fetchingThe dynamic fetching of collection options based on conditions is a great addition. This improves the user experience by showing relevant options.
The code changes are approved.
76-93: Good! Added SINGLE_COLUMN_ZONE for AGGREGATEThe addition of
SINGLE_COLUMN_ZONEfor theAGGREGATEcommand with specific fields is well-structured.The code changes are approved.
95-109: Nice! Added DOUBLE_COLUMN_ZONE for AGGREGATEThe addition of
DOUBLE_COLUMN_ZONEfor theAGGREGATEcommand with specific fields is well-structured.The code changes are approved.
111-127: Good! Added SINGLE_COLUMN_ZONE for COUNTThe addition of
SINGLE_COLUMN_ZONEfor theCOUNTcommand with specific fields is well-structured.The code changes are approved.
130-147: Nice! Added SINGLE_COLUMN_ZONE for DELETEThe addition of
SINGLE_COLUMN_ZONEfor theDELETEcommand with specific fields is well-structured.The code changes are approved.
149-175: Good! Added DOUBLE_COLUMN_ZONE for DELETEThe addition of
DOUBLE_COLUMN_ZONEfor theDELETEcommand with specific fields is well-structured.The code changes are approved.
177-194: Nice! Added SINGLE_COLUMN_ZONE for DISTINCTThe addition of
SINGLE_COLUMN_ZONEfor theDISTINCTcommand with specific fields is well-structured.The code changes are approved.
196-210: Good! Added DOUBLE_COLUMN_ZONE for DISTINCTThe addition of
DOUBLE_COLUMN_ZONEfor theDISTINCTcommand with specific fields is well-structured.The code changes are approved.
212-228: Nice! Added SINGLE_COLUMN_ZONE for FINDThe addition of
SINGLE_COLUMN_ZONEfor theFINDcommand with specific fields is well-structured.The code changes are approved.
230-253: Good! Added DOUBLE_COLUMN_ZONE for FINDThe addition of
DOUBLE_COLUMN_ZONEfor theFINDcommand with specific fields is well-structured.The code changes are approved.
255-276: Nice! Added DOUBLE_COLUMN_ZONE for FINDThe addition of
DOUBLE_COLUMN_ZONEfor theFINDcommand with specific fields is well-structured.The code changes are approved.
278-295: Good! Added SINGLE_COLUMN_ZONE for INSERTThe addition of
SINGLE_COLUMN_ZONEfor theINSERTcommand with specific fields is well-structured.The code changes are approved.
297-314: Nice! Added SINGLE_COLUMN_ZONE for UPDATEThe addition of
SINGLE_COLUMN_ZONEfor theUPDATEcommand with specific fields is well-structured.The code changes are approved.
316-331: Good! Added SINGLE_COLUMN_ZONE for UPDATEThe addition of
SINGLE_COLUMN_ZONEfor theUPDATEcommand with specific fields is well-structured.The code changes are approved.
333-359: Nice! Added DOUBLE_COLUMN_ZONE for UPDATEThe addition of
DOUBLE_COLUMN_ZONEfor theUPDATEcommand with specific fields is well-structured.The code changes are approved.
361-387: Good! Added SINGLE_COLUMN_ZONE for RAWThe addition of
SINGLE_COLUMN_ZONEfor theRAWcommand with specific fields is well-structured.The code changes are approved.
|
Deploy-Preview-URL: https://ce-35883.dp.appsmith.com |
Failed server tests
|
)" This reverts commit 0a3492f.
…5903) Reverts #35883 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced user-friendly configurations for various MongoDB operations, including "AGGREGATE," "COUNT," "DELETE," "DISTINCT," "FIND," "INSERT," "RAW," and "UPDATE." - Enhanced dynamic dropdowns for selecting collections and streamlined input sections for constructing queries. - **Bug Fixes** - Simplified the structure of the input text controls for better usability and responsiveness in UI design. - **Refactor** - Cleaned up unnecessary elements in the codebase to improve maintainability and performance. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description
This PR updates the form config for Mongo plugin to accommodate new SECTION_V2, SINGLE_COLUMN_ZONE, and DOUBLE_COLUMN_ZONE.
Fixes #35495
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10561281548
Commit: b9a3f0f
Cypress dashboard.
Tags:
@tag.AllSpec:
Mon, 26 Aug 2024 15:08:27 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
Bug Fixes
Documentation