Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hidden page was not being checked for route change #35558

Merged
merged 2 commits into from
Aug 9, 2024
Merged

fix: hidden page was not being checked for route change #35558

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9bc4e4
fix: hidden page was not being checked for route change
AmanAgarwal041 Aug 8, 2024
e8064dc
fix: get all pages list for navigation
AmanAgarwal041 Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/client/src/pages/AppViewer/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import * as Sentry from "@sentry/react";
import {
getCurrentPageDescription,
getIsAutoLayout,
getViewModePageList,
getPageList,
} from "selectors/editorSelectors";
import { getThemeDetails, ThemeMode } from "selectors/themeSelectors";
import { getSearchQuery } from "utils/helpers";
Expand Down Expand Up @@ -88,7 +88,7 @@ function AppViewer(props: Props) {
const { pathname, search } = props.location;
const { baseApplicationId, basePageId } = props.match.params;
const isInitialized = useSelector(getIsInitialized);
const pages = useSelector(getViewModePageList);
const pages = useSelector(getPageList);
const selectedTheme = useSelector(getSelectedAppTheme);
const lightTheme = useSelector((state: AppState) =>
getThemeDetails(state, ThemeMode.LIGHT),
Expand Down
Loading