fix: fixated deserialisation from files to respective types #35103

sondermanish · 2024-07-23T04:35:22Z

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Git"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10052956494
Commit: c36c6a9
Cypress dashboard.
Tags: @tag.Git
Spec:

Tue, 23 Jul 2024 05:15:05 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

New Features
- Enhanced JSON deserialization to preserve float values accurately, improving data integrity during processing.
Documentation
- Added comments to clarify the purpose of changes in the deserialization process.

coderabbitai · 2024-07-23T04:35:39Z

Walkthrough

The recent changes enhance JSON deserialization in the FileOperationsCEv2Impl class by configuring the ObjectMapper to prevent floating-point numbers from being interpreted as integers. This modification aims to improve the accuracy of numeric representations during data processing, thereby bolstering data integrity and robustness in file operations.

Changes

Files	Change Summary
`app/server/appsmith-git/src/main/java/com/appsmith/git/files/operations/FileOperationsCEv2Impl.java`	Improved JSON deserialization by disabling the `ACCEPT_FLOAT_AS_INT` feature in `ObjectMapper`, ensuring proper handling of floating-point values. Added comments to clarify the intent of the changes.

Sequence Diagram(s)

(No sequence diagrams generated as the changes are straightforward and do not introduce new features or complex interactions.)

Poem

In code we trust, with floats so bright,
Deserialization shines, making data right.
With every change, our systems grow,
Ensuring accuracy, we reap what we sow!
A step for data, a leap for delight,
In the realm of bytes, we bask in the light! ✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 351acde and 19c0fe8.

Files selected for processing (1)

app/server/appsmith-git/src/main/java/com/appsmith/git/files/operations/FileOperationsCEv2Impl.java (2 hunks)

Additional comments not posted (2)

app/server/appsmith-git/src/main/java/com/appsmith/git/files/operations/FileOperationsCEv2Impl.java (2)

17-17: Good addition of import statement.

The import statement for DeserializationFeature is necessary for the new configuration in the ObjectMapper.

68-70: Excellent configuration change for data accuracy.

Disabling the ACCEPT_FLOAT_AS_INT feature in the ObjectMapper ensures that floating-point values are not incorrectly interpreted as integers during deserialization. This change enhances the accuracy and integrity of the data.

nidhi-nair · 2024-07-23T04:48:40Z

...ver/appsmith-git/src/main/java/com/appsmith/git/files/operations/FileOperationsCEv2Impl.java

@@ -64,6 +65,9 @@ public FileOperationsCEv2Impl(
        super(gitServiceConfig, gitExecutor, gsonBuilder, observationHelper);

        this.objectMapper = SerializationUtils.getBasicObjectMapper(prettyPrinter);
+
+        // this is done in order to stop importing float values as int while deserializing
+        this.objectMapper.disable(DeserializationFeature.ACCEPT_FLOAT_AS_INT);


@sondermanish does this return another immutable object or modify the current object? In either case we shouldn't be using this like so, we'd not be changing anything.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 19c0fe8 and c36c6a9.

Files selected for processing (1)

app/server/appsmith-git/src/main/java/com/appsmith/git/files/operations/FileOperationsCEv2Impl.java (2 hunks)

Files skipped from review as they are similar to previous changes (1)

app/server/appsmith-git/src/main/java/com/appsmith/git/files/operations/FileOperationsCEv2Impl.java

added changes

19c0fe8

sondermanish requested a review from a team as a code owner July 23, 2024 04:35

github-actions bot added the Bug Something isn't working label Jul 23, 2024

coderabbitai bot reviewed Jul 23, 2024

View reviewed changes

nidhi-nair reviewed Jul 23, 2024

View reviewed changes

added fix from comment

c36c6a9

nidhi-nair approved these changes Jul 23, 2024

View reviewed changes

sondermanish self-assigned this Jul 23, 2024

sondermanish added the ok-to-test Required label for CI label Jul 23, 2024

coderabbitai bot reviewed Jul 23, 2024

View reviewed changes

sondermanish enabled auto-merge (squash) July 23, 2024 05:06

sondermanish merged commit a38ef9a into release Jul 23, 2024
44 checks passed

sondermanish deleted the fix/jackson-float branch July 23, 2024 05:22

coderabbitai bot mentioned this pull request Dec 12, 2024

fix: Add custom deserialiser for idPolicies projection #38127

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fixated deserialisation from files to respective types #35103

fix: fixated deserialisation from files to respective types #35103

sondermanish commented Jul 23, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Jul 23, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

nidhi-nair Jul 23, 2024

coderabbitai bot left a comment

fix: fixated deserialisation from files to respective types #35103

fix: fixated deserialisation from files to respective types #35103

Conversation

sondermanish commented Jul 23, 2024 • edited by github-actions bot Loading

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

coderabbitai bot commented Jul 23, 2024 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

nidhi-nair Jul 23, 2024

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

sondermanish commented Jul 23, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Jul 23, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)