perf: add react-hooks/exhaustive-deps rule

[alex-golovanov]

Description

Adds ESLint rule react-hooks/exhaustive-deps with warn level. Context in the task below.

Fixes #34337

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9584250724
Commit: daa7050
Cypress dashboard.
Tags: ``

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Chores
  • Added ESLint rule react-hooks/exhaustive-deps with a severity level of "warn" to enforce exhaustive dependencies in React hooks.

[coderabbitai]

Walkthrough

The change involves adding a new ESLint rule, react-hooks/exhaustive-deps, set to "warn" in the .eslintrc.base.json configuration file. This ensures that developers receive warnings when React hook dependencies are not exhaustive, promoting more predictable and reliable UI behavior.

Changes

File	Change Summary
app/client/.eslintrc.base.json	Introduced react-hooks/exhaustive-deps rule with a severity of "warn".

Assessment against linked issues

Objective	Addressed	Explanation
Add react-hooks/exhaustive-deps rule with warn level (#34337)	✅

Poem

Amidst the code, a rabbit wise 🐇,
Adds rules to make the linter rise,
To warn the devs of hooks forsaken,
Ensuring that no glitch is taken.
With warnings now our code will gleam,
A smoother app, our common dream. 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

app/client/.eslintrc.base.json (1)

58-58: The addition of the react-hooks/exhaustive-deps rule set to "warn" is a strategic choice to improve code reliability without breaking builds. Monitor the impact on developer workflows and consider escalating to an error level in future based on compliance.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3637246 and 4cf8d80.

Files selected for processing (1)

• app/client/.eslintrc.base.json (1 hunks)

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4cf8d80 and edcf57e.

Files selected for processing (1)

• app/client/.eslintrc.base.json (3 hunks)

Files skipped from review as they are similar to previous changes (1)

• app/client/.eslintrc.base.json

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between edcf57e and daa7050.

Files selected for processing (1)

• app/client/.eslintrc.base.json (3 hunks)

Files skipped from review as they are similar to previous changes (1)

• app/client/.eslintrc.base.json