Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Widget names binding in the building block's queries #34230

Closed
wants to merge 4 commits into from
Closed

fix: Widget names binding in the building block's queries #34230

wants to merge 4 commits into from

Conversation

rahulbarwal
Copy link
Contributor

@rahulbarwal rahulbarwal commented Jun 13, 2024 •
edited
Loading

Description

This pull request adds new properties to the ImportBuildingBlockToApplicationResponse interface. The new properties include newActionList, actionCollectionList, datasourceList, and customJSLibList. These properties are used to store additional data related to the import of building blocks to an application.

Add APPEND_ACTION_AFTER_BUILDING_BLOCK_DROP action type and handler

This pull request adds a new action type and handler for APPEND_ACTION_AFTER_BUILDING_BLOCK_DROP. This action type is used to append an action after a building block is dropped in the application. The handler function updates the Redux store with the new action and saves it via an API call.

Refactor ActionSagas: Reorganize imports and extract apiCallToSaveAction function for better modularity and readability.

This pull request refactors the ActionSagas file by reorganizing imports and extracting the apiCallToSaveAction function. This improves modularity and readability of the code.

Add handling for newly added actions in BuildingBlockAdditionSagas

Fixes #34237
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

@rahulbarwal
Add new properties to ImportBuildingBlockToApplicationResponse interface
97ec892
@rahulbarwal
Add APPEND_ACTION_AFTER_BUILDING_BLOCK_DROP action type and handler
44fce58
@rahulbarwal
Refactor ActionSagas: Reorganize imports and extract apiCallToSaveAct…
182c8c5 
…ion function for better modularity and readability.
@rahulbarwal
Add handling for newly added actions in BuildingBlockAdditionSagas
efeba82 
- Import necessary action types and selectors
- Extract actions from API response and pass to pasteBuildingBlockWidgetsSaga
- Update widget names in new queries
- Add newly added actions to Redux store and save via API call
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 13, 2024 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Bug Something isn't working label Jun 13, 2024
@rahulbarwal rahulbarwal self-assigned this Jun 13, 2024
@rahulbarwal rahulbarwal added Templates Product Issues related to Templates Building blocks Building blocks on cavas, on templates listing or drag and drop of building blocks. and removed Bug Something isn't working labels Jun 13, 2024
@github-actions github-actions bot added the Bug Something isn't working label Jun 13, 2024
@github-actions GitHub Actions
Copy link

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Jun 24, 2024
@rahulbarwal
Copy link
Contributor Author

This PR is no longer needed as its changes are accomodated here: #34248

@Nikhil-Nandagopal Nikhil-Nandagopal added the Accelerators Product Issues related to app building accelerators label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushpahwa ayushpahwa Awaiting requested review from ayushpahwa ayushpahwa will be requested when the pull request is marked ready for review ayushpahwa is a code owner

Assignees

@rahulbarwal rahulbarwal

Labels
Accelerators Product Issues related to app building accelerators Bug Something isn't working Building blocks Building blocks on cavas, on templates listing or drag and drop of building blocks. Stale Templates Product Issues related to Templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Widget bindings are not getting updated in Queries.
2 participants
@rahulbarwal @Nikhil-Nandagopal