chore: remove cypress hardcoded strings and waits

[ayushpahwa]

Description

Removed some hardcoded strings and static waits

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.JS, @tag.Git"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9107889730
Commit: 9afff27
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

[coderabbitai]

Walkthrough

Walkthrough

The recent updates involve code style adjustments and minor functional refinements across several Cypress test files. Key changes include removing spaces between function keywords and parentheses in test descriptions, renaming entities, and updating parameters passed to functions. Additionally, the RemoveUIElement method now uses dynamic messages from Cypress.env, and network status assertions have been refined.

Changes

Files	Change Summary
.../e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js	Removed spaces between function keywords and parentheses in test descriptions; renamed entities.
.../e2e/Regression/ClientSide/OtherUIFeatures/Replay_Editor_spec.js	Removed space before function parentheses in describe; updated RemoveUIElement call argument.
.../support/Pages/ApiPage.ts	Updated RemoveUIElement method to use dynamic messages from Cypress.env; refined network status assertion in CreateApi.
.../support/Pages/JSEditor.ts	Updated RemoveUIElement method to pass dynamic messages from Cypress.env.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between affbceb and 9afff27.

Files selected for processing (2)

• app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js (1 hunks)
• app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/Replay_Editor_spec.js (1 hunks)

Files skipped from review as they are similar to previous changes (2)

• app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js
• app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/Replay_Editor_spec.js

Additional Context Used

Learnings (1)

Common

User: Aishwarya-U-R
PR: appsmithorg/appsmith#29405
File: app/client/cypress/e2e/Regression/ClientSide/Binding/TableV2_Widget_API_Pagination_spec.js:37-41
Timestamp: 2023-12-08T08:59:53.560Z
Learning: The pull request titled "test: Cypress | Replace static with Dynamic waits - Part 1" is part of a phased approach where only certain test specifications are targeted for static wait removal in the initial phase. Future phases will address additional specs.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.