chore: WDS table widget polish #33417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughWalkthroughThe updates primarily focus on standardizing button variants and icon positions, refining the primary columns control component, and polishing the WDS table widget. Key adjustments include converting button variant values to uppercase, dynamically setting button variants using Changes
Assessment against linked issues
Recent Review DetailsConfiguration used: CodeRabbit UI CommitsFiles that changed from the base of the PR and between 89ad68289c5a3dbf9af62864b97c6595100e605f and 01e278b.Files selected for processing (36)
Files skipped from review as they are similar to previous changes (36)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
the
skip-changelog
jsartisan
requested review from
a team and
riodeuno
and removed request for
a team
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
|
||
| return ( | ||
| <Link | ||
| color={cellColor === "default" ? undefined : cellColor} | ||
| href={href} | ||
| isBold={isBold} | ||
| isItalic={isItalic} | ||
| lineClamp={lineClamp} | ||
| lineClamp={1} |
There was a problem hiding this comment.
Consider making lineClamp configurable.
To enhance flexibility, consider making the lineClamp value configurable through props instead of hardcoding it to 1.
- lineClamp={1}
+ lineClamp={props.lineClamp || 1}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| lineClamp={1} | |
| lineClamp={props.lineClamp || 1} |
|
|
||
| return ( | ||
| <Text | ||
| color={cellColor === "default" ? undefined : cellColor} | ||
| isBold={isBold} | ||
| isItalic={isItalic} | ||
| lineClamp={lineClamp} | ||
| lineClamp={1} |
There was a problem hiding this comment.
Consider making lineClamp configurable.
To enhance flexibility, consider making the lineClamp value configurable through props instead of hardcoding it to 1.
- lineClamp={1}
+ lineClamp={props.lineClamp || 1}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| lineClamp={1} | |
| lineClamp={props.lineClamp || 1} |
jsartisan
commented
May 15, 2024
| @@ -958,7 +958,11 @@ export class WDSTableWidget extends BaseWidget<TableWidgetProps, WidgetState> { | |||
| } | |||
| selectedRowIndices={this.getSelectedRowIndices()} | |||
| serverSidePaginationEnabled={!!this.props.serverSidePaginationEnabled} | |||
| showConnectDataOverlay={false} | |||
| showConnectDataOverlay={ | |||
There was a problem hiding this comment.
Adding back the connect overlay. I forgot adding it back once i changed the methods config.
Comment on lines
+209
to
+220
| {this.isEditableColumnPresent() && ( | ||
| <EdtiableCheckboxWrapper | ||
| className="flex t--uber-editable-checkbox" | ||
| rightPadding={this.state.hasScrollableList} | ||
| > | ||
| <span className="mr-2">Editable</span> | ||
| <Checkbox | ||
| isSelected={this.isAllColumnsEditable()} | ||
| onChange={this.toggleAllColumnsEditability} | ||
| /> | ||
| </EdtiableCheckboxWrapper> | ||
| )} |
There was a problem hiding this comment.
Typo in class name EdtiableCheckboxWrapper. It should be EditableCheckboxWrapper.
- const EdtiableCheckboxWrapper = styled.div<{ rightPadding: boolean | null }>`
+ const EditableCheckboxWrapper = styled.div<{ rightPadding: boolean | null }>`Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| {this.isEditableColumnPresent() && ( | |
| <EdtiableCheckboxWrapper | |
| className="flex t--uber-editable-checkbox" | |
| rightPadding={this.state.hasScrollableList} | |
| > | |
| <span className="mr-2">Editable</span> | |
| <Checkbox | |
| isSelected={this.isAllColumnsEditable()} | |
| onChange={this.toggleAllColumnsEditability} | |
| /> | |
| </EdtiableCheckboxWrapper> | |
| )} | |
| {this.isEditableColumnPresent() && ( | |
| <EditableCheckboxWrapper | |
| className="flex t--uber-editable-checkbox" | |
| rightPadding={this.state.hasScrollableList} | |
| > | |
| <span className="mr-2">Editable</span> | |
| <Checkbox | |
| isSelected={this.isAllColumnsEditable()} | |
| onChange={this.toggleAllColumnsEditability} | |
| /> | |
| </EditableCheckboxWrapper> | |
| )} |
github-actions
bot
added
Anvil Pod
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9094629545. |
|
Deploy-Preview-URL: https://ce-33417.dp.appsmith.com |
KelvinOm
approved these changes
May 15, 2024
KelvinOm
previously approved these changes
May 15, 2024
jsartisan
added
ok-to-test
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9110969131. |
|
Deploy-Preview-URL: https://ce-33417.dp.appsmith.com |
KelvinOm
previously approved these changes
May 16, 2024
|
Whoops! Looks like you're using an outdated method of running the Cypress suite. |
jsartisan
force-pushed
the
chore/table-widget-polish
branch
from
89ad682 to
01e278b
Compare
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33389
/ok-to-test tags="@tag.Table"
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9112073097
Commit: 89ad68289c5a3dbf9af62864b97c6595100e605f
Cypress dashboard url: Click here!