test: GitSyncedApps_spec - multiple IA changes #33257

ApekshaBhosale · 2024-05-08T06:07:38Z

Description

In this spec, IA changes were required.

table version change --- fix: table version changed for crud #29457
page related functionalities addition and replacement ie clone, hide and show list to assert a page name
replaced as many as possible git related functionalities to gitSync helpers

Link - 9th Spec in https://www.notion.so/appsmith/Cypress-tests-analysis-4090efa5e3064a2e87f262d3c399a339 Phase 1

EE - PR for runs -https://github.com/appsmithorg/appsmith-ee/pull/4140
EE run -- for Git and AccessControl tags https://github.com/appsmithorg/appsmith-ee/actions/runs/9002744046

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

coderabbitai · 2024-05-08T06:07:48Z

Walkthrough

The recent updates aim to enhance the Cypress testing framework for a web application, focusing on consistency, maintainability, and functionality in test script interactions. These changes include method updates, the addition of new constants and helper functions, and modifications to element interaction strategies.

Changes

Files	Change Summary
`.../GitSync/GitSyncedApps_spec.js` & `.../gitSync.js`	Enhanced Git-related test scripts with improved element interaction methods and consistency.
`.../PageList.ts`	Added `HidePage` method to improve page management in tests.
`.../messages.ts` & `.../PagesSection.tsx`	Introduced `PAGE_ENTITY_NAME` constant for consistent entity referencing.

Possibly related issues

[Task]: Fix cypress test suite failures caused by PR #29794 #30378: The enhancements in the Cypress test suite, especially the improved element interaction methods and additional helper functions, could potentially address the failures mentioned due to changes in PR feat: Appsmith AI as datasource plugin #29794. This PR might help in maintaining the test suite's compatibility and effectiveness, aligning with the objectives of resolving identified test failures.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9036a43 and 7d8517d.

Files selected for processing (1)

app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/GitSyncedApps_spec.js (8 hunks)

Files skipped from review as they are similar to previous changes (1)

app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/GitSyncedApps_spec.js

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 2

app/client/cypress/support/Pages/PageList.ts

app/client/cypress/support/gitSync.js

app/client/cypress/support/Pages/PageList.ts

trishaanand · 2024-05-08T08:46:19Z

app/client/cypress/support/Pages/PageList.ts

@@ -15,6 +16,8 @@ class PageList {
    switcher: `.t--pages-switcher`,
  };

+  public DefaultPageName = PAGE_ENTITY_NAME + "1";


Cant you just use getNextEntityName to generate this? Why are we manually setting this up?

@trishaanand i don't think we can do this. i am getting an error regarding dependecy https://github.com/appsmithorg/appsmith-ee/actions/runs/9000139783/job/24724479656

NandanAnantharamu

Rest LGTM except one observation

NandanAnantharamu · 2024-05-09T11:12:40Z

app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/GitSyncedApps_spec.js

-    cy.wait("@getConsolidatedData");
+
+    PageList.ShowList();
+    EditorNavigation.SelectEntityByName(newPage, EntityType.Page);
    cy.get(".t--draggable-inputwidgetv2")


Since you have almost rewitten the test can we make these 2 changes
"inputWidget": ".t--draggable-inputwidgetv2" —> available within Widget.json file
"dataclass": ".bp3-input" —> available in Widget.json file

@NandanAnantharamu sure makes sense! can you share the file please here. i failed to find these

NandanAnantharamu

LGTM

gitsynced spec fixes

a02fd24

github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test labels May 8, 2024

coderabbitai bot reviewed May 8, 2024

View reviewed changes

app/client/cypress/support/Pages/PageList.ts Outdated Show resolved Hide resolved

app/client/cypress/support/gitSync.js Show resolved Hide resolved

ApekshaBhosale requested review from trishaanand and NandanAnantharamu May 8, 2024 06:33

trishaanand reviewed May 8, 2024

View reviewed changes

app/client/cypress/support/Pages/PageList.ts Outdated Show resolved Hide resolved

default page name added

fb27b3b

ApekshaBhosale requested a review from trishaanand May 8, 2024 08:40

trishaanand reviewed May 8, 2024

View reviewed changes

ApekshaBhosale added 5 commits May 8, 2024 14:21

using function to create default value

060a409

reverted the change

54e61a5

Merge branch 'release' into fix-GitSyncedApps_spec

278f9ae

committing changes

278afd4

reverting change

9036a43

ApekshaBhosale requested a review from trishaanand May 9, 2024 10:05

NandanAnantharamu reviewed May 9, 2024

View reviewed changes

PR comment fix

7d8517d

ApekshaBhosale requested a review from NandanAnantharamu May 10, 2024 05:35

NandanAnantharamu approved these changes May 10, 2024

View reviewed changes

trishaanand merged commit d88b431 into release May 10, 2024
13 checks passed

trishaanand deleted the fix-GitSyncedApps_spec branch May 10, 2024 10:04

coderabbitai bot mentioned this pull request Nov 6, 2024

feat: Enable new toolbar for cypress #37148

Merged

2 tasks

coderabbitai bot mentioned this pull request Dec 30, 2024

chore: git mod - test fixes #38357

Merged

2 tasks

coderabbitai bot mentioned this pull request Jan 13, 2025

chore: fixes mergeviaremote_spec flakiness #38635

Merged

2 tasks

coderabbitai bot mentioned this pull request Feb 20, 2025

test: analysing flaky Switch Branch #39302

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: GitSyncedApps_spec - multiple IA changes #33257

test: GitSyncedApps_spec - multiple IA changes #33257

ApekshaBhosale commented May 8, 2024 •

edited

Loading

coderabbitai bot commented May 8, 2024 •

edited

Loading

Walkthrough

Changes

Possibly related issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

trishaanand May 8, 2024

ApekshaBhosale May 8, 2024

ApekshaBhosale May 8, 2024 •

edited

Loading

trishaanand May 8, 2024

NandanAnantharamu left a comment •

edited

Loading

NandanAnantharamu May 9, 2024

ApekshaBhosale May 9, 2024

NandanAnantharamu left a comment

test: GitSyncedApps_spec - multiple IA changes #33257

test: GitSyncedApps_spec - multiple IA changes #33257

Conversation

ApekshaBhosale commented May 8, 2024 • edited Loading

Description

Automation

🔍 Cypress test results

Communication

coderabbitai bot commented May 8, 2024 • edited Loading

Walkthrough

Changes

Possibly related issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

trishaanand May 8, 2024

Choose a reason for hiding this comment

ApekshaBhosale May 8, 2024

Choose a reason for hiding this comment

ApekshaBhosale May 8, 2024 • edited Loading

Choose a reason for hiding this comment

trishaanand May 8, 2024

Choose a reason for hiding this comment

NandanAnantharamu left a comment • edited Loading

Choose a reason for hiding this comment

NandanAnantharamu May 9, 2024

Choose a reason for hiding this comment

ApekshaBhosale May 9, 2024

Choose a reason for hiding this comment

NandanAnantharamu left a comment

Choose a reason for hiding this comment

ApekshaBhosale commented May 8, 2024 •

edited

Loading

coderabbitai bot commented May 8, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

ApekshaBhosale May 8, 2024 •

edited

Loading

NandanAnantharamu left a comment •

edited

Loading