chore: New Theme Settings Integration #29848

jsartisan · 2023-12-26T05:41:16Z

Summary by CodeRabbit

Refactor
- Renamed theme configuration property for consistency and clarity within the app's theme settings feature.

coderabbitai · 2023-12-26T05:41:23Z

Walkthrough

The changes involve a systematic renaming of the term themeSetting to themeSettings to align with the backend API changes for new theme settings. This refactor impacts various components of the application, including API calls, Redux action constants, reducers, selectors, and UI components, ensuring consistency with the updated nomenclature and functionality related to the theme settings panel.

Changes

File Path	Change Summary
`.../src/ce/api/ApplicationApi.tsx` `.../src/ce/constants/ReduxActionConstants.tsx` `.../src/ce/reducers/uiReducers/applicationsReducer.tsx` `.../src/ce/sagas/ApplicationSagas.tsx` `.../src/ce/selectors/applicationSelectors.tsx` `.../src/constants/AppConstants.ts`	Renamed `themeSetting` to `themeSettings` across various files related to API, Redux constants, reducers, sagas, selectors, and constants.
`.../src/pages/Editor/WDSThemePropertyPane/index.tsx`	Updated the property name from `themeSetting` to `themeSettings` in `WDSThemePropertyPane`.

Assessment against linked issues

Objective	Addressed	Explanation
Integration with new theme settings API (#29262)	✅	The renaming of `themeSetting` to `themeSettings` across multiple files suggests that the code has been refactored to integrate with the new theme settings API, aligning with the objective in the issue.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat with CodeRabbit Bot (`@coderabbitai`)

You can directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
- @coderabbitai generate unit tests for this file
- @coderabbitai modularize this function
You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
- @coderabbitai gather interesting statistics about this repository and render them in a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai generate unit tests for the src/utils.ts file.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

jsartisan · 2023-12-26T05:41:43Z

/build-deploy-preview

github-actions · 2023-12-26T05:42:09Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/7326973269.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 29848.
recreate: .

coderabbitai · 2023-12-26T05:44:50Z

app/client/src/ce/sagas/ApplicationSagas.tsx

+        if (request.applicationDetail?.themeSettings) {
          yield put(
            updateApplicationThemeSettingAction(
-              request.applicationDetail?.themeSetting,
+              request.applicationDetail?.themeSettings,
            ),
          );
        }


💡 NOTE
Codebase verification is a beta feature.

Occurrences of both themeSetting and themeSettings are present in the codebase. It appears that not all instances of themeSetting were updated to themeSettings. This inconsistency should be addressed to align with the PR's objectives.

Analysis chain

The renaming from themeSetting to themeSettings in the updateApplicationSaga should be verified across the entire codebase to ensure consistency and that all references to the old term have been updated.

Scripts Executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash # Search for any remaining occurrences of the old term 'themeSetting'. rg --type tsx 'themeSetting' # Ensure the new term 'themeSettings' is used consistently. rg --type tsx 'themeSettings'

Length of output: 114

Script:

#!/bin/bash # Search for any remaining occurrences of the old term 'themeSetting' without specifying file type. rg 'themeSetting' # Ensure the new term 'themeSettings' is used consistently without specifying file type. rg 'themeSettings'

Length of output: 3428

…theme-settings-integration

jsartisan · 2023-12-26T07:31:38Z

/build-deploy-preview skip-tests=true

github-actions · 2023-12-26T07:31:59Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/7327614246.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 29848.
recreate: .

github-actions · 2023-12-26T07:43:13Z

Deploy-Preview-URL: https://ce-29848.dp.appsmith.com

AnaghHegde · 2023-12-27T11:26:32Z

/build-deploy-preview skip-tests=true

github-actions · 2023-12-27T11:26:57Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/7337856893.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 29848.
recreate: .

github-actions · 2023-12-27T11:37:02Z

Deploy-Preview-URL: https://ce-29848.dp.appsmith.com

jsartisan · 2023-12-27T11:52:19Z

/build-deploy-preview skip-tests=true

github-actions · 2023-12-27T11:52:43Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/7338018197.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 29848.
recreate: .

jsartisan · 2023-12-27T12:02:19Z

/ok-to-test

github-actions · 2023-12-27T12:02:41Z

The provided command lacks any tags. Please execute '/ok-to-test' again, specifying the tags you want to include or use @tag.All to run all specs.
Explore the tags documentation here

github-actions · 2023-12-27T12:03:05Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7338080285.
Commit: ``.
Cypress dashboard url: Click here!
It seems like there are some failures 😔. We are not able to recognize it, please check this manually here.

github-actions · 2023-12-27T12:04:55Z

Deploy-Preview-URL: https://ce-29848.dp.appsmith.com

KelvinOm · 2023-12-27T12:36:31Z

app/client/src/ce/selectors/applicationSelectors.tsx

-    state.ui.applications.currentApplication?.applicationDetail?.themeSetting ||
-    defaultThemeSetting
-  );
+  return {


Why do we need these changes?

Just making sure we spread out the theme setting that we get from the backend over the default settings. Previously it was like "If the backend has themeSettings, use that, otherwise use default Settings"

jsartisan · 2023-12-28T05:44:01Z

/ok-to-test tags="@tag.Widget, @tag.Settings, @tag.PropertyPane, @tag.Theme"

github-actions · 2023-12-28T05:44:27Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7344841310.
Workflow: Appsmith External Integration Test Workflow.
Tags: @tag.Widget, @tag.Settings, @tag.PropertyPane, @tag.Theme.

github-actions · 2023-12-28T06:45:40Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7344841310.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

jsartisan added 2 commits December 18, 2023 17:00

change themeSetting to themeSettings

2e3a570

change themeSetting to themeSettings

9b374c0

jsartisan requested a review from ayushpahwa as a code owner December 26, 2023 05:41

github-actions bot added WDS team Anvil Pod Issue related to Anvil project labels Dec 26, 2023

jsartisan changed the title ~~chore: New Settings Integration~~ chore: New Theme Settings Integration Dec 26, 2023

github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Dec 26, 2023

coderabbitai bot reviewed Dec 26, 2023

View reviewed changes

Merge branch 'release' of github.com:appsmithorg/appsmith into chore/…

ba3cac6

…theme-settings-integration

jsartisan added 2 commits December 27, 2023 16:16

change themeSettings to themeSetting

8388576

change case of colorMode

85ddbac

jsartisan requested review from a team and prsidhu and removed request for a team December 27, 2023 11:20

fix view mode

7b7bbce

jsartisan requested review from a team, sbalaji1192 and KelvinOm and removed request for a team December 27, 2023 11:50

KelvinOm approved these changes Dec 27, 2023

View reviewed changes

jsartisan merged commit 0128ef6 into release Dec 28, 2023
12 checks passed

jsartisan deleted the chore/theme-settings-integration branch December 28, 2023 08:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: New Theme Settings Integration #29848

chore: New Theme Settings Integration #29848

jsartisan commented Dec 26, 2023 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 26, 2023 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

jsartisan commented Dec 26, 2023

github-actions bot commented Dec 26, 2023

coderabbitai bot Dec 26, 2023

jsartisan commented Dec 26, 2023

github-actions bot commented Dec 26, 2023

github-actions bot commented Dec 26, 2023

AnaghHegde commented Dec 27, 2023

github-actions bot commented Dec 27, 2023

github-actions bot commented Dec 27, 2023

jsartisan commented Dec 27, 2023

github-actions bot commented Dec 27, 2023

jsartisan commented Dec 27, 2023

github-actions bot commented Dec 27, 2023

github-actions bot commented Dec 27, 2023

github-actions bot commented Dec 27, 2023

KelvinOm Dec 27, 2023

jsartisan Dec 28, 2023

jsartisan commented Dec 28, 2023

github-actions bot commented Dec 28, 2023

github-actions bot commented Dec 28, 2023

chore: New Theme Settings Integration #29848

chore: New Theme Settings Integration #29848

Conversation

jsartisan commented Dec 26, 2023 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Dec 26, 2023 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Chat with CodeRabbit Bot (@coderabbitai)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

jsartisan commented Dec 26, 2023

github-actions bot commented Dec 26, 2023

coderabbitai bot Dec 26, 2023

Choose a reason for hiding this comment

jsartisan commented Dec 26, 2023

github-actions bot commented Dec 26, 2023

github-actions bot commented Dec 26, 2023

AnaghHegde commented Dec 27, 2023

github-actions bot commented Dec 27, 2023

github-actions bot commented Dec 27, 2023

jsartisan commented Dec 27, 2023

github-actions bot commented Dec 27, 2023

jsartisan commented Dec 27, 2023

github-actions bot commented Dec 27, 2023

github-actions bot commented Dec 27, 2023

github-actions bot commented Dec 27, 2023

KelvinOm Dec 27, 2023

Choose a reason for hiding this comment

jsartisan Dec 28, 2023

Choose a reason for hiding this comment

jsartisan commented Dec 28, 2023

github-actions bot commented Dec 28, 2023

github-actions bot commented Dec 28, 2023

jsartisan commented Dec 26, 2023 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 26, 2023 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Configration File (`.coderabbit.yaml`)