Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Split widget reducers #39326

Closed
ashit-rath opened this issue Feb 18, 2025 · 0 comments · Fixed by #39327
Closed

[Task] Split widget reducers #39326

ashit-rath opened this issue Feb 18, 2025 · 0 comments · Fixed by #39327
Assignees
@ashit-rath
Labels
Frontend This label marks the issue or pull request to reference client code Packages & Git Pod All issues belonging to Packages and Git Packages Pod issues that belong to the packages pod Task A simple Todo

Comments

@ashit-rath
Copy link
Contributor

ashit-rath commented Feb 18, 2025 •
edited
Loading

Split canvasWidgetsReducer and canvasWidgetsStructureReducer into CE-EE.
This will be used for UI modules
@ashit-rath ashit-rath added the Packages & Git Pod All issues belonging to Packages and Git label Feb 18, 2025
@ashit-rath ashit-rath self-assigned this Feb 18, 2025
@github-actions github-actions bot removed the Packages & Git Pod All issues belonging to Packages and Git label Feb 18, 2025
@ashit-rath ashit-rath added Frontend This label marks the issue or pull request to reference client code Task A simple Todo Packages Pod issues that belong to the packages pod Packages & Git Pod All issues belonging to Packages and Git labels Feb 18, 2025
@ashit-rath ashit-rath mentioned this issue Feb 18, 2025
Merged
2 tasks
ashit-rath added a commit that referenced this issue Feb 18, 2025
@ashit-rath
chore: Split canvas widget reducers (#39327)
88d3599 
## Description
Split canvasWidgetsReducer and canvasWidgetsStructureReducer for UI
modules

Fixes #39326

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13385385883>
> Commit: ec13bb0
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13385385883&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Tue, 18 Feb 2025 08:41:34 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Streamlined internal dependency management and reorganized module
paths for improved maintainability.
- Updated import paths for `CanvasWidgetsReduxState`,
`FlattenedWidgetProps`, and related types to reflect a new
organizational structure.
- These behind-the-scenes changes do not affect any user-visible
functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashit-rath ashit-rath

Labels
Frontend This label marks the issue or pull request to reference client code Packages & Git Pod All issues belonging to Packages and Git Packages Pod issues that belong to the packages pod Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Split canvas widget reducers appsmithorg/appsmith
1 participant
@ashit-rath