Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Chart widget should adopt the font from the theme settings. #38776

Closed
1 task done
rahulbarwal opened this issue Jan 20, 2025 · 0 comments · Fixed by #38777
Closed
1 task done

[Bug]: Chart widget should adopt the font from the theme settings. #38776

rahulbarwal opened this issue Jan 20, 2025 · 0 comments · Fixed by #38777
Assignees
@rahulbarwal
Labels
Bug Something isn't working Chart Widget Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production QA Needs QA attention Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets

Comments

@rahulbarwal
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

Chart widget does not honour fonts set at app level by user. We want all texts inside chart widget to change according to font set at app level by user.

Steps To Reproduce

  1. Drag and drop a chart widget.
  2. Go to settings page > Theme > Font.
  3. Change the font and notice that texts inside chart widgets don't change.

Public Sample App

No response

Environment

Production

Severity

Low (Cosmetic UI issues)

Issue video log

No response

Version

v1.57
@rahulbarwal rahulbarwal added Bug Something isn't working Chart Widget Needs Triaging Needs attention from maintainers to triage labels Jan 20, 2025
@rahulbarwal rahulbarwal self-assigned this Jan 20, 2025
@Nikhil-Nandagopal Nikhil-Nandagopal added Low An issue that is neither critical nor breaks a user flow Production labels Jan 20, 2025
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets Widgets & Accelerators Pod Issues related to widgets & Accelerators labels Jan 20, 2025
devin-ai-integration bot added a commit that referenced this issue Jan 20, 2025
@devin-ai-integration @rahulbarwal
fix: Chart widget uses theme font from this.props.fontFamily (#38776)
6104a34 
Co-Authored-By: [email protected] <[email protected]>
@rahulbarwal rahulbarwal mentioned this issue Jan 21, 2025
Merged
@appsmith-bot appsmith-bot added the QA Needs QA attention label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahulbarwal rahulbarwal

Labels
Bug Something isn't working Chart Widget Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production QA Needs QA attention Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Chart widget respects theme font appsmithorg/appsmith
3 participants
@Nikhil-Nandagopal @rahulbarwal @appsmith-bot