Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Show correct error message for when datasource structure is not supported for zendesk #38736

Closed
1 task done
sneha122 opened this issue Jan 17, 2025 · 0 comments · Fixed by #38795
Closed
1 task done

[Bug]: Show correct error message for when datasource structure is not supported for zendesk #38736

sneha122 opened this issue Jan 17, 2025 · 0 comments · Fixed by #38795
Assignees
@sneha122
Labels
Bug Something isn't working Deploy Preview Issues found in Deploy Preview Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Integrations Product Issues related to a specific integration Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage QA Needs QA attention Query & JS Pod Issues related to the query & JS Pod Query & Widgets Pod All issues related to Query, JS, Eval, and Widgets Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Milestone
Test Party Issues...

Comments

@sneha122
Copy link
Contributor

sneha122 commented Jan 17, 2025 •
edited by NilanshBansal
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Description

Ref: https://www.notion.so/appsmith/No-bottom-spacing-in-the-empty-state-datasource-schema-Also-why-do-we-get-this-error-17afe271b0e280aa9520ddfbc64107ab
Datasource structure is not valid for zendesk as it's not relational DB, Show appropriate message in response tab, currently it shows:

Image Image

Steps To Reproduce

  1. Create zendesk datasource
  2. Create query
  3. check the response tab for ds structure

Public Sample App

No response

Environment

Deploy Preview

Severity

Low (Cosmetic UI issues)

Issue video log

No response

Version

NA
@sneha122 sneha122 added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage labels Jan 17, 2025
@Nikhil-Nandagopal Nikhil-Nandagopal added Deploy Preview Issues found in Deploy Preview Low An issue that is neither critical nor breaks a user flow labels Jan 17, 2025
@NilanshBansal NilanshBansal added Query & JS Pod Issues related to the query & JS Pod Integrations Product Issues related to a specific integration Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod labels Jan 17, 2025
@sneha122 sneha122 mentioned this issue Jan 22, 2025
Merged
2 tasks
@carinanfonseca carinanfonseca added the Query & Widgets Pod All issues related to Query, JS, Eval, and Widgets label Jan 22, 2025
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets Widgets & Accelerators Pod Issues related to widgets & Accelerators labels Jan 22, 2025
@appsmith-bot appsmith-bot added the QA Needs QA attention label Jan 22, 2025
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Feb 7, 2025
@sneha122
fix: ds structure issue fixed for zendesk integration (appsmithorg#38795
5a2ac42 
)

## Description
This PR fixes the issue where for Saas integrations like zendesk, we do
not have a structure to be displayed, in that case we should show
appropriate error message.


Fixes appsmithorg#38736 
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12907027118>
> Commit: 5a9ef72
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12907027118&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Wed, 22 Jan 2025 12:24:10 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
	- Deprecated the previous method for retrieving datasource context.
- Updated the datasource context retrieval process to include plugin
information.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: “sneha122” <“[email protected]”>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sneha122 sneha122

Labels
Bug Something isn't working Deploy Preview Issues found in Deploy Preview Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Integrations Product Issues related to a specific integration Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage QA Needs QA attention Query & JS Pod Issues related to the query & JS Pod Query & Widgets Pod All issues related to Query, JS, Eval, and Widgets Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
Test Party Issues - Zendesk and Sales...
Development

Successfully merging a pull request may close this issue.

fix: ds structure issue fixed for zendesk integration appsmithorg/appsmith
7 participants
@nerbos @Nikhil-Nandagopal @pranavkanade @NilanshBansal @sneha122 @appsmith-bot @carinanfonseca