Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Git pkg - API contracts #38500

Closed
brayn003 opened this issue Jan 6, 2025 · 0 comments · Fixed by #38681
Closed

[Task] Git pkg - API contracts #38500

brayn003 opened this issue Jan 6, 2025 · 0 comments · Fixed by #38681
Assignees
@brayn003
Labels
Git Product Issues related to version control product Packages & Git Pod All issues belonging to Packages and Git Task A simple Todo

Comments

@brayn003
Copy link
Contributor

brayn003 commented Jan 6, 2025 •
edited
Loading

Introduce new API contracts for Git
https://www.notion.so/appsmith/GIT-Application-contract-166fe271b0e28028a3e9c7922daf887d
@brayn003 brayn003 added the Packages & Git Pod All issues belonging to Packages and Git label Jan 6, 2025
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Jan 6, 2025
@github-actions github-actions bot removed the Packages & Git Pod All issues belonging to Packages and Git label Jan 6, 2025
@brayn003 brayn003 self-assigned this Jan 6, 2025
@brayn003 brayn003 added the Git Product Issues related to version control product label Jan 6, 2025
@github-actions github-actions bot added the Packages & Git Pod All issues belonging to Packages and Git label Jan 6, 2025
@brayn003 brayn003 mentioned this issue Jan 15, 2025
Merged
2 tasks
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Feb 7, 2025
@brayn003
chore: git api - adding new apis (appsmithorg#38681)
186d91f 
## Description
- Introduces new api contracts for git
- Adds feature flag `release_git_api_contracts_enabled`


Fixes appsmithorg#38500

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12810595516>
> Commit: 8f05bbf
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12810595516&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Thu, 16 Jan 2025 15:05:20 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
    - Introduced a new feature flag `release_git_api_contracts_enabled`
    - Added support for enhanced Git API contract handling

- **Improvements**
    - Updated type definitions for Git-related operations
    - Refined request and response handling for Git artifacts
    - Improved type safety for Git references and branches

- **Changes**
- Modified several Git-related request and saga functions to support new
API contracts
    - Updated artifact type enum values to use lowercase representations
    - Introduced new interfaces for Git references and branches

- **Technical Updates**
    - Added conditional logic for feature flag-based request processing
    - Restructured type definitions across multiple Git-related modules
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brayn003 brayn003

Labels
Git Product Issues related to version control product Packages & Git Pod All issues belonging to Packages and Git Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: git api - adding new apis appsmithorg/appsmith
2 participants
@Nikhil-Nandagopal @brayn003