Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Group listing of entity items in Data side pane #38290

Closed
3 tasks done
Tracked by #37342
ankitakinger opened this issue Dec 20, 2024 · 1 comment · Fixed by #38621
Closed
3 tasks done
Tracked by #37342

Replace Group listing of entity items in Data side pane #38290

ankitakinger opened this issue Dec 20, 2024 · 1 comment · Fixed by #38621
Assignees
@ankitakinger
Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Low An issue that is neither critical nor breaks a user flow Task A simple Todo

Comments

@ankitakinger
Copy link
Contributor

ankitakinger commented Dec 20, 2024 •
edited
Loading

  • Replace existing implementation with the EntityGroupedList component in ADS
  • Retain the test ids to not break any unit or integration tests
  • Also, update the same on State inspector.
Screenshot 2024-12-27 at 5 50 50 PM
@ankitakinger ankitakinger mentioned this issue Dec 20, 2024
Open
1 task
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Dec 20, 2024
@ankitakinger ankitakinger added IDE Product Issues related to the IDE Product IDE Pod Issues that new developers face while exploring the IDE Low An issue that is neither critical nor breaks a user flow labels Dec 20, 2024
@ankitakinger
Copy link
Contributor Author

Hey team! Please add your planning poker estimate with Zenhub @alex-golovanov @hetunandu

@ankitakinger ankitakinger self-assigned this Jan 10, 2025
@ankitakinger ankitakinger mentioned this issue Jan 13, 2025
Merged
2 tasks
ankitakinger added a commit that referenced this issue Jan 14, 2025
@ankitakinger
chore: Replacing the entity group list component on state inspector a…
d187854 
…nd data side pane with new ADS component (#38621)

## Description

Replacing the entity group list component on state inspector and data
side pane with new ADS component

Fixes [#38290](#38290)

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12763738469>
> Commit: a4b7172
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12763738469&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource`
> Spec:
> <hr>Tue, 14 Jan 2025 09:50:48 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
  - Enhanced list item styling with configurable height.
  - Added support for dynamic item count in entity groups.
  - Improved icon rendering with customizable dimensions.
  - Introduced a new constant for default group list size.

- **Improvements**
  - Simplified rendering of grouped items in various components.
  - Refined type safety for boolean assignments.
  - Updated state management for entity groups.
  - Enhanced control over item visibility in modals and lists.

- **Technical Updates**
  - Introduced new data attributes for enhanced component interactions.
  - Modernized component rendering logic.
- Replaced custom styled list with a dedicated `EntityGroupsList`
component for better maintainability.
- Expanded story examples for the `ListItem` component to showcase
various configurations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Feb 7, 2025
@ankitakinger
chore: Replacing the entity group list component on state inspector a…
1ebbbaf 
…nd data side pane with new ADS component (appsmithorg#38621)

## Description

Replacing the entity group list component on state inspector and data
side pane with new ADS component

Fixes [appsmithorg#38290](appsmithorg#38290)

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12763738469>
> Commit: a4b7172
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12763738469&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource`
> Spec:
> <hr>Tue, 14 Jan 2025 09:50:48 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
  - Enhanced list item styling with configurable height.
  - Added support for dynamic item count in entity groups.
  - Improved icon rendering with customizable dimensions.
  - Introduced a new constant for default group list size.

- **Improvements**
  - Simplified rendering of grouped items in various components.
  - Refined type safety for boolean assignments.
  - Updated state management for entity groups.
  - Enhanced control over item visibility in modals and lists.

- **Technical Updates**
  - Introduced new data attributes for enhanced component interactions.
  - Modernized component rendering logic.
- Replaced custom styled list with a dedicated `EntityGroupsList`
component for better maintainability.
- Expanded story examples for the `ListItem` component to showcase
various configurations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankitakinger ankitakinger

Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Low An issue that is neither critical nor breaks a user flow Task A simple Todo
Projects
None yet
Milestone
No milestone
2 participants
@Nikhil-Nandagopal @ankitakinger