Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Navigation between Jsobjects not working properly #38216

Closed
1 task done
NandanAnantharamu opened this issue Dec 18, 2024 · 4 comments · Fixed by #38247 or #38272
Closed
1 task done

[Bug]: Navigation between Jsobjects not working properly #38216

NandanAnantharamu opened this issue Dec 18, 2024 · 4 comments · Fixed by #38247 or #38272
Assignees
Labels
Bug Something isn't working Community Reported issues reported by community members IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production Verified When issue is retested post its fixed

Comments

@NandanAnantharamu
Copy link
Collaborator

NandanAnantharamu commented Dec 18, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Description

When we have multiple pages with each having different jsobjects. If we try to navigate between jsobjects in one page its taking user to different page incorrectly

Steps To Reproduce

1.Mantain 3 pages with 5 jsobjects in each with different name
2.Select a page and randomly click on different jsobjects.

Expected:
It should go to the clicked jsobject

Actual:
Its randomly navigating to different jsobject in different page.

Screen.Recording.2024-12-17.at.6.35.17.PM.mov

Public Sample App

No response

Environment

Production

Severity

Medium (Frustrating UX)

Issue video log

No response

Version

v1.53

@NandanAnantharamu NandanAnantharamu added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage labels Dec 18, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Community Reported issues reported by community members Medium Issues that frustrate users due to poor UX Production labels Dec 18, 2024
@shadabbuchh shadabbuchh added the IDE Navigation Issues/feature requests related to IDE navigation, and context switching label Dec 18, 2024
@github-actions github-actions bot added IDE Product Issues related to the IDE Product IDE Pod Issues that new developers face while exploring the IDE labels Dec 18, 2024
@shadabbuchh
Copy link
Contributor

This is not restricted to JS Objects. This can be seen for all queries:
https://jam.dev/c/cd6fe922-f574-4202-87b3-41b4225696ee

@hetunandu
Copy link
Member

This is a major bug and should have been impossible to be skip past our test cases. Can you share when did this started happening? The Version mentioned is 1.42 which is quite old

@NandanAnantharamu

@NandanAnantharamu
Copy link
Collaborator Author

This is a major bug and should have been impossible to be skip past our test cases. Can you share when did this started happening? The Version mentioned is 1.42 which is quite old

@NandanAnantharamu

@hetunandu issue seen on version v1.53

@shadabbuchh
Copy link
Contributor

Verified on release to be working fine. Thanks.
https://jam.dev/c/c3e49bc4-f145-47b8-8f34-79dc793c8424

@shadabbuchh shadabbuchh added Verified When issue is retested post its fixed and removed QA Needs QA attention labels Dec 23, 2024
@github-actions github-actions bot removed the QA Pod Issues under the QA Pod label Dec 23, 2024
NandanAnantharamu pushed a commit that referenced this issue Dec 27, 2024
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #38216

## Automation

/ok-to-test tags="@tag.Git, @tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12406790663>
> Commit: 194f2ec
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12406790663&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git, @tag.IDE`
> Spec:
> <hr>Thu, 19 Dec 2024 06:19:57 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced navigation management in the editor for improved user
experience.
	- Streamlined retrieval of the base entity ID for navigation purposes.

- **Bug Fixes**
- Improved consistency in widget selection behavior based on current
focus entity and keyboard events.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Feb 7, 2025
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes appsmithorg#38216

## Automation

/ok-to-test tags="@tag.Git, @tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12406790663>
> Commit: 194f2ec
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12406790663&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git, @tag.IDE`
> Spec:
> <hr>Thu, 19 Dec 2024 06:19:57 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced navigation management in the editor for improved user
experience.
	- Streamlined retrieval of the base entity ID for navigation purposes.

- **Bug Fixes**
- Improved consistency in widget selection behavior based on current
focus entity and keyboard events.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Community Reported issues reported by community members IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production Verified When issue is retested post its fixed
Projects
None yet
8 participants