Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract side by side control out of editor tabs (Right control) #37690

Closed
2 tasks
Tracked by #37342
ankitakinger opened this issue Nov 25, 2024 · 1 comment · Fixed by #38833
Closed
2 tasks
Tracked by #37342

Extract side by side control out of editor tabs (Right control) #37690

ankitakinger opened this issue Nov 25, 2024 · 1 comment · Fixed by #38833
Assignees
@ankitakinger
Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo

Comments

@ankitakinger
Copy link
Contributor

ankitakinger commented Nov 25, 2024 •
edited
Loading

  • Extract out the right control in section header component and the new component will now accept rightControl as any ReactNode, to allow some IDEs to not use the side by side mode by keeping the right control as null and showing no icon for switching between side by side and full screen. (Navigation & nudge may be different and needs local storage use)
  • This task should take care of logic and functionality of this right control, when present.
Screenshot 2024-12-27 at 6 29 24 PM
@ankitakinger ankitakinger mentioned this issue Nov 25, 2024
Open
1 task
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Nov 25, 2024
@ankitakinger ankitakinger added IDE Product Issues related to the IDE Product IDE Pod Issues that new developers face while exploring the IDE labels Nov 25, 2024
@ankitakinger
Copy link
Contributor Author

Hey team! Please add your planning poker estimate with Zenhub @alex-golovanov @hetunandu

@ankitakinger ankitakinger mentioned this issue Jan 24, 2025
Merged
2 tasks
ankitakinger added a commit that referenced this issue Jan 24, 2025
@ankitakinger
chore: Extracting out showNudge config from screen mode toggle comp…
c814353 
…onent (#38833)

## Description

Extracting out `showNudge` config from screen mode toggle component to
make this component re-usable in other IDEs.

Fixes [#37690](#37690)

## Automation

/ok-to-test tags="@tag.Sanity, @tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12948269268>
> Commit: 1a30130
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12948269268&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity, @tag.IDE`
> Spec:
> <hr>Fri, 24 Jan 2025 11:40:32 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new nudge system for side-by-side view functionality in
the editor.
- Enhanced user guidance with a dismissible nudge for screen mode
switching.

- **Improvements**
	- Refined state management for screen mode toggle by utilizing props.
- Improved component prop handling for better flexibility and
interactivity.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Feb 7, 2025
@ankitakinger
chore: Extracting out showNudge config from screen mode toggle comp…
c99e143 
…onent (appsmithorg#38833)

## Description

Extracting out `showNudge` config from screen mode toggle component to
make this component re-usable in other IDEs.

Fixes [appsmithorg#37690](appsmithorg#37690)

## Automation

/ok-to-test tags="@tag.Sanity, @tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12948269268>
> Commit: 1a30130
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12948269268&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity, @tag.IDE`
> Spec:
> <hr>Fri, 24 Jan 2025 11:40:32 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new nudge system for side-by-side view functionality in
the editor.
- Enhanced user guidance with a dismissible nudge for screen mode
switching.

- **Improvements**
	- Refined state management for screen mode toggle by utilizing props.
- Improved component prop handling for better flexibility and
interactivity.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankitakinger ankitakinger

Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Extracting out showNudge config from screen mode toggle component appsmithorg/appsmith
3 participants
@alex-golovanov @Nikhil-Nandagopal @ankitakinger