Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move editable tab component and functionality to ADS #37649

Closed
Tracked by #37342
ankitakinger opened this issue Nov 22, 2024 · 1 comment · Fixed by #38788
Closed
Tracked by #37342

Move editable tab component and functionality to ADS #37649

ankitakinger opened this issue Nov 22, 2024 · 1 comment · Fixed by #38788
Assignees
@alex-golovanov
Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo

Comments

@ankitakinger
Copy link
Contributor

ankitakinger commented Nov 22, 2024 •
edited
Loading

Component:
https://github.com/appsmithorg/appsmith/blob/release/app/client/src/pages/Editor/IDE/EditorTabs/EditableTab.tsx

Design:
https://www.figma.com/design/sz08OJt2VrEgxQ8eToFIqG/ADS2.0---Components?node-id=8962-21587&m=dev
@ankitakinger ankitakinger mentioned this issue Nov 22, 2024
Open
1 task
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Nov 22, 2024
@ankitakinger ankitakinger changed the title Abstract navigation for close and add Abstract navigation for close and add (currently it uses pageId for navigation) Nov 25, 2024
@ankitakinger ankitakinger added IDE Product Issues related to the IDE Product IDE Pod Issues that new developers face while exploring the IDE labels Nov 25, 2024
@ankitakinger ankitakinger changed the title Abstract navigation for close and add (currently it uses pageId for navigation) Move editable tab component and functionality to ADS Dec 24, 2024
@ankitakinger ankitakinger reopened this Dec 24, 2024
@hetunandu
Copy link
Member

Hey team! Please add your planning poker estimate with Zenhub @alex-golovanov @ankitakinger

@alex-golovanov alex-golovanov mentioned this issue Jan 21, 2025
Merged
2 tasks
alex-golovanov added a commit that referenced this issue Jan 23, 2025
@alex-golovanov
feat: editable dismissible tab component (#38788)
efceb1e 
## Description
Addition of a template component that combines editable entity name and
dismissible tab.

Fixes #37649  

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12925482595>
> Commit: 23c8fbe
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12925482595&attempt=2&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank">Cypress dashboard</a>.
> Tags: @tag.Sanity
> Spec: 
> The following are new failures, please fix them before merging the PR:
<ol>
>
<li>cypress/e2e/Regression/ClientSide/OtherUIFeatures/GlobalSearch_spec.js</ol>
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">List of identified flaky tests</a>.
> <hr>Thu, 23 Jan 2025 11:42:24 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced `DismissibleTab` component with interactive close and click
functionality.
- Added `EditableEntityName` component for editing entity names with
validation.
- Created `EditableDismissibleTab` component combining dismissible and
editable behaviors.
- Added new Storybook stories for `DismissibleTab`,
`EditableDismissibleTab`, and `EditableEntityName` components.

- **Improvements**
- Enhanced design system with new styled components for better
interactivity and appearance.

- **Refactoring**
	- Reorganized hook and component imports.
- Updated export statements in various files to improve module
accessibility.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Feb 7, 2025
@alex-golovanov
feat: editable dismissible tab component (appsmithorg#38788)
e735a33 
## Description
Addition of a template component that combines editable entity name and
dismissible tab.

Fixes appsmithorg#37649  

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12925482595>
> Commit: 23c8fbe
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12925482595&attempt=2&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank">Cypress dashboard</a>.
> Tags: @tag.Sanity
> Spec: 
> The following are new failures, please fix them before merging the PR:
<ol>
>
<li>cypress/e2e/Regression/ClientSide/OtherUIFeatures/GlobalSearch_spec.js</ol>
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">List of identified flaky tests</a>.
> <hr>Thu, 23 Jan 2025 11:42:24 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced `DismissibleTab` component with interactive close and click
functionality.
- Added `EditableEntityName` component for editing entity names with
validation.
- Created `EditableDismissibleTab` component combining dismissible and
editable behaviors.
- Added new Storybook stories for `DismissibleTab`,
`EditableDismissibleTab`, and `EditableEntityName` components.

- **Improvements**
- Enhanced design system with new styled components for better
interactivity and appearance.

- **Refactoring**
	- Reorganized hook and component imports.
- Updated export statements in various files to improve module
accessibility.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-golovanov alex-golovanov

Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: editable dismissible tab component appsmithorg/appsmith
4 participants
@alex-golovanov @Nikhil-Nandagopal @hetunandu @ankitakinger