Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Incorrect error message is shown in Queries segment when the searched item list is empty #37635

Closed
1 task done
ankitakinger opened this issue Nov 21, 2024 · 0 comments · Fixed by #37636
Closed
1 task done

[Bug]: Incorrect error message is shown in Queries segment when the searched item list is empty #37635

ankitakinger opened this issue Nov 21, 2024 · 0 comments · Fixed by #37636
Assignees
@ankitakinger
Labels
Bug Something isn't working IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention

Comments

@ankitakinger
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

Incorrect error message is shown in Queries segment when the searched item list is empty
Screenshot 2024-11-21 at 5 09 33 PM

Steps To Reproduce

  1. Go to any app editor
  2. Go to Queries segment
  3. Search anything in it and see that when the results are 0, the error message shown is incorrect

Public Sample App

No response

Environment

Production

Severity

Low (Cosmetic UI issues)

Issue video log

No response

Version

Cloud / Self Hosted - latest
@ankitakinger ankitakinger added Bug Something isn't working IDE Product Issues related to the IDE Product Needs Triaging Needs attention from maintainers to triage IDE Pod Issues that new developers face while exploring the IDE labels Nov 21, 2024
@ankitakinger ankitakinger self-assigned this Nov 21, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Low An issue that is neither critical nor breaks a user flow Production labels Nov 21, 2024
@ankitakinger ankitakinger mentioned this issue Nov 21, 2024
Merged
2 tasks
@appsmith-bot appsmith-bot added the QA Needs QA attention label Nov 21, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Nov 21, 2024
github-actions bot pushed a commit that referenced this issue Nov 21, 2024
@ankitakinger
fix: Updating empty state message when searching items in queries seg…
b113cf7 
…ment (#37636)

## Description

Updating empty state message when searching items in queries segment

Fixes [#37635](#37635)

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11953608015>
> Commit: 7cd8517
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11953608015&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 21 Nov 2024 13:34:32 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Updated messaging in the search results for improved clarity when no
queries are found.
  
- **Bug Fixes**
- Corrected the context of the empty search result message from
JavaScript objects to queries.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Nov 27, 2024
@ankitakinger
fix: Updating empty state message when searching items in queries seg…
a42a4c6 
…ment (appsmithorg#37636)

## Description

Updating empty state message when searching items in queries segment

Fixes [appsmithorg#37635](appsmithorg#37635)

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11953608015>
> Commit: 7cd8517
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11953608015&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 21 Nov 2024 13:34:32 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Updated messaging in the search results for improved clarity when no
queries are found.
  
- **Bug Fixes**
- Corrected the context of the empty search result message from
JavaScript objects to queries.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankitakinger ankitakinger

Labels
Bug Something isn't working IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Updating empty state message when searching items in queries segment appsmithorg/appsmith
3 participants
@Nikhil-Nandagopal @ankitakinger @appsmith-bot