Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Add new editable text component for JS modules #36964

Closed
Tracked by #34663
ankitakinger opened this issue Oct 18, 2024 · 0 comments · Fixed by #37056
Closed
Tracked by #34663

[Task]: Add new editable text component for JS modules #36964

ankitakinger opened this issue Oct 18, 2024 · 0 comments · Fixed by #37056
Assignees
@ankitakinger
Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo

Comments

@ankitakinger
Copy link
Contributor

SubTasks

Ref: https://theappsmith.slack.com/archives/C02JT9CSE6L/p1729231275845219
@ankitakinger ankitakinger added IDE Product Issues related to the IDE Product Task A simple Todo IDE Pod Issues that new developers face while exploring the IDE labels Oct 18, 2024
@ankitakinger ankitakinger self-assigned this Oct 18, 2024
@ankitakinger ankitakinger mentioned this issue Oct 18, 2024
Closed
@ankitakinger ankitakinger changed the title [Task]: Add new editable text component for JS modules and JS objects [Task]: Add new editable text component for JS modules Oct 18, 2024
@ankitakinger ankitakinger mentioned this issue Oct 24, 2024
Merged
2 tasks
ankitakinger added a commit that referenced this issue Oct 24, 2024
@ankitakinger
chore: Adding new name editor for JS object in toolbar (#37056)
3d9d08a 
## Description

Adding new name editor for JS object in toolbar under modularised flow.

Fixes [#36964](#36964)

## Automation

/ok-to-test tags="@tag.Sanity, @tag.JS"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11496788011>
> Commit: 7ae7ec7
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11496788011&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity, @tag.JS`
> Spec:
> <hr>Thu, 24 Oct 2024 10:42:17 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new optional name editor in the JSEditor, allowing users
to edit JavaScript object names dynamically.
- Enhanced the JSEditorToolbar to conditionally render the name editor
based on user permissions.

- **Bug Fixes**
- Simplified the props for the JSObjectNameEditor component by removing
unnecessary properties.

- **Documentation**
- Updated export statements to ensure accessibility of the new
JSObjectNameEditor component across modules.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Nov 20, 2024
@ankitakinger
chore: Adding new name editor for JS object in toolbar (appsmithorg#3…
4cf8d37 
…7056)

## Description

Adding new name editor for JS object in toolbar under modularised flow.

Fixes [appsmithorg#36964](appsmithorg#36964)

## Automation

/ok-to-test tags="@tag.Sanity, @tag.JS"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11496788011>
> Commit: 7ae7ec7
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11496788011&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity, @tag.JS`
> Spec:
> <hr>Thu, 24 Oct 2024 10:42:17 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new optional name editor in the JSEditor, allowing users
to edit JavaScript object names dynamically.
- Enhanced the JSEditorToolbar to conditionally render the name editor
based on user permissions.

- **Bug Fixes**
- Simplified the props for the JSObjectNameEditor component by removing
unnecessary properties.

- **Documentation**
- Updated export statements to ensure accessibility of the new
JSObjectNameEditor component across modules.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankitakinger ankitakinger

Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Adding new name editor for JS object in toolbar appsmithorg/appsmith
1 participant
@ankitakinger