Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: JS Objects and Queries still show after moving it to another page #29697

Closed
1 task done
hetunandu opened this issue Dec 18, 2023 · 0 comments · Fixed by #29841
Closed
1 task done

[Task]: JS Objects and Queries still show after moving it to another page #29697

hetunandu opened this issue Dec 18, 2023 · 0 comments · Fixed by #29841
Assignees
@hetunandu
Labels
IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo

Comments

@hetunandu
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

SubTasks

Screen.Recording.2023-12-15.at.13.23.14.mov

Create two pages such that:

  • Page1 has JSObject1
  • Page2 has no JS objects
  1. go to Page1 and click the 3-dot menu on the js object and select move to—>Page 2
  2. now the IDE navigates you to Page2
  3. now click on Page1 again in the editor.

Expected: there are no js objects in Page1, so the screen should look like this:
Screenshot 2023-12-15 at 13 26 34

Actual: it still shows the old JS object from before the movement
Screenshot 2023-12-15 at 13 27 25
@hetunandu hetunandu added IDE Product Issues related to the IDE Product Task A simple Todo IDE Pod Issues that new developers face while exploring the IDE IDE Navigation Issues/feature requests related to IDE navigation, and context switching labels Dec 18, 2023
@hetunandu hetunandu mentioned this issue Dec 26, 2023
Merged
20 tasks
hetunandu added a commit that referenced this issue Dec 27, 2023
@hetunandu
fix: Context Switching fixes for Copy and Delete (#29841)
fc34360 
## Description
Fixes issues related to Segmented Lists around Copy / Delete
interactions

- It introduces a method to remove any focus history for a url. This is
added whenever we delete or move an item to another page
- It manages redirects after deleting a JS / Query / Datasource


#### PR fixes following issue(s)
Fixes #29697
Fixes #29694
Fixes #29700
Fixes #29699

#### Type of change

- Bug fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Implemented new redirect logic after deleting JavaScript collections,
actions, and datasources to enhance user experience.
- Added custom routing for JavaScript collection creation and
management.

- **Enhancements**
- Updated focus history handling to improve navigation and entity
tracking within the app.

- **Bug Fixes**
- Fixed entity identification logic in test paths to ensure accurate
testing scenarios.

- **Refactor**
- Centralized datasource grouping logic for better maintainability and
performance.
- Optimized widget deletion process to handle multiple widgets
efficiently.

- **Documentation**
	- No user-facing documentation updates in this release.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hetunandu hetunandu

Labels
IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Context Switching fixes for Copy and Delete appsmithorg/appsmith
2 participants
@hetunandu @albinAppsmith