Skip to content

Commit

Permalink
fix: turned on learnability flags on by default (#33283)
Browse files Browse the repository at this point in the history
Co-authored-by: “sneha122” <“[email protected]”>
  • Loading branch information
sneha122 and “sneha122” authored May 13, 2024
1 parent d1c9bde commit f9d00eb
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,6 @@ describe(

agHelper.GetNClick(oneClickBindingLocator.datasourceQuerySelector(), 0);

agHelper.AssertElementExist(
oneClickBindingLocator.dropdownOptionSelector("Query1"),
);

propPane.ToggleJSMode("Table data");

propPane.ValidatePropertyFieldValue("Table data", "{{Query1.data}}");

propPane.AssertJSToggleState("Table data", "enabled");
Expand Down
2 changes: 2 additions & 0 deletions app/client/cypress/support/Objects/FeatureFlags.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import produce from "immer";

const defaultFlags = {
release_side_by_side_ide_enabled: true,
ab_learnability_discoverability_collapse_all_except_data_enabled: false, // remove this flag from here when it's removed from code
rollout_remove_feature_walkthrough_enabled: false, // remove this flag from here when it's removed from code
};

export const featureFlagIntercept = (
Expand Down
8 changes: 4 additions & 4 deletions app/client/src/ce/entities/FeatureFlag.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,11 @@ export const DEFAULT_FEATURE_FLAG_VALUE: FeatureFlags = {
release_global_add_pane_enabled: false,
ab_appsmith_ai_query: false,
release_actions_redesign_enabled: false,
rollout_remove_feature_walkthrough_enabled: false,
rollout_js_enabled_one_click_binding_enabled: false,
rollout_remove_feature_walkthrough_enabled: true,
rollout_js_enabled_one_click_binding_enabled: true,
rollout_side_by_side_enabled: false,
ab_learnability_ease_of_initial_use_enabled: false,
ab_learnability_discoverability_collapse_all_except_data_enabled: false,
ab_learnability_ease_of_initial_use_enabled: true,
ab_learnability_discoverability_collapse_all_except_data_enabled: true,
release_layout_conversion_enabled: false,
};

Expand Down

0 comments on commit f9d00eb

Please sign in to comment.