fix: get all pages list for navigation

appsmithorg · Aug 8, 2024 · e8064dc · e8064dc
1 parent a9bc4e4
commit e8064dc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 21 deletions.
diff --git a/app/client/src/pages/AppViewer/index.tsx b/app/client/src/pages/AppViewer/index.tsx
@@ -19,7 +19,7 @@ import * as Sentry from "@sentry/react";
 import {
   getCurrentPageDescription,
   getIsAutoLayout,
-  getViewModePageListWithHiddenPages,
+  getPageList,
 } from "selectors/editorSelectors";
 import { getThemeDetails, ThemeMode } from "selectors/themeSelectors";
 import { getSearchQuery } from "utils/helpers";
@@ -88,7 +88,7 @@ function AppViewer(props: Props) {
   const { pathname, search } = props.location;
   const { baseApplicationId, basePageId } = props.match.params;
   const isInitialized = useSelector(getIsInitialized);
-  const pages = useSelector(getViewModePageListWithHiddenPages);
+  const pages = useSelector(getPageList);
   const selectedTheme = useSelector(getSelectedAppTheme);
   const lightTheme = useSelector((state: AppState) =>
     getThemeDetails(state, ThemeMode.LIGHT),

diff --git a/app/client/src/selectors/editorSelectors.tsx b/app/client/src/selectors/editorSelectors.tsx
@@ -255,25 +255,6 @@ export const getViewModePageList = createSelector(
   },
 );
 
-export const getViewModePageListWithHiddenPages = createSelector(
-  getPageList,
-  getCurrentPageId,
-  (pageList: PageListReduxState["pages"], currentPageId?: string) => {
-    if (currentPageId) {
-      const currentPage = pageList.find(
-        (page) => page.pageId === currentPageId,
-      );
-      if (!!currentPage?.isHidden) {
-        return [currentPage];
-      }
-
-      return pageList;
-    }
-
-    return [];
-  },
-);
-
 const defaultLayout: AppLayoutConfig = {
   type: "FLUID",
 };