fix: console log update and fix modal issue (#38692)

## Description
Fix the issue for modal and remove unwanted logs.


Fixes #
https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/38729

## Automation

/ok-to-test tags="@tag.JS"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12843319044>
> Commit: 8cd4512
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12843319044&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.JS`
> Spec:
> <hr>Sat, 18 Jan 2025 18:43:41 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **Tests**
- Improved test reliability by adding page reload and modal visibility
checks in end-to-end testing.
- Increased timeout for sidebar visibility checks to accommodate varying
load times.
- Removed unnecessary console log statements to clean up test output
across various test cases.
- Verified download functionality with various scenarios, ensuring
appropriate error messages are displayed.
- Streamlined tests for local storage operations by removing debug
output.
- Cleaned up test output for show alert functions by removing debug log
statements.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

app/client/cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_DownloadFunctions_spec.ts

@@ -71,7 +71,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.myFun1()}}`,
@@ -163,7 +162,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.myFun1()}}`,
@@ -238,7 +236,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.myFun1()}}`,
@@ -329,7 +326,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.myFun1()}}`,
@@ -404,7 +400,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.myFun1()}}`,
@@ -481,7 +476,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.myFun1()}}`,
@@ -572,7 +566,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.myFun1()}}`,
@@ -665,7 +658,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.myFun1()}}`,

app/client/cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_LocalRemoveValueFunctions_spec.ts

@@ -80,7 +80,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.storeValue()}}`,
@@ -93,7 +92,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button2", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.removeValue()}}`,
@@ -164,7 +162,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.removeNonExistentValue()}}`,
@@ -233,7 +230,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.removeInvalidKey()}}`,
@@ -354,7 +350,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.storeValues()}}`,
@@ -367,7 +362,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button2", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.removeValue1()}}`,
@@ -380,7 +374,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button3", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.removeValue2()}}`,
@@ -516,7 +509,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.storeValues()}}`,
@@ -529,7 +521,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button2", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.removeValue1()}}`,
@@ -628,7 +619,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.storeTempValue()}}`,
@@ -641,7 +631,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button2", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.removeTempValue()}}`,

app/client/cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_LocalStoreValueFunctions_spec.ts

@@ -68,7 +68,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.myFun1()}}`,
@@ -229,7 +228,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.myFun1()}}`,
@@ -311,7 +309,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.myFun1()}}`,

app/client/cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_NavigateToFunctions_spec.ts

@@ -7,6 +7,8 @@ import {
   entityExplorer,
   jsEditor,
   propPane,
+  homePage,
+  debuggerHelper,
 } from "../../../../support/Objects/ObjectsCore";
 import { EntityItems } from "../../../../support/Pages/AssertHelper";
 import EditorNavigation, {
@@ -177,9 +179,12 @@ describe(
       agHelper.AssertElementVisibility(appSettings.locators._header);
       agHelper.ClickButton("Submit");
       agHelper.AssertURL(pageTwoUrl);
+      agHelper.WaitUntilEleAppear(debuggerHelper.locators._debuggerIcon);
+      agHelper.CypressReload();
     });
 
     it("3. To verify add a navigation using URL containing links to third party websites", () => {
+      agHelper.RefreshPage();
       EditorNavigation.SelectEntityByName("Page1", EntityType.Page);
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", false);
@@ -250,6 +255,7 @@ describe(
     });
 
     it("4. To verify navigation to a hidden page in same as well a new window", () => {
+      agHelper.RefreshPage();
       PageList.AddNewPage();
       entityExplorer.ActionContextMenuByEntityName({
         entityNameinLeftSidebar: "Page3",

app/client/cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_ShowAlertFunctions_spec.ts

@@ -54,7 +54,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.myFun1()}}`,
@@ -110,7 +109,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.myFun1()}}`,
@@ -177,7 +175,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.myFun1()}}`,
@@ -252,7 +249,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.myFun1()}}`,
@@ -327,7 +323,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.myFun1()}}`,
@@ -402,7 +397,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.myFun1()}}`,

app/client/cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_ShowCloseModalFunctions_spec.ts

@@ -2,6 +2,7 @@ import {
   agHelper,
   apiPage,
   appSettings,
+  assertHelper,
   deployMode,
   draggableWidgets,
   entityExplorer,
@@ -50,23 +51,25 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.myFun1()}}`,
           true,
           false,
         );
       });
-      agHelper.RefreshPage();
+      agHelper.CypressReload();
+      agHelper.WaitUntilEleAppear(locators._modalWrapper);
       agHelper.AssertElementVisibility(locators._modalWrapper);
       agHelper.AssertText(locators._modalButtonText, "text", "Confirm", 2);
       agHelper.AssertText(locators._modalButtonText, "text", "Close", 1);
       agHelper.GetNClick(locators._closeModal, 0, true, 0);
 
       deployMode.DeployApp();
       agHelper.AssertElementVisibility(appSettings.locators._header);
-      agHelper.RefreshPage();
+      agHelper.CypressReload();
+      assertHelper.AssertNetworkStatus("@getConsolidatedData");
+      agHelper.WaitUntilEleAppear(locators._modalWrapper);
       agHelper.AssertElementVisibility(locators._modalWrapper);
       agHelper.AssertText(locators._modalButtonText, "text", "Confirm", 2);
       agHelper.AssertText(locators._modalButtonText, "text", "Close", 1);
@@ -92,6 +95,8 @@ describe(
       agHelper.ClickButton("Submit");
       agHelper.ValidateToastMessage("Modal2 is not defined", 0, 1);
       deployMode.NavigateBacktoEditor();
+      agHelper.CypressReload();
+      agHelper.WaitUntilEleAppear(locators._buttonByText("Submit"));
 
       const jsObjectBody = `export default {
         myFun1 () {
@@ -113,7 +118,6 @@ describe(
       EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.myFun1()}}`,
@@ -139,12 +143,13 @@ describe(
       EditorNavigation.SelectEntityByName("IconButton1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       propPane.EnterJSContext("onClick", `{{closeModal(Modal2.name);}}`, true);
-      agHelper.RefreshPage();
+      agHelper.CypressReload();
       agHelper.ClickButton("Submit");
       agHelper.GetNClick(locators._modalButtonText, 0, true, 0);
       agHelper.ValidateToastMessage("Modal2 is not defined", 0, 1);
 
       deployMode.DeployApp();
+      agHelper.CypressReload();
       agHelper.AssertElementVisibility(appSettings.locators._header);
       agHelper.ClickButton("Submit");
       agHelper.GetNClick(locators._modalButtonText, 0, true, 0);
@@ -174,25 +179,24 @@ describe(
       EditorNavigation.SelectEntityByName("IconButton1", EntityType.Widget);
       propPane.ToggleJSMode("onClick", true);
       cy.get("@jsObjectName").then((jsObjectName: string) => {
-        console.log("Mera variable: ", jsObjectName);
         propPane.EnterJSContext(
           "onClick",
           `{{${jsObjectName}.myFun1()}}`,
           true,
           false,
         );
       });
-      agHelper.RefreshPage();
+      agHelper.CypressReload();
       agHelper.ClickButton("Submit");
       agHelper.GetNClick(locators._modalButtonText, 0, true, 0);
       agHelper.ValidateToastMessage("Modal2 is not defined", 0, 1);
 
       deployMode.DeployApp();
+      agHelper.CypressReload();
       agHelper.AssertElementVisibility(appSettings.locators._header);
       agHelper.ClickButton("Submit");
       agHelper.GetNClick(locators._modalButtonText, 0, true, 0);
       agHelper.ValidateToastMessage("Modal2 is not defined", 0, 1);
-      deployMode.NavigateBacktoEditor();
     });
   },
 );

app/client/cypress/support/Pages/IDE/Sidebar.ts

@@ -10,7 +10,7 @@ export class Sidebar {
   }
 
   navigate(button: string, willFail = false) {
-    this.assertVisible();
+    this.assertVisible(Cypress.config().pageLoadTimeout);
     cy.get(this.locators.sidebar)
       .find(this.locators.sidebarButton(button))
       .as("navigateBtn")
@@ -22,7 +22,7 @@ export class Sidebar {
     );
   }
 
-  assertVisible(timeout: number = 10000) {
+  assertVisible(timeout: number = 60000) {
     cy.get(this.locators.sidebar, { timeout }).should("be.visible");
   }
 }