fix: Overflow list new UI restore (#34658)

## Description

Overflow list view changes was reverted because of Anvil failures in EE.
This PR add the changes back.


Fixes #33432 

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9802067318>
> Commit: 18b7a57
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9802067318&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank">Cypress dashboard</a>.
> Tags: @tag.All
> The following are new failures, please fix them before merging the PR:
<ol>
>
<li>cypress/e2e/Regression/ClientSide/PartialImportExport/PartialExport_spec.ts</ol>
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">List of identified flaky tests</a>.
> <hr>Fri, 05 Jul 2024 03:11:20 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced several new React components (`FileTab`, `AddTab`, `List`,
`ScreenModeToggle`, `EditorTabs`) to enhance the IDE tab management and
user interaction.

- **Bug Fixes**
- Improved drag-and-drop (DnD) simulation logic by using `realMouseMove`
method.

- **Refactor**
- Simplified and refactored the `FileTabs` component, improving its
encapsulation and rendering logic.
- Enhanced state and props handling across various tab components and
hooks.

- **Tests**
- Updated test IDs and test logic to ensure consistency and correctness
for tab interactions and states.
  
- **Style**
- Updated styled components, replacing tab-related styles with
list-related styles to improve UI consistency.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

app/client/cypress/e2e/Regression/ClientSide/IDE/IDE_Add_Pane_Interactions_spec.ts

@@ -68,7 +68,7 @@ describe("IDE add pane interactions", { tags: ["@tag.IDE"] }, () => {
     // check add pane
     PageLeftPane.assertInAddView();
     // close add tab
-    FileTabs.closeTab("new");
+    FileTabs.closeTab("new_query");
     // open add pane to add item
     PageLeftPane.switchToAddNew();
     // add item

app/client/cypress/support/Pages/Anvil/AnvilDnDHelper.ts

@@ -60,14 +60,8 @@ export class AnvilDnDHelper {
       eventConstructor: "MouseEvent",
       force: true,
     });
-    cy.get(dropAreaSelector).first().trigger("mousemove", xPos, yPos, {
-      eventConstructor: "MouseEvent",
-      force: true,
-    });
-    cy.get(dropAreaSelector).first().trigger("mousemove", xPos, yPos, {
-      eventConstructor: "MouseEvent",
-      force: true,
-    });
+    cy.get(dropAreaSelector).first().realMouseMove(xPos, yPos);
+    cy.get(dropAreaSelector).first().realMouseMove(xPos, yPos);
     if (!options.dropTargetDetails?.dropModal) {
       // no need to show highlight for modal drop
       cy.get(this.locator._anvilDnDHighlight);

app/client/cypress/support/Pages/IDE/FileTabs.ts

@@ -1,8 +1,10 @@
 import { ObjectsRegistry } from "../../Objects/Registry";
+import { sanitizeString } from "../../../../src/utils/URLUtils";
 class FileTabs {
   locators = {
     container: "[data-testid='t--editor-tabs']",
-    tabName: (name: string) => `[data-testid='t--ide-tab-${name}']`,
+    tabName: (name: string) =>
+      `[data-testid='t--ide-tab-${sanitizeString(name)}']`,
     tabs: ".editor-tab",
     addItem: "[data-testid='t--ide-tabs-add-button']",
     closeTab: "[data-testid='t--tab-close-btn']",

app/client/src/IDE/Components/FileTab.tsx

@@ -0,0 +1,98 @@
+import React from "react";
+import styled from "styled-components";
+import clsx from "classnames";
+
+import { Flex, Icon } from "design-system";
+import { sanitizeString } from "utils/URLUtils";
+
+interface FileTabProps {
+  isActive: boolean;
+  title: string;
+  onClick: () => void;
+  onClose: (e: React.MouseEvent) => void;
+  icon?: React.ReactNode;
+}
+
+export const StyledTab = styled(Flex)`
+  position: relative;
+  height: 100%;
+  font-size: 12px;
+  color: var(--ads-v2-colors-text-default);
+  cursor: pointer;
+  gap: var(--ads-v2-spaces-2);
+  border-top: 1px solid transparent;
+  border-top-left-radius: var(--ads-v2-border-radius);
+  border-top-right-radius: var(--ads-v2-border-radius);
+  align-items: center;
+  justify-content: center;
+  padding: var(--ads-v2-spaces-3);
+  border-left: 1px solid transparent;
+  border-right: 1px solid transparent;
+  border-top: 2px solid transparent;
+
+  &.active {
+    background: var(--ads-v2-colors-control-field-default-bg);
+    border-top-color: var(--ads-v2-color-bg-brand);
+    border-left-color: var(--ads-v2-color-border-muted);
+    border-right-color: var(--ads-v2-color-border-muted);
+  }
+
+  & > .tab-close {
+    position: relative;
+    right: -2px;
+    visibility: hidden;
+  }
+
+  &:hover > .tab-close {
+    visibility: visible;
+  }
+
+  &.active > .tab-close {
+    visibility: visible;
+  }
+`;
+
+export const TabTextContainer = styled.span`
+  width: 100%;
+  text-overflow: ellipsis;
+  white-space: nowrap;
+  overflow: hidden;
+`;
+
+export const TabIconContainer = styled.div`
+  height: 12px;
+  width: 12px;
+  display: flex;
+  align-items: center;
+  justify-content: center;
+  flex-shrink: 0;
+  img {
+    width: 12px;
+  }
+`;
+
+export const FileTab = ({
+  icon,
+  isActive,
+  onClick,
+  onClose,
+  title,
+}: FileTabProps) => {
+  return (
+    <StyledTab
+      className={clsx("editor-tab", isActive && "active")}
+      data-testid={`t--ide-tab-${sanitizeString(title)}`}
+      onClick={onClick}
+    >
+      {icon ? <TabIconContainer>{icon}</TabIconContainer> : null}
+      <TabTextContainer>{title}</TabTextContainer>
+      {/* not using button component because of the size not matching design */}
+      <Icon
+        className="tab-close rounded-[4px] hover:bg-[var(--ads-v2-colors-action-tertiary-surface-hover-bg)] cursor-pointer p-[2px]"
+        data-testid="t--tab-close-btn"
+        name="close-line"
+        onClick={onClose}
+      />
+    </StyledTab>
+  );
+};

app/client/src/ce/pages/Editor/IDE/EditorPane/JS/hooks.ts

@@ -17,6 +17,7 @@ import history from "utils/history";
 import { FocusEntity, identifyEntityFromPath } from "navigation/FocusEntity";
 import { useModuleOptions } from "@appsmith/utils/moduleInstanceHelpers";
 import { getJSUrl } from "@appsmith/pages/Editor/IDE/EditorPane/JS/utils";
+import { JSBlankState } from "pages/Editor/JSEditor/JSBlankState";
 
 export const useJSAdd = () => {
   const pageId = useSelector(getCurrentPageId);
@@ -95,7 +96,7 @@ export const useJSSegmentRoutes = (path: string): UseRoutes => {
       },
       {
         key: "JSEmpty",
-        component: ListJS,
+        component: JSBlankState,
         exact: true,
         path: [path],
       },

app/client/src/ce/pages/Editor/IDE/EditorPane/Query/hooks.tsx

@@ -38,6 +38,7 @@ import { Tag, type ListItemProps } from "design-system";
 import { useCurrentEditorState } from "pages/Editor/IDE/hooks";
 import CurlImportEditor from "pages/Editor/APIEditor/CurlImportEditor";
 import { createAddClassName } from "pages/Editor/IDE/EditorPane/utils";
+import { QueriesBlankState } from "pages/Editor/QueryEditor/QueriesBlankState";
 
 export const useQueryAdd = () => {
   const location = useLocation();
@@ -161,7 +162,7 @@ export const useQuerySegmentRoutes = (path: string): UseRoutes => {
       },
       {
         key: "QueryEmpty",
-        component: ListQuery,
+        component: QueriesBlankState,
         exact: true,
         path: [path],
       },

app/client/src/ce/selectors/appIDESelectors.ts

@@ -6,6 +6,7 @@ import {
   getQuerySegmentItems,
 } from "@appsmith/selectors/entitiesSelector";
 import { getJSTabs, getQueryTabs } from "selectors/ideSelectors";
+import type { AppState } from "@appsmith/reducers";
 
 export type EditorSegmentList = Array<{
   group: string | "NA";
@@ -45,28 +46,22 @@ export const selectJSSegmentEditorList = createSelector(
   },
 );
 
-export const selectJSSegmentEditorTabs = createSelector(
-  getJSSegmentItems,
-  getJSTabs,
-  (items, tabs) => {
-    const keyedItems = keyBy(items, "key");
-    return tabs
-      .map((tab) => {
-        return keyedItems[tab];
-      })
-      .filter(Boolean);
-  },
-);
+export const selectJSSegmentEditorTabs = (state: AppState) => {
+  const items = getJSSegmentItems(state);
+  const tabs = getJSTabs(state);
 
-export const selectQuerySegmentEditorTabs = createSelector(
-  getQuerySegmentItems,
-  getQueryTabs,
-  (items, tabs) => {
-    const keyedItems = keyBy(items, "key");
-    return tabs
-      .map((tab) => {
-        return keyedItems[tab];
-      })
-      .filter(Boolean);
-  },
-);
+  const keyedItems = keyBy(items, "key");
+  return tabs
+    .map((tab) => {
+      return keyedItems[tab];
+    })
+    .filter(Boolean);
+};
+
+export const selectQuerySegmentEditorTabs = (state: AppState) => {
+  const items = getQuerySegmentItems(state);
+  const tabs = getQueryTabs(state);
+
+  const keyedItems = keyBy(items, "key");
+  return tabs.map((tab) => keyedItems[tab]).filter(Boolean);
+};

app/client/src/pages/Editor/IDE/EditorPane/EditorPaneSegments.tsx

@@ -6,7 +6,7 @@ import QueriesSegment from "./Query";
 import WidgetsSegment from "./UI";
 import JSSegment from "./JS";
 import SegmentedHeader from "./components/SegmentedHeader";
-import EditorTabs from "../EditorTabs/SplitScreenTabs";
+import EditorTabs from "../EditorTabs";
 import {
   jsSegmentRoutes,
   querySegmentRoutes,
@@ -17,19 +17,23 @@ import {
   BUILDER_PATH,
   BUILDER_PATH_DEPRECATED,
 } from "@appsmith/constants/routes/appRoutes";
+import { useSelector } from "react-redux";
+import { getIDEViewMode } from "selectors/ideSelectors";
+import { EditorViewMode } from "@appsmith/entities/IDE/constants";
 
 const EditorPaneSegments = () => {
   const { path } = useRouteMatch();
+  const ideViewMode = useSelector(getIDEViewMode);
 
   return (
     <Flex
+      className="relative"
       flexDirection="column"
-      gap="spacing-2"
       height="100%"
       overflow="hidden"
     >
       <SegmentedHeader />
-      <EditorTabs />
+      {ideViewMode === EditorViewMode.SplitScreen ? <EditorTabs /> : null}
       <Flex
         className="ide-editor-left-pane__content"
         flexDirection="column"

app/client/src/pages/Editor/IDE/EditorPane/JS/JSRender.test.tsx

@@ -151,7 +151,7 @@ describe("IDE Render: JS", () => {
       ).toBe(true);
       // Tabs active state
       expect(
-        getByTestId("t--ide-tab-JSObject1").classList.contains("active"),
+        getByTestId("t--ide-tab-jsobject1").classList.contains("active"),
       ).toBe(true);
       // Check if the form is rendered
       expect(container.querySelector(".js-editor-tab")).not.toBeNull();
@@ -201,7 +201,7 @@ describe("IDE Render: JS", () => {
       expect(getAllByText("JSObject2").length).toBe(2);
       // Tabs active state
       expect(
-        getByTestId("t--ide-tab-JSObject2").classList.contains("active"),
+        getByTestId("t--ide-tab-jsobject2").classList.contains("active"),
       ).toBe(true);
 
       // Check if the form is rendered
@@ -245,7 +245,7 @@ describe("IDE Render: JS", () => {
       expect(getAllByText("JSObject3").length).toEqual(2);
       // Tabs active state
       expect(
-        getByTestId("t--ide-tab-JSObject3").classList.contains("active"),
+        getByTestId("t--ide-tab-jsobject3").classList.contains("active"),
       ).toBe(false);
       // Check js object is not rendered. Instead new tab should render
       expect(container.querySelector(".js-editor-tab")).toBeNull();
@@ -283,7 +283,7 @@ describe("IDE Render: JS", () => {
       expect(getAllByText("JSObject4").length).toEqual(1);
       // Tabs active state
       expect(
-        getByTestId("t--ide-tab-JSObject4").classList.contains("active"),
+        getByTestId("t--ide-tab-jsobject4").classList.contains("active"),
       ).toBe(false);
 
       // Check if the form is not rendered

app/client/src/pages/Editor/IDE/EditorPane/JS/List.tsx

@@ -51,6 +51,7 @@ const ListJSObjects = () => {
   return (
     <JSContainer
       className="ide-editor-left-pane__content-js"
+      flex="1"
       flexDirection="column"
       gap="spaces-3"
       overflow="hidden"
@@ -77,7 +78,6 @@ const ListJSObjects = () => {
       >
         <Flex
           data-testid="t--ide-list"
-          flex="1"
           flexDirection="column"
           gap="spaces-4"
           overflowY="auto"