Skip to content

Commit

Permalink
chore: add logs in computeConsolidatedAPIResponseEtag fn (#38948)
Browse files Browse the repository at this point in the history
## Description
Add logs in computeConsolidatedAPIResponseEtag fn

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13090174583>
> Commit: 159925b
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13090174583&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Sat, 01 Feb 2025 17:24:22 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
  • Loading branch information
dvj1988 authored Feb 2, 2025
1 parent 81c5d47 commit 946e687
Showing 1 changed file with 8 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -648,6 +648,10 @@ private boolean isPossibleToCreateQueryWithoutDatasource(Plugin plugin) {
@NotNull public String computeConsolidatedAPIResponseEtag(
ConsolidatedAPIResponseDTO consolidatedAPIResponseDTO, String defaultPageId, String applicationId) {
if (isBlank(defaultPageId) && isBlank(applicationId)) {
log.debug(
"Skipping etag computation: Both defaultPageId '{}', and applicationId '{}' are blank",
defaultPageId,
applicationId);
return "";
}

Expand All @@ -664,6 +668,10 @@ private boolean isPossibleToCreateQueryWithoutDatasource(Plugin plugin) {
: null;

if (lastDeployedAt == null) {
log.debug(
"Skipping etag computation: lastDeployedAt is null for applicationId '{}', pageId '{}'",
applicationId,
defaultPageId);
return "";
}

Expand Down

0 comments on commit 946e687

Please sign in to comment.