Skip to content

Commit

Permalink
resolving cyclic dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
ankitakinger committed Oct 18, 2024
1 parent 91a7487 commit 8fd3fa3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions app/client/src/ce/entities/IDE/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,16 @@ import {
BUILDER_PATH,
BUILDER_PATH_DEPRECATED,
} from "ee/constants/routes/appRoutes";
import type { NameSaveActionParams } from "utils/hooks/useNameEditor";
import { saveActionName } from "actions/pluginActionActions";
import { saveJSObjectName } from "actions/jsActionActions";
import { EditorEntityTab, type EntityItem } from "ee/entities/IDE/constants";
import type { ReduxAction } from "ee/constants/ReduxActionConstants";
import { getHasManageActionPermission } from "ee/utils/BusinessFeatures/permissionPageHelpers";

export interface SaveEntityName {
params: NameSaveActionParams;
params: {
name: string;
id: string;
};
segment: EditorEntityTab;
entity?: EntityItem;
}
Expand Down Expand Up @@ -49,8 +50,7 @@ export function getBaseUrlsForIDEType(type: IDEType): string[] {
}

export const saveEntityName = ({ params, segment }: SaveEntityName) => {
let saveNameAction: ReduxAction<NameSaveActionParams> =
saveActionName(params);
let saveNameAction = saveActionName(params);

if (EditorEntityTab.JS === segment) {
saveNameAction = saveJSObjectName(params);
Expand Down
2 changes: 1 addition & 1 deletion app/client/src/utils/hooks/useNameEditor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
import type { ReduxAction } from "ee/constants/ReduxActionConstants";
import { useEventCallback } from "usehooks-ts";

export interface NameSaveActionParams {
interface NameSaveActionParams {
name: string;
id: string;
}
Expand Down

0 comments on commit 8fd3fa3

Please sign in to comment.