Skip to content

Commit

Permalink
chore: [Plugin Action Editor] Implement a useIsEditorIsInitialised ho…
Browse files Browse the repository at this point in the history
…ok (#36328)

## Description

Implements a new IDE level hook that looks at the editor state and
returns it. This hook gets overriden with EE logic.

EE PR: appsmithorg/appsmith-ee#5151


Related to #34324

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10882119504>
> Commit: 330560e
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10882119504&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Mon, 16 Sep 2024 11:06:52 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a new hook, `useIsEditorInitialised`, for improved
management of the editor's initialization state.
- Enhanced the `PluginActionEditor` component to utilize the new hook,
streamlining the initialization state access.

- **Bug Fixes**
- Removed reliance on Redux for the editor's initialization state in
favor of the new hook, improving performance and readability.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
hetunandu authored Sep 16, 2024
1 parent 4c7ce27 commit 4dcec5f
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 2 deletions.
1 change: 1 addition & 0 deletions app/client/src/IDE/hooks/index.ts
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
export { useIsInSideBySideEditor } from "./useIsInSideBySideEditor";
export { useIsEditorInitialised } from "ee/IDE/hooks/useIsEditorInitialised";
4 changes: 2 additions & 2 deletions app/client/src/PluginActionEditor/PluginActionEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ import {
import { PluginActionContextProvider } from "./PluginActionContext";
import { get } from "lodash";
import EntityNotFoundPane from "pages/Editor/EntityNotFoundPane";
import { getIsEditorInitialized } from "selectors/editorSelectors";
import Spinner from "components/editorComponents/Spinner";
import CenteredWrapper from "components/designSystems/appsmith/CenteredWrapper";
import { Text } from "@appsmith/ads";
import { useIsEditorInitialised } from "IDE/hooks";

interface ChildrenProps {
children: React.ReactNode | React.ReactNode[];
Expand All @@ -24,7 +24,7 @@ interface ChildrenProps {
const PluginActionEditor = (props: ChildrenProps) => {
const { pathname } = useLocation();

const isEditorInitialized = useSelector(getIsEditorInitialized);
const isEditorInitialized = useIsEditorInitialised();

const entity = identifyEntityFromPath(pathname);
const action = useSelector((state) => getActionByBaseId(state, entity.id));
Expand Down
8 changes: 8 additions & 0 deletions app/client/src/ce/IDE/hooks/useIsEditorInitialised.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import { useSelector } from "react-redux";
import { getIsEditorInitialized } from "selectors/editorSelectors";

function useIsEditorInitialised() {
return useSelector(getIsEditorInitialized);
}

export { useIsEditorInitialised };
1 change: 1 addition & 0 deletions app/client/src/ee/IDE/hooks/useIsEditorInitialised.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { useIsEditorInitialised } from "ce/IDE/hooks/useIsEditorInitialised";

0 comments on commit 4dcec5f

Please sign in to comment.