Skip to content

Commit

Permalink
fix: Release blocker: toast with whitespace (#36629)
Browse files Browse the repository at this point in the history
## Description

There was an extra space infront of toast content which cause cypress
failures. This PR address that issue.

PR cause this issue: #36126

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11121364189>
> Commit: a114bff
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11121364189&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Tue, 01 Oct 2024 09:28:44 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
	- Minor formatting adjustments made to the Toast component.
- Added a TODO comment regarding future accessibility features for
toasts.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
albinAppsmith authored Oct 1, 2024
1 parent 367ac87 commit 2e2146d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/client/packages/design-system/ads/src/Toast/Toast.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const toast = {

return toastifyToast(
<ToastBody kind="body-m">
<StyledPre> {content}</StyledPre>
<StyledPre>{content}</StyledPre>
{actionText && (
<StyledButton
kind="tertiary"
Expand Down

0 comments on commit 2e2146d

Please sign in to comment.