review improvements

app/client/src/PluginActionEditor/components/PluginActionForm/components/CommonEditorForm/hooks/useGetFormActionValues.ts

@@ -3,13 +3,30 @@ import { API_EDITOR_FORM_NAME } from "ee/constants/forms";
 import { getCurrentEnvironmentId } from "ee/selectors/environmentSelectors";
 import get from "lodash/get";
 import { useSelector } from "react-redux";
-import type { Action, ApiAction, Property } from "entities/Action";
+import {
+  type Action,
+  type ApiAction,
+  isAPIAction,
+  type Property,
+} from "entities/Action";
 import { getDatasources } from "ee/selectors/entitiesSelector";
 
 function useGetFormActionValues() {
-  const formValues = useSelector(
-    getFormValues(API_EDITOR_FORM_NAME),
-  ) as ApiAction;
+  const formValues = useSelector(getFormValues(API_EDITOR_FORM_NAME)) as Action;
+  const datasources = useSelector(getDatasources);
+  const currentEnvironment = useSelector(getCurrentEnvironmentId);
+
+  // In an unlikely scenario where form is not initialised,
+  // return empty values to avoid form ui issues
+  if (!isAPIAction(formValues)) {
+    return {
+      actionHeaders: [],
+      actionParams: [],
+      autoGeneratedHeaders: [],
+      datasourceParams: [],
+      datasourceHeaders: [],
+    };
+  }
 
   const actionHeaders = get(
     formValues,
@@ -26,21 +43,17 @@ function useGetFormActionValues() {
     [],
   ) as Property[];
 
-  const datasources = useSelector(getDatasources);
-
   let datasourceFromAction: Action["datasource"] | undefined = get(
     formValues,
     "datasource",
   );
 
-  if (datasourceFromAction && datasourceFromAction.hasOwnProperty("id")) {
+  if (datasourceFromAction && Object.hasOwn(datasourceFromAction, "id")) {
     datasourceFromAction = datasources.find(
       (d) => d.id === datasourceFromAction?.id,
     );
   }
 
-  const currentEnvironment = useSelector(getCurrentEnvironmentId);
-
   const datasourceHeaders = get(
     datasourceFromAction,
     `datasourceStorages.${currentEnvironment}.datasourceConfiguration.headers`,